Discussed with Dan Horak. While updating Fedora, grub2-mkconfig displays this error and fails to properly setup the new boot menu entries: /etc/grub.d/10_linux: line 234: test: 0ed84c0-p94177c1: integer expression expected /etc/grub.d/10_linux: line 235: test: 0ed84c0-p94177c1: integer expression expected The problem appears to be because the PPC64 specific code queries the version of Petitboot and expects some sort of sane version number, but this Talos II has a hashed version: # cat /sys/firmware/devicetree/base/ibm,firmware-versions/petitboot 0ed84c0-p94177c1 Dan mentions this has been observed on other systems. Workaround is to hack /etc/grub.d/10_linux to just fall through by setting a bogus filesystem location. With this, grub2-mkconfig runs properly.
Javier, could you take a look as you wrote the petitboot handler?
Sure, I'll look at this.
Could you please try with the following test build ? https://koji.fedoraproject.org/koji/taskinfo?taskID=63489328
Created attachment 1762288 [details] [PATCH] 10_linux.in: Check if petitboot sysfs has a valid version That test build contains the attached patch that checks if the petitboot sysfs entry has a valid version and only in this case attempts to infer if has support to parse BLS snippets.
(In reply to Javier Martinez Canillas from comment #3) > Could you please try with the following test build ? > > https://koji.fedoraproject.org/koji/taskinfo?taskID=63489328 Sorry, the correct test build URL is: https://koji.fedoraproject.org/koji/taskinfo?taskID=63490387
Cameron, do you still have the system where you could verify the fix?
FEDORA-2021-ae424d66e4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ae424d66e4
FEDORA-2021-877d63ab63 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-877d63ab63
FEDORA-2021-877d63ab63 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-877d63ab63` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-877d63ab63 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-ae424d66e4 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-ae424d66e4` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ae424d66e4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
I manually applied the patch to /etc/grub.d/10_linux and confirmed I no longer get the error and the generated entries appear appropriate.
FEDORA-2021-ae424d66e4 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-b934ee272b has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-b934ee272b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b934ee272b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-6e172a47e2 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-c5ed9c3970 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-c5ed9c3970` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-c5ed9c3970 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-c5ed9c3970 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.