Hide Forgot
Created attachment 1751684 [details] screenshot where the checkbox will appear Description of problem: The buildflag "rnnoise" seems to be removed in Fedora's mumble package: https://src.fedoraproject.org/rpms/mumble/blob/master/f/mumble.spec#_136 Please include Mumble's RRNoise feature: https://wiki.mumble.info/wiki/Audio#RNNoise Version-Release number of selected component (if applicable): Next future release How reproducible: This is a feature request. So; All the time I guess? :) Steps to Reproduce: To see if the feature is working and to test this go to Configure Mumble -> Audio Input -> RNNoise checkbox in "Audio Processing". Actual results: No checkbox for the feature. Expected results: The feature should be possible to enable.
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34.
I have tested it working on Fedora 33 with the following changes to the spec file: diff --git a/mumble.spec b/mumble.spec index 38ac23b..1feb743 100644 --- a/mumble.spec +++ b/mumble.spec @@ -116,9 +116,6 @@ pushd 3rdparty # remove bundled libraries that we have system copies of rm -r opus-src speex-src speexdsp-src -# remove bundled libraries for disabled features -rm -r rnnoise-src - # remove bundled libraries for windows rm -r GL minhook-src xinputcheck-src @@ -132,7 +129,6 @@ popd %{qmake_qt5} \ CONFIG+=no-bundled-speex \ CONFIG+=no-bundled-opus \ -CONFIG+=no-rnnoise \ CONFIG+=no-g15 \ CONFIG+=no-oss \ CONFIG+=no-update \ The 'pulseeffects' package already builds-in RNNoise and is shipped by Fedora, so there likely aren't any license issues blocking this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > All packages whose upstreams allow them to be built against system libraries MUST be built against system libraries. Mumble supports this with CONFIG+=no-bundled-rnnoise. If someone else packages rnnoise, I don't mind updating the spec file to link against it. In theory pulseeffects would also be able to use that. Mumble already has enough bundled libraries, we should be working to remove them where possible, not add more.
FEDORA-2021-e70b27155e has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-8ff2bcc706 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8ff2bcc706
FEDORA-2021-f743c0c014 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f743c0c014
FEDORA-2021-8ff2bcc706 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8ff2bcc706` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8ff2bcc706 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-f743c0c014 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-f743c0c014` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f743c0c014 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
I've tested the RNNoise audio processing on 33 with 8ff2bcc706 and it works perfectly!
FEDORA-2021-8ff2bcc706 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-f743c0c014 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.