Spec URL: https://eclipseo.fedorapeople.org/for-review/jpeg-xl.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/jpeg-xl-0.3-1.fc34.src.rpm Description: This package contains a reference implementation of JPEG XL (encoder and decoder). As previously announced, it is available under a royalty-free and open source license (Apache 2). Fedora Account System Username: eclipseo
New Spec URL: https://eclipseo.fedorapeople.org/for-review/jpeg-xl.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/jpeg-xl-0.3.7-1.fc35.src.rpm
Built in COPR: https://copr.fedorainfracloud.org/coprs/eclipseo/jpeg-xl/build/2123459/
New Spec URL: https://eclipseo.fedorapeople.org/for-review/jpegxl.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/jpegxl-0.3.7-1.fc35.src.rpm
Built in COPR: https://copr.fedorainfracloud.org/coprs/build/2198208 Changes are: - Renamed the package from jpeg-xl to jpegxl - Split the reference software in a utils subpackage, to match similar codecs standards - Added licenses for bundled libraries - Added asciidoc as a BR to build the man pages for the reference software
ERROR: Command failed: # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 35 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/jpegxl-0.3.7-1.fc35.src.rpm --setopt=tsflags=nocontexts No matches found for the following disable plugin patterns: local, spacewalk fedora 1.5 MB/s | 57 MB 00:37 Last metadata expiration check: 0:00:24 ago on Wed May 19 12:28:47 2021. Package gdk-pixbuf2-devel-2.42.2-2.fc35.x86_64 is already installed. Package brotli-devel-1.0.9-4.fc34.x86_64 is already installed. No matching package to install: 'pkgconfig(libhwy)' Package libpng-devel-2:1.6.37-9.fc35.x86_64 is already installed. Package zlib-devel-1.2.11-24.fc34.x86_64 is already installed. Not all dependencies satisfied Error: Some packages could not be found. Where is pkgconfig(libhwy)? It does not exist in your Copr builds neither.
It's the package "highway" that I pushed yesterday in Rawhide. It's probabably not in the latest compose yet so you have to add the local Koji repo for it to work. You could also grab it from COPR here https://download.copr.fedorainfracloud.org/results/eclipseo/jpeg-xl/fedora-rawhide-x86_64/02198197-highway/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ Problem: conflicting requests - nothing provides libsjpeg.so.0.1()(64bit) needed by jpegxl-utils-0.3.7-1.fc35.x86_64 - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2662400 bytes in 312 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation Consider to install %doc %{_vpath_builddir}/html (2.4 MB) documentation by a doc subpackage. - libsjpeg* look not installed but required - 'shared-mime-info' is required by 'jpegxl-libs' /usr/share/thumbnailers is a directory not owned yet ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "zlib/libpng license BSD 3-clause "New" or "Revised" License", "Expat License Apache License 2.0", "zlib/libpng license Apache License 2.0", "zlib/libpng license", "BSD 3-clause "New" or "Revised" License". 170 files have unknown license. Detailed output of licensecheck in /home/sagitter/1922638-jpegxl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/thumbnailers, /usr/share/mime, /usr/share/mime/packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jpegxl- utils , jpegxl-libs , jpegxl-devel , jxl-pixbuf-loader , gimp-jxl- plugin [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2795520 bytes in /usr/share [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.10 starting (python version = 3.9.5, NVR = mock-2.10-1.fc34)... Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.10 INFO: Mock Version: 2.10 Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.10 INFO: Mock Version: 2.10 Finish: chroot init INFO: installing package(s): /builddir/jxl-pixbuf-loader-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-libs-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-libs-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-debugsource-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/gimp-jxl-plugin-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-utils-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-utils-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-devel-0.3.7-1.fc35.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M a531be4b22994f429050789ecaffba56 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.6hzxir1k:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 35 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /builddir/jxl-pixbuf-loader-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-libs-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-libs-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-debugsource-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/gimp-jxl-plugin-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-utils-debuginfo-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-utils-0.3.7-1.fc35.x86_64.rpm /builddir/jpegxl-devel-0.3.7-1.fc35.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: jpegxl-utils-0.3.7-1.fc35.x86_64.rpm jpegxl-libs-0.3.7-1.fc35.x86_64.rpm jpegxl-devel-0.3.7-1.fc35.x86_64.rpm jxl-pixbuf-loader-0.3.7-1.fc35.x86_64.rpm gimp-jxl-plugin-0.3.7-1.fc35.x86_64.rpm jpegxl-debuginfo-0.3.7-1.fc35.x86_64.rpm jpegxl-debugsource-0.3.7-1.fc35.x86_64.rpm jpegxl-0.3.7-1.fc35.src.rpm jpegxl-libs.x86_64: W: no-documentation jxl-pixbuf-loader.x86_64: W: no-documentation gimp-jxl-plugin.x86_64: W: no-documentation jpegxl.src:57: W: unversioned-explicit-provides bundled(lodepng) jpegxl.src:59: W: unversioned-explicit-provides bundled(sjpeg) jpegxl.src:61: W: unversioned-explicit-provides bundled(skcms) jpegxl.src: W: invalid-url Source1: third_party-0.3.7.tar.gz 8 packages and 0 specfiles checked; 0 errors, 7 warnings. Unversioned so-files -------------------- jxl-pixbuf-loader: /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-jxl.so Source checksums ---------------- https://gitlab.com/wg1/jpeg-xl/-/archive/v0.3.7/jpeg-xl-0.3.7.tar.bz2 : CHECKSUM(SHA256) this package : ff16821452ecd9fa3bd13141d8883409390967b0445ee1eddb8831dfd41e6a5b CHECKSUM(SHA256) upstream package : ff16821452ecd9fa3bd13141d8883409390967b0445ee1eddb8831dfd41e6a5b Requires -------- jpegxl-utils (rpmlib, GLIBC filtered): libHalf-2_5.so.25()(64bit) libIlmImf-2_5.so.25()(64bit) libbrotlidec.so.1()(64bit) libbrotlienc.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgif.so.7()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libsjpeg.so.0.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) jpegxl-libs (rpmlib, GLIBC filtered): libbrotlidec.so.1()(64bit) libbrotlienc.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) jpegxl-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config jpegxl-libs(x86-64) libjxl.so.0()(64bit) libjxl_threads.so.0()(64bit) pkgconfig(libbrotlicommon) pkgconfig(libbrotlidec) pkgconfig(libbrotlienc) jxl-pixbuf-loader (rpmlib, GLIBC filtered): gdk-pixbuf2 libbrotlidec.so.1()(64bit) libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) gimp-jxl-plugin (rpmlib, GLIBC filtered): gimp libbabl-0.1.so.0()(64bit) libbabl-0.1.so.0(V0_1_0)(64bit) libbrotlidec.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgegl-0.4.so.0()(64bit) libgimp-2.0.so.0()(64bit) libgimpcolor-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) jpegxl-debuginfo (rpmlib, GLIBC filtered): jpegxl-debugsource (rpmlib, GLIBC filtered): Provides -------- jpegxl-utils: jpegxl-utils jpegxl-utils(x86-64) jpegxl-libs: jpegxl-libs jpegxl-libs(x86-64) libjxl.so.0()(64bit) libjxl.so.0(JXL_0)(64bit) libjxl_threads.so.0()(64bit) jpegxl-devel: jpegxl-devel jpegxl-devel(x86-64) pkgconfig(libjxl) pkgconfig(libjxl_threads) jxl-pixbuf-loader: jxl-pixbuf-loader jxl-pixbuf-loader(x86-64) libpixbufloader-jxl.so()(64bit) gimp-jxl-plugin: gimp-jxl-plugin gimp-jxl-plugin(x86-64) jpegxl-debuginfo: jpegxl-debuginfo jpegxl-debuginfo(x86-64) jpegxl-debugsource: jpegxl-debugsource jpegxl-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --mock-options=--no-clean -m fedora-rawhide-x86_64 -b 1922638 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Python, Haskell, Perl, R, Java, fonts, SugarActivity, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Antonio T. sagitter from comment #7) > Issues: > ======= > - Package installs properly. > Note: Installation errors (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > Problem: conflicting requests > - nothing provides libsjpeg.so.0.1()(64bit) needed by > jpegxl-utils-0.3.7-1.fc35.x86_64 > I have two solutions possible for this: build the binaries with static libraries included in them or unbundle sjpeg and make it a separate package. What do you think is the best option? I had already made a sjpeg package for testing but I haven't submitted it yet for review. > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 2662400 bytes in 312 files. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_documentation > > Consider to install %doc %{_vpath_builddir}/html (2.4 MB) documentation by > a doc subpackage. > Done > - 'shared-mime-info' is required by 'jpegxl-libs' > /usr/share/thumbnailers is a directory not owned yet > Done
(In reply to Robert-André Mauchin 🐧 from comment #8) > (In reply to Antonio T. sagitter from comment #7) > > Issues: > > ======= > > - Package installs properly. > > Note: Installation errors (see attachment) > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > > > Problem: conflicting requests > > - nothing provides libsjpeg.so.0.1()(64bit) needed by > > jpegxl-utils-0.3.7-1.fc35.x86_64 > > > > I have two solutions possible for this: build the binaries with static > libraries included in them or unbundle sjpeg and make it a separate package. > What do you think is the best option? I had already made a sjpeg package for > testing but I haven't submitted it yet for review. > > You're already compiling libsjpeg dynamic libraries, you may install them in a private lib directory of jpegxl-libs. Separating sjpeg as new package is another solution, sure, but in my opinion you should be sure that the 'sjpeg' code bundled is in truth constantly upgraded/modified for jpegxl's needs; latest 'sjpeg' code bundled is from a commit of 12h March 2019 (why?). I would ask to upstream. Fron sjpeg side, the code has been recently modified but never stable released. Is it ready for "living" alone? :)
(In reply to Antonio T. sagitter from comment #9) > (In reply to Robert-André Mauchin 🐧 from comment #8) > > (In reply to Antonio T. sagitter from comment #7) > > > Issues: > > > ======= > > > - Package installs properly. > > > Note: Installation errors (see attachment) > > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > > > > > Problem: conflicting requests > > > - nothing provides libsjpeg.so.0.1()(64bit) needed by > > > jpegxl-utils-0.3.7-1.fc35.x86_64 > > > > > > > I have two solutions possible for this: build the binaries with static > > libraries included in them or unbundle sjpeg and make it a separate package. > > What do you think is the best option? I had already made a sjpeg package for > > testing but I haven't submitted it yet for review. > > > > > > You're already compiling libsjpeg dynamic libraries, you may install them in > a private lib directory of jpegxl-libs. > I don't see this as a good option, because if someone else needs sjpeg, they won,t be able to package it or provide it along their package without conflict. > Separating sjpeg as new package is another solution, sure, but in my opinion > you should be sure that the 'sjpeg' code bundled is in truth constantly > upgraded/modified for jpegxl's needs; latest 'sjpeg' code bundled is from a > commit of 12h March 2019 (why?). I would ask to upstream. > Sjpeg is not linked to jpeg-xl, they're independently developed. I don,t expect breakage, considering the active developement of jpeg-xl, it would be fixed pretty quickly I believe. > Fron sjpeg side, the code has been recently modified but never stable > released. Is it ready for "living" alone? :) I think so.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2621440 bytes in 305 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation - '%{_datadir}/thumbnailers' is not owned - Bundled libraries have not version - + /usr/bin/ctest --output-on-failure --force-new-ctest-process -j8 Test project /builddir/build/BUILD/jpeg-xl-v0.3.7-9e9bce86164dc4d01c39eeeb3404d6aed85137b2/x86_64-redhat-linux-gnu No tests were found!!! ===== MUST items ===== C/C++: [x: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "zlib/libpng license BSD 3-clause "New" or "Revised" License", "Expat License Apache License 2.0", "zlib/libpng license Apache License 2.0", "zlib/libpng license", "BSD 3-clause "New" or "Revised" License". 170 files have unknown license. Detailed output of licensecheck in /home/sagitter/1922638-jpegxl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/thumbnailers [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jpegxl- utils , jpegxl-libs , jpegxl-devel , jxl-pixbuf-loader , gimp-jxl- plugin [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2744320 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jpegxl-utils-0.3.7-1.fc35.x86_64.rpm jpegxl-doc-0.3.7-1.fc35.noarch.rpm jpegxl-libs-0.3.7-1.fc35.x86_64.rpm jpegxl-devel-0.3.7-1.fc35.x86_64.rpm jxl-pixbuf-loader-0.3.7-1.fc35.x86_64.rpm gimp-jxl-plugin-0.3.7-1.fc35.x86_64.rpm jpegxl-debuginfo-0.3.7-1.fc35.x86_64.rpm jpegxl-debugsource-0.3.7-1.fc35.x86_64.rpm jpegxl-0.3.7-1.fc35.src.rpm jpegxl-libs.x86_64: W: no-documentation jxl-pixbuf-loader.x86_64: W: no-documentation gimp-jxl-plugin.x86_64: W: no-documentation jpegxl.src:58: W: unversioned-explicit-provides bundled(lodepng) jpegxl.src:60: W: unversioned-explicit-provides bundled(sjpeg) jpegxl.src:62: W: unversioned-explicit-provides bundled(skcms) jpegxl.src: W: invalid-url Source1: third_party-0.3.7.tar.gz 9 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: jpegxl-libs-debuginfo-0.3.7-1.fc35.x86_64.rpm jpegxl-utils-debuginfo-0.3.7-1.fc35.x86_64.rpm jpegxl-debuginfo-0.3.7-1.fc35.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- jpegxl-libs.x86_64: W: no-documentation gimp-jxl-plugin.x86_64: W: no-documentation jxl-pixbuf-loader.x86_64: W: no-documentation 10 packages and 0 specfiles checked; 0 errors, 3 warnings. Unversioned so-files -------------------- jxl-pixbuf-loader: /usr/lib64/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-jxl.so Source checksums ---------------- https://gitlab.com/wg1/jpeg-xl/-/archive/v0.3.7/jpeg-xl-0.3.7.tar.bz2 : CHECKSUM(SHA256) this package : ff16821452ecd9fa3bd13141d8883409390967b0445ee1eddb8831dfd41e6a5b CHECKSUM(SHA256) upstream package : ff16821452ecd9fa3bd13141d8883409390967b0445ee1eddb8831dfd41e6a5b Requires -------- jpegxl-utils (rpmlib, GLIBC filtered): libHalf-2_5.so.25()(64bit) libIlmImf-2_5.so.25()(64bit) libbrotlidec.so.1()(64bit) libbrotlienc.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgif.so.7()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) jpegxl-doc (rpmlib, GLIBC filtered): jpegxl-libs (rpmlib, GLIBC filtered): libbrotlidec.so.1()(64bit) libbrotlienc.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) shared-mime-info jpegxl-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config jpegxl-libs(x86-64) libjxl.so.0()(64bit) libjxl_threads.so.0()(64bit) pkgconfig(libbrotlicommon) pkgconfig(libbrotlidec) pkgconfig(libbrotlienc) jxl-pixbuf-loader (rpmlib, GLIBC filtered): gdk-pixbuf2 libbrotlidec.so.1()(64bit) libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) gimp-jxl-plugin (rpmlib, GLIBC filtered): gimp libbabl-0.1.so.0()(64bit) libbabl-0.1.so.0(V0_1_0)(64bit) libbrotlidec.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgegl-0.4.so.0()(64bit) libgimp-2.0.so.0()(64bit) libgimpcolor-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtcmalloc_minimal.so.4()(64bit) rtld(GNU_HASH) jpegxl-debuginfo (rpmlib, GLIBC filtered): jpegxl-debugsource (rpmlib, GLIBC filtered): Provides -------- jpegxl-utils: jpegxl-utils jpegxl-utils(x86-64) jpegxl-doc: jpegxl-doc jpegxl-libs: jpegxl-libs jpegxl-libs(x86-64) libjxl.so.0()(64bit) libjxl.so.0(JXL_0)(64bit) libjxl_threads.so.0()(64bit) jpegxl-devel: jpegxl-devel jpegxl-devel(x86-64) pkgconfig(libjxl) pkgconfig(libjxl_threads) jxl-pixbuf-loader: jxl-pixbuf-loader jxl-pixbuf-loader(x86-64) libpixbufloader-jxl.so()(64bit) gimp-jxl-plugin: gimp-jxl-plugin gimp-jxl-plugin(x86-64) jpegxl-debuginfo: jpegxl-debuginfo jpegxl-debuginfo(x86-64) jpegxl-debugsource: jpegxl-debugsource jpegxl-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --mock-options=--no-clean -m fedora-rawhide-x86_64 -b 1922638 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, SugarActivity, Perl, Haskell, PHP, R, Ocaml, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
-doc and -devel install the same documentation files: %files doc %doc doc/*.md %doc %{_vpath_builddir}/html <---- %license LICENSE %files libs %license LICENSE %{_libdir}/libjxl.so.0* %{_libdir}/libjxl_threads.so.0* %dir %{_datadir}/thumbnailers %{_datadir}/thumbnailers/jxl.thumbnailer %{_datadir}/mime/packages/image-jxl.xml %files devel %doc %{_vpath_builddir}/html <---- %doc CONTRIBUTING.md %{_includedir}/jxl/ %{_libdir}/libjxl.so %{_libdir}/libjxl_threads.so %{_libdir}/pkgconfig/libjxl.pc %{_libdir}/pkgconfig/libjxl_threads.pc
My bad, thanks for the review!
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jpegxl
FEDORA-2021-c67d9c9055 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-c67d9c9055
FEDORA-2021-7d201c8309 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7d201c8309
FEDORA-2021-7d201c8309 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-7d201c8309 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7d201c8309 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-c67d9c9055 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-c67d9c9055 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-c67d9c9055 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-7d201c8309 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-c67d9c9055 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.