Bug 1922774 - Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail
Summary: Review Request: perl-Test-DiagINC - List modules and versions loaded if tests...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1922738
TreeView+ depends on / blocked
 
Reported: 2021-01-31 14:40 UTC by Emmanuel Seyman
Modified: 2021-02-08 08:25 UTC (History)
2 users (show)

Fixed In Version: perl-Test-DiagINC-0.008-2.fc34
Clone Of:
Environment:
Last Closed: 2021-02-08 08:25:39 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2021-01-31 14:40:20 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC-0.008-1.fc33.src.rpm
Description:
Assuming you shipped your module to CPAN with working tests, test failures
from CPAN Testers might be due to platform issues, Perl version issues or
problems with dependencies. This module helps you diagnose deep dependency
problems by showing you exactly what modules and versions were loaded
during a test run.

Fedora Account System Username: eseyman
Rpmlint Output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2021-02-01 18:47:57 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add 'coreutils', it is needed for macro %{_fixperms}

$ rpm -qp --requires perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(:VERSION) >= 5.6.0
Binary requires 
FIX: Please add following run-requires, they are not found by generators:
     - perl(B)
     - perl(Cwd)
     - perl(File::Spec)
     - perl(strict)
     - perl(warnings)


$ rpm -qp --provides perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Test::DiagINC) = 0.008
      1 perl-Test-DiagINC = 0.008-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Test-DiagINC*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items. 

Resolution:
Approved

Comment 2 Emmanuel Seyman 2021-02-02 09:08:04 UTC
Thank you for the review, Jikta.

I've taken into account your feedback and updated the package:
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC-0.008-2.fc33.src.rpm

I've also requested the repository:
https://pagure.io/releng/fedora-scm-requests/issue/31990

Comment 3 Mohan Boddu 2021-02-02 20:59:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-DiagINC

Comment 4 Emmanuel Seyman 2021-02-08 08:25:39 UTC
Built and submitted to rawhide.


Note You need to log in before you can comment on or make changes to this bug.