Bug 1923250 - Request for Epel build
Summary: Request for Epel build
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: tldr
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lumír Balhar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-01 15:46 UTC by David Auer
Modified: 2021-02-05 01:48 UTC (History)
2 users (show)

Fixed In Version: tldr-1.2.0-1.el8
Clone Of:
Environment:
Last Closed: 2021-02-05 01:48:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description David Auer 2021-02-01 15:46:13 UTC
Would it be possible to build this package in Epel 8? I think it would be useful, for example on my CentOS 8 server.
I am a Fedora packager and I have experience with Python-packaging, let me know if I can help.

Tanks for considering!

Comment 1 Mikel Olasagasti Uranga 2021-02-02 10:07:41 UTC
tldr requires python-termcolor that is not available right now in epel8. I'm working to provide that missing dep and after I will build tldr for epel8.

Comment 2 Lumír Balhar 2021-02-02 11:29:55 UTC
Great!

Also, David, if you want to help us with the maintenance, feel free to say so and I'll make you a co-maintainer.

Comment 3 David Auer 2021-02-02 22:11:44 UTC
@Mikel: Great, thanks!

@Lumír: Yes, I'd like to help whenever I can!

Comment 4 Fedora Update System 2021-02-02 22:33:30 UTC
FEDORA-EPEL-2021-8f354c4b3d has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8f354c4b3d

Comment 5 Fedora Update System 2021-02-03 01:54:36 UTC
FEDORA-EPEL-2021-8f354c4b3d has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8f354c4b3d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Lumír Balhar 2021-02-03 03:29:41 UTC
Davide, you are a co-maintainer now, thank you!

Mikel, unfortunately, the update does not work because tldr needs also colorama which is not available in RHEL/EPEL. I have some good and some bad news. The good one is that colorama has no other dependencies so it should be easy to package for EPEL. The bad one is that python-colorama exists as a component in RHEL so AFAIK we cannot just create a new branch in python-colorama Fedora package and build it for EPEL. The way to go here, IMHO, is to create a new package python3-colorama and request only the epel8 branch for it.

What do you think about it?

Comment 7 Mikel Olasagasti Uranga 2021-02-03 08:33:11 UTC
Hi Lumir,

I'm confused. tldr install worked for me in a fresh CentOS8 with epel-release installed with this bodhi update (dnf install tldr -y --enablerepo=epel-testing && tldr ls).

I'm having issues with EPEL7 build, as the .spec required some changes, but once I modified the spec I broke the side-tag I was working on. The build was complaining only on python-termcolor missing in CentOS7/epel7 but https://src.fedoraproject.org/rpms/python-colorama is available. My plan was to continue with epel7 build today. I'll double check the colorama issue you mention.

Comment 8 Lumír Balhar 2021-02-03 08:57:21 UTC
I am gonna try it again now.

Comment 9 Lumír Balhar 2021-02-03 09:22:41 UTC
I am sorry, I had epel repo disabled accidentally. It works.

Comment 10 Mikel Olasagasti Uranga 2021-02-03 10:32:53 UTC
awesome!

I was able to fix the side-tag for epel7, but %pytest macro is not available for epel7 at the moment. I think it is due to missing python3-pytest-mock in epel7 , but there is an ongoing bodhi update https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-9e37bff701 for it, so I'll wait a few days and try again.

Comment 11 Lumír Balhar 2021-02-03 11:20:10 UTC
%pytest macro won't be in epel7 and it depends only on pytest. You can check what the macro does on: https://src.fedoraproject.org/rpms/python-rpm-macros/blob/master/f/macros.python3#_8

Why do you need pytest-mock for tldr?

Comment 12 Fedora Update System 2021-02-03 12:32:00 UTC
FEDORA-EPEL-2021-b9e7c225f8 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b9e7c225f8

Comment 13 Mikel Olasagasti Uranga 2021-02-03 12:33:19 UTC
I thought %pytest depended on pytest-mock, but you're right.

I changed the macro to use pytest-3 directly and it works fine. Also adapted in -3 another dep that needed a change (colorama).

With that I was able to build and test tldr also in EPEL7.

Comment 14 David Auer 2021-02-03 17:24:56 UTC
Wow that was fast, only two days later and I could install it from epel-testing. Works great of course, thanks Mikel!

I just noticed that tldr's bash-completion does not work for me, does it work for you? Should I create a new issue for this?

Comment 15 Mikel Olasagasti Uranga 2021-02-03 17:40:18 UTC
bash-completion works for me on a fresh CentOS8 after installing bash-completion and trying tldr[tab][tab] in a new shell or new login.

Comment 16 Fedora Update System 2021-02-04 02:06:32 UTC
FEDORA-EPEL-2021-b9e7c225f8 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-b9e7c225f8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 David Auer 2021-02-04 09:39:26 UTC
Wasn't aware that you need to manually install bash-completion, that works on CentOS, thanks! For my Fedora desktop I suspect that something somewhere is broken and I'll need to do a bit of debugging...

Comment 18 Fedora Update System 2021-02-05 01:48:31 UTC
FEDORA-EPEL-2021-8f354c4b3d has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.