workrave failed to build from source in Fedora rawhide/f34 https://koji.fedoraproject.org/koji/taskinfo?taskID=60910413 For details on the mass rebuild see: https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild Please fix workrave at your earliest convenience and set the bug's status to ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks, workrave will be orphaned. Before branching of Fedora 35, workrave will be retired, if it still fails to build. For more details on the FTBFS policy, please visit: https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Created attachment 1753316 [details] build.log
Created attachment 1753317 [details] root.log file root.log too big, will only attach last 32768 bytes
Created attachment 1753318 [details] state.log
Mukundan, can I ask you how should we modify this package to get it building again? It's currently failing due to the latest change in xfce4-panel (version 4.16 update): No matching package to install: 'pkgconfig(libxfce4panel-1.0) >= 4.4' I noticed this was renamed to pkgconfig(Libxfce4panel-1.0) but dnf is not resolving this: No matching package to install: 'pkgconfig(Libxfce4panel-1.0) >= 4.4' Any hint? Thanks!
Looking at the configure.ac file, workrave *should* build against libxfce4panel-2.0 configure.ac: PKG_CHECK_MODULES([LIBXFCE4PANEL], configure.ac: [libxfce4panel-2.0 >= 4.12], Patch would be something like this - diff --git a/workrave.spec b/workrave.spec index 677d4a4..b76d738 100644 --- a/workrave.spec +++ b/workrave.spec @@ -4,7 +4,7 @@ Name: workrave Version: 1.10.44 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Program that assists in the recovery and prevention of RSI # Based on older packages by Dag Wieers <dag> and Steve Ratcliffe License: GPLv3+ @@ -50,7 +50,7 @@ BuildRequires: pkgconfig(libpanel-applet) BuildRequires: pkgconfig(gtk+-2.0) >= 2.6.0 %endif %if 0%{?xfce} -BuildRequires: pkgconfig(Libxfce4panel-1.0) >= 4.4 +BuildRequires: pkgconfig(libxfce4panel-2.0) >= 4.4 %endif %if 0%{?mate} BuildRequires: pkgconfig(libmatepanelapplet-4.0) @@ -207,6 +207,9 @@ desktop-file-install \ %endif %changelog +* Mon Feb 08 2021 Mukundan Ragavan <nonamedotc> - 1.10.44-3 +- Build against libxfce4panel-2.0 + * Wed Jan 27 2021 Fedora Release Engineering <releng> - 1.10.44-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild --
This does not build. I am working on a patch.
please see here - https://src.fedoraproject.org/rpms/workrave/pull-request/2
Thank you so much for the patch, I don't do any desktop development I was just using this software some time ago. Tomas also no longer use it, a pair of extra hands would be really helpful if you would not mind joining us maintaining it.
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle. Changing version to 34.
(In reply to Lukas Zapletal from comment #8) > Thank you so much for the patch, I don't do any desktop development I was > just using this software some time ago. Tomas also no longer use it, a pair > of extra hands would be really helpful if you would not mind joining us > maintaining it. Sure. I can be a co-maintainer. Please add me. My FAS is nonamedotc.
Dear Maintainer, your package has an open Fails To Build From Source bug for Fedora 34. Action is required from you. If you can fix your package to build, perform a build in koji, and either create an update in bodhi, or close this bug without creating an update, if updating is not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to acknowledge this. If you have already fixed this issue, please close this Bugzilla report. Following the policy for such packages [2], your package will be orphaned if this bug remains in NEW state more than 8 weeks (not sooner than 2021-03-29). A week before the mass branching of Fedora 35 according to the schedule [3], any packages not successfully rebuilt at least on Fedora 33 will be retired regardless of the status of this bug. [1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/ [2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/ [3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html
I've run the builds on Fedora rawhide and 34 branches where the fix from Mukundan was merged and they passed.
Lukas, can you please add Mukundan as comaintainer?
Apologies for the delay, done. Thank you!