Spec URL: https://atim.fedorapeople.org/linux_thermaltake_riing.spec SRPM URL: https://atim.fedorapeople.org/linux_thermaltake_riing-0.2.0-1.fc33.src.rpm Description: Linux driver and daemon for Thermaltake Riing Currently supported devices are (as they show up in thermaltakes TTRGBPLUS software: - Flow Riing RGB - Lumi Plus LED Strip - Pacific PR22-D5 Plus - Pacific Rad Plus LED Panel - Pacific V-GTX 1080Ti Plus GPU Waterblock - Pacific W4 Plus CPU Waterblock - Riing Plus Fedora Account System Username: atim
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=61060199
- I think you should use linux-thermaltake-rgb instead, this would be in sync with Arch too. There is a policy about that actually: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_separators - Own %{_sysconfdir}/%{pypi_name}: %dir %{_sysconfdir}/%{pypi_name} Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later". 19 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/linux_thermaltake_riing/review- linux_thermaltake_riing/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/linux_thermaltake_rgb [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in linux_thermaltake_riing [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: linux_thermaltake_riing-0.2.0-1.fc35.noarch.rpm linux_thermaltake_riing-0.2.0-1.fc35.src.rpm linux_thermaltake_riing.noarch: W: spelling-error Summary(en_US) thermaltake -> thermal take, thermal-take, thermal linux_thermaltake_riing.noarch: W: spelling-error %description -l en_US thermaltakes -> thermal takes, thermal-takes, thermostats linux_thermaltake_riing.noarch: W: no-manual-page-for-binary linux-thermaltake-rgb linux_thermaltake_riing.src: W: spelling-error Summary(en_US) thermaltake -> thermal take, thermal-take, thermal linux_thermaltake_riing.src: W: spelling-error %description -l en_US thermaltakes -> thermal takes, thermal-takes, thermostats 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Hello @eclipseo. You right, thank you. Nice to see you. New spec and srpm: https://atim.fedorapeople.org/for-review/linux-thermaltake-rgb.spec https://atim.fedorapeople.org/for-review/linux-thermaltake-rgb-0.2.0-1.fc33.src.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/linux-thermaltake-rgb
FEDORA-2021-0b10017f62 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b10017f62
FEDORA-2021-3c41facd41 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3c41facd41
FEDORA-2021-0b10017f62 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-0b10017f62 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0b10017f62 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-3c41facd41 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-0b10017f62 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.