Description of problem:
https://github.com/openshift/machine-config-operator/pull/2314 introduced a regression which is not allowing values ending with % sign in the kubeletconfig
Validation if kubeletconfig fields is no longer going to be supported going forward, https://github.com/openshift/machine-config-operator/issues/2357
Hence, instead of fixing it for parsing for percentage (and other things), we will just revert that PR.
Hi, Harshal Patil
I'd like to confirm I get your point, we just need to validate positive percentage value is acceptable by kubeletconfig.
We will not support any validation in kubeletconfig (however I didn't remove the validation code that already exists). That's the reason I added a warning in CRD to let users know that validation will not be duplicated in MCO that already exists in upstream, https://github.com/openshift/machine-config-operator/pull/2358
@Harshal Patil， got you, yet I found the existing validation didn't work as expected.
At least, percentage value should be allowed, for our doc introduce we can use value with % in kubeletconfig, FYI:https://docs.openshift.com/container-platform/4.6/nodes/nodes/nodes-nodes-garbage-collection.html#nodes-nodes-garbage-collection-configuring_nodes-nodes-configuring
$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.7.0-0.nightly-2021-02-02-223803 True False 4h33m Cluster version is 4.7.0-0.nightly-2021-02-02-223803
- lastTransitionTime: "2021-02-03T10:31:56Z"
message: 'Error: KubeletConfiguration: invalid value specified for nodefs.available
reservation in evictionSoft, 6%'
verified on version : 4.7.0-0.nightly-2021-02-06-084550
- lastTransitionTime: "2021-02-07T07:15:17Z"
So the previous fixes which are related with kubeletconfig field validation are deprecated, such as https://bugzilla.redhat.com/show_bug.cgi?id=1745919 and https://bugzilla.redhat.com/show_bug.cgi?id=1805019
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.