Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen.spec SRPM URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen-2021.02.01.00-1.fc34.src.rpm Description: Proxygen comprises the core C++ HTTP abstractions used at Facebook. Internally, it is used as the basis for building many HTTP servers, proxies, and clients. This release focuses on the common HTTP abstractions and our simple HTTPServer framework. Future releases will provide simple client APIs as well. The framework supports HTTP/1.1, SPDY/3, SPDY/3.1, HTTP/2, and HTTP/3. The goal is to provide a simple, performant, and modern C++ HTTP library. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=61158836
Trying to install the RPMs from Koji fail: - nothing provides libproxygencurl.so()(64bit) needed by proxygen-2021.02.01.00-1.fc34.x86_64 Looks like a library does not get installed? It's happened on a previous package since the shared lib targets were not well tested.
Spec URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen.spec SRPM URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen-2021.02.01.00-2.fc34.src.rpm Changelog: - Backport upstream fix to install the proxygencurl library
Two minor issues, after which I can approve: - -docs subpackage should be marked noarch - put the -static CMake files into %{_libdir}/cmake/%{name}-static, not %{_libdir}/cmake-static/%{name} since nobody owns %{_libdir}/cmake-static Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112855040 bytes in 4590 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "Expat License", "Apache License 2.0", "GNU General Public License, Version 2". 723 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1924343-proxygen/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake-static [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake-static [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: proxygen-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in proxygen-devel , proxygen-docs , proxygen-libs , proxygen-static [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 116674560 bytes in /usr/share proxygen-docs-2021.02.01.00-2.fc34.x86_64.rpm:116592640 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: proxygen-2021.02.01.00-2.fc34.x86_64.rpm proxygen-devel-2021.02.01.00-2.fc34.x86_64.rpm proxygen-docs-2021.02.01.00-2.fc34.x86_64.rpm proxygen-libs-2021.02.01.00-2.fc34.x86_64.rpm proxygen-static-2021.02.01.00-2.fc34.x86_64.rpm proxygen-debuginfo-2021.02.01.00-2.fc34.x86_64.rpm proxygen-debugsource-2021.02.01.00-2.fc34.x86_64.rpm proxygen-2021.02.01.00-2.fc34.src.rpm proxygen.x86_64: W: summary-ended-with-dot C A collection of C++ HTTP libraries including an easy to use HTTP server. proxygen.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance proxygen.x86_64: W: no-documentation proxygen.x86_64: W: no-manual-page-for-binary proxygen_curl proxygen.x86_64: W: no-manual-page-for-binary proxygen_echo proxygen.x86_64: W: no-manual-page-for-binary proxygen_proxy proxygen.x86_64: W: no-manual-page-for-binary proxygen_push proxygen.x86_64: W: no-manual-page-for-binary proxygen_static proxygen-libs.x86_64: W: no-documentation proxygen-static.x86_64: W: no-documentation proxygen.src: W: summary-ended-with-dot C A collection of C++ HTTP libraries including an easy to use HTTP server. proxygen.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance 8 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: proxygen-debuginfo-2021.02.01.00-2.fc34.x86_64.rpm proxygen-libs-debuginfo-2021.02.01.00-2.fc34.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- proxygen-libs.x86_64: W: no-documentation proxygen-static.x86_64: W: no-documentation proxygen.x86_64: W: summary-ended-with-dot C A collection of C++ HTTP libraries including an easy to use HTTP server. proxygen.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance proxygen.x86_64: W: no-documentation proxygen.x86_64: W: no-manual-page-for-binary proxygen_curl proxygen.x86_64: W: no-manual-page-for-binary proxygen_echo proxygen.x86_64: W: no-manual-page-for-binary proxygen_proxy proxygen.x86_64: W: no-manual-page-for-binary proxygen_push proxygen.x86_64: W: no-manual-page-for-binary proxygen_static 8 packages and 0 specfiles checked; 0 errors, 10 warnings. Source checksums ---------------- https://github.com/facebook/proxygen/releases/download/v2021.02.01.00/proxygen-v2021.02.01.00.tar.gz : CHECKSUM(SHA256) this package : ce551a42a8824923d013bd21f62c61ad4d2c558daaf1347be1593b11b0e7934c CHECKSUM(SHA256) upstream package : ce551a42a8824923d013bd21f62c61ad4d2c558daaf1347be1593b11b0e7934c Requires -------- proxygen (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfolly.so.2021.02.01.00()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgflags.so.2.2()(64bit) libglog.so.0()(64bit) libproxygen.so.2021.02.01.00()(64bit) libproxygencurl.so.2021.02.01.00()(64bit) libproxygenhttpserver.so.2021.02.01.00()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwangle.so.2021.02.01.00()(64bit) rtld(GNU_HASH) proxygen-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) libproxygen.so.2021.02.01.00()(64bit) libproxygencurl.so.2021.02.01.00()(64bit) libproxygenhttpserver.so.2021.02.01.00()(64bit) proxygen-libs(x86-64) proxygen-docs (rpmlib, GLIBC filtered): proxygen-libs (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libdouble-conversion.so.3()(64bit) libfizz.so.2021.02.01.00()(64bit) libfolly.so.2021.02.01.00()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgflags.so.2.2()(64bit) libglog.so.0()(64bit) libm.so.6()(64bit) libproxygen.so.2021.02.01.00()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwangle.so.2021.02.01.00()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) libzstd.so.1()(64bit) rtld(GNU_HASH) proxygen-static (rpmlib, GLIBC filtered): proxygen-devel(x86-64) proxygen-debuginfo (rpmlib, GLIBC filtered): proxygen-debugsource (rpmlib, GLIBC filtered): Provides -------- proxygen: proxygen proxygen(x86-64) proxygen-devel: cmake(proxygen) proxygen-devel proxygen-devel(x86-64) proxygen-docs: proxygen-docs proxygen-docs(x86-64) proxygen-libs: libproxygen.so.2021.02.01.00()(64bit) libproxygencurl.so.2021.02.01.00()(64bit) libproxygenhttpserver.so.2021.02.01.00()(64bit) proxygen-libs proxygen-libs(x86-64) proxygen-static: proxygen-static proxygen-static(x86-64) proxygen-debuginfo: debuginfo(build-id) proxygen-debuginfo proxygen-debuginfo(x86-64) proxygen-debugsource: proxygen-debugsource proxygen-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1924343 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Java, SugarActivity, Haskell, R, Python, Perl, PHP, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen.spec SRPM URL: https://dcavalca.fedorapeople.org/review/proxygen/proxygen-2021.02.01.00-3.fc34.src.rpm Changelog: - Make proxygen-docs noarch - Fix cmake install dir for static build
Looks good, APPROVED!
Thanks! $ fedpkg request-repo proxygen 1924343 https://pagure.io/releng/fedora-scm-requests/issue/32037
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/proxygen
FEDORA-2021-aa73eeee2c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-aa73eeee2c
FEDORA-2021-7cce18d674 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cce18d674
FEDORA-2021-aa73eeee2c has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-aa73eeee2c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-aa73eeee2c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-7cce18d674 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-7cce18d674 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7cce18d674 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-aa73eeee2c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-7cce18d674 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.