Bug 1924729 - Create Storageclass for CephFS provisioner assumes incorrect default FSName in external mode (side-effect of fix for Bug 1878086)
Summary: Create Storageclass for CephFS provisioner assumes incorrect default FSName i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Storage Plugin
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.8.0
Assignee: Sanjal Katiyar
QA Contact: Sidhant Agrawal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-03 14:23 UTC by Neha Berry
Modified: 2021-07-27 22:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 22:40:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screencast of the flow depicting the issue (1.12 MB, video/webm)
2021-02-03 14:23 UTC, Neha Berry
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8825 0 None open Bug 1924729: Create Storageclass for CephFS provisioner assumes incorrect default FSName in external mode 2021-04-29 13:02:40 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:41:21 UTC

Description Neha Berry 2021-02-03 14:23:52 UTC
Created attachment 1754764 [details]
screencast of the flow depicting the issue

Description of problem:
=================================
Some background:
---------------------
With the fix for Bug 1878086, the text field to enter a "Filesystem Name" was removed from Create Storage Class -> page with "provisioner: openshift-storage.cephfs.csi.ceph.com". The code assumes the default Fsname as "ocs-storagecluster-cephfilesystem"

Though this fix is good for Internal mode, but for external mode, there is no default FSName.  For the default SC name: ocs-external-storagecluster-cephfs:

the fsName amd pool name is taken from the uploaded JSON during deployment

e.g.
 fsName: cephfs
    pool: cephfs_data


Hence, in external mode, when I tried to create a custom SC with CephFS provisioner, instead of using fsName as above(uploaded via JSON), the SC assumes the fsName as following:

    name: test-cephfs-new
    
  parameters:
  
    fsName: ocs-storagecluster-cephfilesystem
  provisioner: openshift-storage.cephfs.csi.ceph.com


This led any PVC to be created with this SC to be stuck in Pending state.

Version-Release number of selected component (if applicable):
=================================================================
OCS = 4.7.0-241.ci
OCP  = 4.7.0-0.nightly-2021-02-01-060607

How reproducible:
=======================
Always



Steps to Reproduce:
=======================
1. Create an external mode cluster in OCS 4.7
2. Check the fsName and pool info in the default Storage class "name: ocs-external-storagecluster-cephfs". The name matches with what is uploaded via JSON
3. Create a new Custom Storageclass with Provisioner for cephFS. 
4. check the yaml of the new SC. It uses fsName as ocs-storagecluster-cephfilesystem, which does not exist in External mode
5. create PVC using new SC, it stays in Pending state



Actual results:
===================
New SC created with incorrect fsName: ocs-storagecluster-cephfilesystem, hence new PVCs using this SC get stuck in pending state

Expected results:
=======================
In external mode, we cannot assume the default fsName as "ocs-storagecluster-cephfilesystem" since the name comes from uploaded JSON from external RHCS and can vary

Additional info:
=========================
For RBD, we get following:

Internal Mode:  a drop down to select/create new pool 
External : a text box to add a pool Name

We might need something similar to this for CephFS provisioner in external mode too

Comment 3 Nishanth Thomas 2021-02-13 09:31:16 UTC
Setting target release to the active development branch (4.8.0). For any fixes, where required , cloned BZs will be created for those release maintenance streams.

Comment 8 errata-xmlrpc 2021-07-27 22:40:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.