Description of problem: After upgrade, older, deprecated templates may exist. "template.kubevirt.io/deprecated" annotation should be added to these templates (completion to bug 1924583 and bug 1859235) Version-Release number of selected component (if applicable): CNV 2.5.3->2.6.0 How reproducible: 100% Steps to Reproduce: 1. Upgrade from CNV 2.5.z - > 2.6.0 Actual results: Some templates are deprecated. While the os-flavor-workload labels are removed, "template.kubevirt.io/deprecated" annotation should be added as well. Expected results: Additional info:
Tested with SSP operator v2.6.1-5. Annotation is not added to templates after upgrade, for example fedora-highperformance-medium-v0.11.3: annotations: defaults.template.kubevirt.io/disk: rootdisk description: |- Template for Fedora 31 VM or newer. A PVC with the Fedora disk image must be available. Recommended disk image: https://download.fedoraproject.org/pub/fedora/linux/releases/32/Cloud/x86_64/images/Fedora-Cloud-Base-32-1.6.x86_64.qcow2 iconClass: icon-fedora name.os.template.kubevirt.io/fedora31: Fedora 31 or higher name.os.template.kubevirt.io/fedora32: Fedora 31 or higher name.os.template.kubevirt.io/silverblue31: Fedora 31 or higher name.os.template.kubevirt.io/silverblue32: Fedora 31 or higher openshift.io/display-name: Fedora 31+ VM openshift.io/documentation-url: https://github.com/kubevirt/common-templates openshift.io/provider-display-name: KubeVirt openshift.io/support-url: https://github.com/kubevirt/common-templates/issues operator-sdk/primary-resource: openshift-cnv/ssp-kubevirt-hyperconverged operator-sdk/primary-resource-type: SSP.ssp.kubevirt.io tags: hidden,kubevirt,virtualmachine,fedora template.kubevirt.io/editable: | /objects[0].spec.template.spec.domain.cpu.sockets /objects[0].spec.template.spec.domain.cpu.cores /objects[0].spec.template.spec.domain.cpu.threads /objects[0].spec.template.spec.domain.resources.requests.memory /objects[0].spec.template.spec.domain.devices.disks /objects[0].spec.template.spec.volumes /objects[0].spec.template.spec.networks template.kubevirt.io/version: v1alpha1 template.openshift.io/bindable: "false" validations: | [ { "name": "minimal-required-memory", "path": "jsonpath::.spec.domain.resources.requests.memory", "rule": "integer", "message": "This VM requires more memory.", "min": 1073741824 } ]
We are moving this out to 2.6.2 as it's not urgent eoungh
@ksimon I remember the PR was backported last week, can't this be moved to ON_QA?
The PR got merged, moving to MODIFIED
Verified with SSP v2.6.2-2. Upgraded from 2.5.5 -> 2.6.0 - > 2.6.1 - > 2.6.2 Old templates have template.kubevirt.io/deprecated: "true" New templates do not have the label. The UI displays only active templates.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Virtualization 2.6.2 Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:1502