Description of problem: It does not make sense to take a snapshow when no disks support snapshot, either disable save or give warning when no disks support snapshot in the modal. Version-Release number of selected component (if applicable): OCP 4.7 How reproducible: Steps to Reproduce: 1. create a VM which has no disks support snapshot 2. go to snapshot and try to take snapshot 3. Actual results: It's able to take snapshot even though no disk support snapshot. Expected results: either disable save or give warning when no disks support snapshot in the modal. Additional info:
Matt, I can think of two options off the top of my head, but would like to get you or your team's input. Option one is to disable the Save button and provide a single warning explaining that there are no volumes from which to create a snapshot and why that's the case. Option two is to disable the "Take Snapshot" button and add a popover with the warning.
I like the first option - it allows more clear direction for fixing the issue. What is the solution for this? Is it possible for them to take a snapshot if they change the disk?
Created attachment 1784068 [details] Snapshot modal Snapshot modal with warnings.
Option one it is, then. The solution is to add a disk with a snapshot-supported storage class or add a snapshot-supported storage class to an existing disk. The modal already has a number of potential alerts (see the attachment I uploaded), including an info alert at the top of the modal explaining this and a warning alert that lists all disks that won't be included. This is why I suggested replacing all of them with a single alert that explains the problem. Perhaps something like this for the alert copy: "No disks found to include in the snapshot (alert header) Only disks with a snapshot-supported storage class defined are included in snapshots. No such disks were found. Add a snapshot-supported storage class to an existing disk, add a new disk with a compatible storage class defined, or contact your cluster admin for further details. Learn more about snapshots (external link)"
I think that solution could work well. I'd like to get Yifat's opinion on it before it get's merged though if possible.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438