Bug 1926289 - Accessibility: Modal content hidden from screen readers
Summary: Accessibility: Modal content hidden from screen readers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.8.0
Assignee: Sahil Budhwar
QA Contact: spathak@redhat.com
URL:
Whiteboard: Accessibility
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-08 15:20 UTC by Samuel Padgett
Modified: 2021-07-27 22:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Version: 4.7.0-0.nightly-2021-02-04-031352 Cluster ID: 7d1329d3-b07b-40d9-807c-068ee8cdca23 Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:85.0) Gecko/20100101 Firefox/85.0
Last Closed: 2021-07-27 22:42:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 8617 0 None open Bug 1926289: create app-content div with modal-container as sibling 2021-04-12 12:14:54 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 22:42:59 UTC

Description Samuel Padgett 2021-02-08 15:20:31 UTC
The following PR introduced an accessibility regression:

https://github.com/openshift/console/pull/6522

Moving the modal conatiner inside the app div causes the modal content to be hidden from screen readers. This is because aria-hidden is added to the app div when a modal is display, but this now includes the modal itself. Previously they were sibling elements.

It also appears to have caused the following warning in the JavaScript console.

Warning: unmountComponentAtNode(): The node you're attempting to unmount was rendered by another copy of React.

We should leave the modal container and app element as siblings in the DOM and find another way to address the original problem (bug 1875494) being fixed.

Comment 2 Jakub Hadvig 2021-02-08 15:59:53 UTC
Assigning to DevCosole team sice they introduced the issue in https://github.com/openshift/console/pull/6522

Comment 7 spathak@redhat.com 2021-05-20 12:40:47 UTC
I've used ChromeVox to verify screen reading. I've tested different sections of the page with the plugin in Chrome 89
I've tested the quick-start side drawer with the catalog sidebar, it is working fine.
Verified on build version: 4.8.0-0.nightly-2021-05-09-105430

Comment 10 errata-xmlrpc 2021-07-27 22:42:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438


Note You need to log in before you can comment on or make changes to this bug.