Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1926513

Summary: OSP13z14 regression on qdr puppet template breaks STF 1.1
Product: Red Hat OpenStack Reporter: Vincent S. Cojot <vcojot>
Component: puppet-qdrAssignee: Leif Madsen <lmadsen>
Status: CLOSED ERRATA QA Contact: Leonid Natapov <lnatapov>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 13.0 (Queens)CC: ahyder, jbadiapa, lmadsen, mrunge, spower
Target Milestone: z15Keywords: Reopened, Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-qdr-2.3.1-3.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-18 13:10:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vincent S. Cojot 2021-02-08 22:15:41 UTC
Description of problem:

Fresh deploy with STF 1.1:


[root@krynn-osp13-ctrl-0 ~]# docker exec -ti metrics_qdr  bash
()[qdrouterd@krynn-osp13-ctrl-0 /]$ qdstat -b 10.0.0.196 -c
ConnectionException: Connection amqp://10.0.0.196:amqp/$management disconnected: Condition('amqp:connection:framing-error', "Expected AMQP protocol header got: Unknown protocol ['AMQP\\x00\\x00\\x09\\x01']")


On the undercloud (OSP13z14), we noticed this:

[root@osp13d ~]# head -50 /etc/puppet/modules/qdr/templates/qdrouterd.conf.erb
[...]
<%- @ssl_profiles.each do |profile| -%>
sslProfile{  <===============================================================
<%- profile.each do |k,v| -%>
    <%= k %>: <%= v %>
<%- end -%>
}

It should be 'sslProfile {', not just 'sslProfile{'

Comment 4 Leif Madsen 2021-02-08 23:41:10 UTC
Vincent has tested the fix via local patching on his RHOSP13z14 deployment and verified the fix results in a connection to the remote STF instance now.

Comment 5 Vincent S. Cojot 2021-02-08 23:53:02 UTC
@leif Confirmed on OSP13z14 + STF 1.1, the single char change in the linked gerrit makes it work again:

[root@osp13d qdr]# diff -u /usr/share/openstack-puppet/modules/qdr/templates/qdrouterd.conf.erb.orig /usr/share/openstack-puppet/modules/qdr/templates/qdrouterd.conf.erb
--- /usr/share/openstack-puppet/modules/qdr/templates/qdrouterd.conf.erb.orig   2021-02-08 18:49:05.654777565 -0500
+++ /usr/share/openstack-puppet/modules/qdr/templates/qdrouterd.conf.erb        2021-02-08 17:17:40.094771955 -0500
@@ -39,7 +39,7 @@
 <%- end -%>
 
 <%- @ssl_profiles.each do |profile| -%>
-sslProfile{
+sslProfile {
 <%- profile.each do |k,v| -%>
     <%= k %>: <%= v %>
 <%- end -%>

After a fresh deploy:

[root@krynn-osp13-ctrl-0 ~]# docker exec -it metrics_qdr qdstat --bus=10.0.0.73:5666 --connections
2021-02-08 23:52:37.673994 UTC
Router.krynn-osp13-ctrl-0.lasthome.solace.krynn

Connections
  id   host             container                                                                                                                              role    dir  security     authentication  tenant  last dlv      uptime
  ===========================================================================================================================================================================================================================================
  290  10.0.0.73:58338  openstack.org/om/container/krynn-osp13-ctrl-0.lasthome.solace.krynn/ceilometer-agent-notification/28/e7bb0188eb494443aa5f7198c1042c1a  normal  in   no-security  no-auth                 -             000:00:24:14
  323  10.0.0.73:33980  metrics                                                                                                                                normal  in   no-security  anonymous-user          000:00:00:03  000:00:21:32
  581  10.0.0.73:36092  bdc4c3f4-9e9f-4654-bc60-a4b2ef25110d                                                                                                   normal  in   no-security  no-auth                 000:00:00:00  000:00:00:00

Comment 7 spower 2021-02-09 14:12:37 UTC
given exception + flag

Comment 14 Leonid Natapov 2021-03-03 10:06:05 UTC
It seems that problem is that port was not specified after IP address in the qdstat command.
When specifying port it works fine without no space between sslProfile and {
------
}


sslProfile{
    name: sslProfile
}
-------

()[root@controller-1 qpid-dispatch]# qdstat -b 172.17.1.148 -c
ConnectionException: Connection amqp://172.17.1.148:amqp/$management disconnected: Condition('amqp:connection:framing-error', "Expected AMQP protocol header got: Unknown protocol ['AMQP\\x00\\x00\\x09\\x01']")

()[root@controller-1 qpid-dispatch]# qdstat -b 172.17.1.148:5666 -c
2021-03-03 09:49:06.003431 UTC
Router.controller-1.redhat.local

Connections
  id  host                container                             role    dir  security     authentication  tenant  last dlv      uptime
  ============================================================================================================================================
  2   172.17.1.148:46138  metrics                               normal  in   no-security  anonymous-user          000:00:00:03  000:00:00:33
  9   172.17.1.148:48016  44195f0d-7da2-49d4-b3a8-41348861113b  normal  in   no-security  no-auth                 000:00:00:00  000:00:00:00

Closing as not a bug.

Comment 15 Leonid Natapov 2021-03-03 12:26:44 UTC
moving it back to ON_QA

Comment 19 errata-xmlrpc 2021-03-18 13:10:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13.0 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0932