Spec URL: https://download.copr.fedorainfracloud.org/results/jstanek/newsboat-dependencies/fedora-rawhide-x86_64/01956484-rust-scratch/rust-scratch.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jstanek/newsboat-dependencies/fedora-rawhide-x86_64/01956484-rust-scratch/rust-scratch-1.0.0-2.fc34.src.rpm Description: Compile-time temporary directory shared by multiple crates and erased by `cargo clean`. Fedora Account System Username: jstanek This is one of the new (transitive) dependencies for newsboat (https://src.fedoraproject.org/rpms/newsboat). The packaged version might not be the latest available – only the latest one to satisfy newsboat dependency constraints.
I will take this review. Can you take bug 1927443 in exchange? It's yet another OCaml package, and depends on the previous two I asked you to review.
This package is APPROVED, but please consider supplying a shorter Summary line as noted below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - Note the "summary too long" warning from rpmlint. Perhaps the final clause could be omitted? Summary: Compile-time temporary directory shared by multiple crates or even: Summary: Shared compile-time temporary directory ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-scratch-devel-1.0.0-2.fc35.noarch.rpm rust-scratch+default-devel-1.0.0-2.fc35.noarch.rpm rust-scratch-1.0.0-2.fc35.src.rpm rust-scratch-devel.noarch: E: summary-too-long C Compile-time temporary directory shared by multiple crates and erased by `cargo clean` rust-scratch-devel.noarch: W: invalid-url URL: https://crates.io/crates/scratch HTTP Error 404: Not Found rust-scratch-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/scratch-1.0.0/.cargo-checksum.json rust-scratch+default-devel.noarch: E: summary-too-long C Compile-time temporary directory shared by multiple crates and erased by `cargo clean` rust-scratch+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/scratch HTTP Error 404: Not Found rust-scratch+default-devel.noarch: W: no-documentation rust-scratch.src: E: summary-too-long C Compile-time temporary directory shared by multiple crates and erased by `cargo clean` rust-scratch.src: W: invalid-url URL: https://crates.io/crates/scratch HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 3 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- rust-scratch-devel.noarch: E: summary-too-long C Compile-time temporary directory shared by multiple crates and erased by `cargo clean` rust-scratch-devel.noarch: W: invalid-url URL: https://crates.io/crates/scratch HTTP Error 404: Not Found rust-scratch-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/scratch-1.0.0/.cargo-checksum.json rust-scratch+default-devel.noarch: E: summary-too-long C Compile-time temporary directory shared by multiple crates and erased by `cargo clean` rust-scratch+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/scratch HTTP Error 404: Not Found rust-scratch+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 2 errors, 4 warnings. Source checksums ---------------- https://crates.io/api/v1/crates/scratch/1.0.0/download#/scratch-1.0.0.crate : CHECKSUM(SHA256) this package : 7e114536316b51a5aa7a0e59fc49661fd263c5507dd08bd28de052e57626ce69 CHECKSUM(SHA256) upstream package : 7e114536316b51a5aa7a0e59fc49661fd263c5507dd08bd28de052e57626ce69 Requires -------- rust-scratch-devel (rpmlib, GLIBC filtered): cargo rust-scratch+default-devel (rpmlib, GLIBC filtered): cargo crate(scratch) Provides -------- rust-scratch-devel: crate(scratch) rust-scratch-devel rust-scratch+default-devel: crate(scratch/default) rust-scratch+default-devel Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1927248 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, Ocaml, PHP, Perl, R, fonts, Haskell, Java, Ruby, C/C++, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
The summary was shortened. Including the new URLs here, so that the import automation picks the fixed ones: Spec URL: https://download.copr.fedorainfracloud.org/results/jstanek/newsboat-dependencies/fedora-rawhide-x86_64/01966573-rust-scratch/rust-scratch.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jstanek/newsboat-dependencies/fedora-rawhide-x86_64/01966573-rust-scratch/rust-scratch-1.0.0-3.fc35.src.rpm
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-scratch
Package built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2021-aee82c2927