Bug 1927439 - flatpak: glib2 vs extern "C"
Summary: flatpak: glib2 vs extern "C"
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: flatpak
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F34BetaBlocker F34BetaFreezeException
TreeView+ depends on / blocked
 
Reported: 2021-02-10 18:00 UTC by Rex Dieter
Modified: 2021-02-15 11:48 UTC (History)
4 users (show)

Fixed In Version: flatpak-1.10.1-3.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-12 20:07:09 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github flatpak flatpak issues 4117 0 None open #include <flatpak.h> unsafe for C++ code 2021-02-11 21:51:40 UTC

Description Rex Dieter 2021-02-10 18:00:53 UTC
Related to recent glib2 change, see also bug #1926239

plasma-discover is a C++ application that tries to 
#include <flatpak.h>

but caught in a catch-22 , where
extern "C" {
#include <flatpak.h>
}

now yields compiler errors, and removing the extern yields linker errors like:
/usr/bin/ld: <artificial>:(.text+0x2cc4): undefined reference to `flatpak_ref_get_type()'

I suspect flatpak.h (and friends) may need adjustments to use G_BEGIN_DECLS (just a guess)

Comment 1 Fedora Blocker Bugs Application 2021-02-11 17:18:20 UTC
Proposed as a Blocker and Freeze Exception for 34-beta by Fedora user rdieter using the blocker tracking app because:

 This causes several important plasma components (plasma-discover in particular) to FTBFS.

Comment 2 Adam Williamson 2021-02-11 18:25:55 UTC
FTBFS isn't *necessarily* release blocking unless we actually need to build that thing to fix a blocker/FE bug.

Comment 3 Rex Dieter 2021-02-11 19:37:42 UTC
discover got a good number of recent fixes we'd would like to be testable in the beta (offline update testing could be affected).

Comment 4 Rex Dieter 2021-02-11 19:46:21 UTC
ok, maybe f34-beta FE only, can defer to a F34 GA blocker (we can't ship GA as-is)

Comment 5 Adam Williamson 2021-02-12 00:07:36 UTC
OK. Beta freeze is not till Feb 23, I'll note. If this isn't fixed by then, what I'd say is propose an FE for *the things you would like to change*, and if that gets accepted as an FE then fixing the FTBFS would also clearly be in scope.

Comment 6 Kalev Lember 2021-02-12 15:03:34 UTC
Upstream PR: https://github.com/flatpak/flatpak/pull/4119

I'll go and do downstream builds with this in a bit.

Comment 7 Kalev Lember 2021-02-12 20:07:09 UTC
Should be fixed in flatpak-1.10.1-3.fc34, can you give it a try, please?

Comment 8 Rex Dieter 2021-02-13 21:44:29 UTC
Confirmed good, thank you.

Comment 9 Kalev Lember 2021-02-15 11:48:40 UTC
Great! Thanks for verifying.


Note You need to log in before you can comment on or make changes to this bug.