Bug 1927927 - Review Request: git-remote-codecommit - Git remote helper for AWS CodeCommit
Summary: Review Request: git-remote-codecommit - Git remote helper for AWS CodeCommit
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2021-02-11 20:44 UTC by iliana etaoin
Modified: 2023-04-16 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-04-16 00:45:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description iliana etaoin 2021-02-11 20:44:02 UTC
Spec URL: https://ilianaw.fedorapeople.org/specs/git-remote-codecommit/1.15.1-1/git-remote-codecommit.spec
SRPM URL: https://ilianaw.fedorapeople.org/specs/git-remote-codecommit/1.15.1-1/git-remote-codecommit-1.15.1-1.fc33.src.rpm
Description:
The AWS CodeCommit remote helper provides the codecommit:// protocol handler
for Git and sources credentials from the profile information configured for the
AWS CLI.

Fedora Account System Username: ilianaw

Comment 1 iliana etaoin 2021-02-11 20:44:59 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=61786204

Comment 2 Neal Gompa 2021-02-12 13:19:05 UTC
Taking this review.

Comment 3 Neal Gompa 2021-02-12 13:25:03 UTC
Initial review notes:

> Source0:        https://github.com/aws/git-remote-codecommit/archive/%{version}/%{name}-%{version}.tar.gz

Nit: you can simplify this by doing "Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz"

> rm -rf %{buildroot}

This is unnecessary and should be removed.

> %{__python3} -m pytest

Please change %__python3 to %python3.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros

Comment 4 Package Review 2022-02-13 00:45:19 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 5 Package Review 2022-03-15 00:45:22 UTC
This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 6 Package Review 2023-03-16 00:45:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2023-04-16 00:45:21 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.