Bug 1928566 - CET support was removed from libcap-2.48-1.fc33
Summary: CET support was removed from libcap-2.48-1.fc33
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libcap
Version: 33
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-14 21:37 UTC by H.J. Lu
Modified: 2021-02-18 01:24 UTC (History)
4 users (show)

Fixed In Version: libcap-2.48-2.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-18 01:24:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
A patch (1.15 KB, patch)
2021-02-14 22:17 UTC, H.J. Lu
no flags Details | Diff

Description H.J. Lu 2021-02-14 21:37:25 UTC
[root@gnu-tgl-2 hjl]# rpm -qfi /lib64/libcap.so.2
Name        : libcap
Version     : 2.48
Release     : 1.fc33
Architecture: x86_64
Install Date: Fri 12 Feb 2021 09:18:06 AM PST
Group       : Unspecified
Size        : 180759
License     : BSD or GPLv2
Signature   : RSA/SHA256, Wed 10 Feb 2021 09:05:53 AM PST, Key ID 49fd77499570ff31
Source RPM  : libcap-2.48-1.fc33.src.rpm
Build Date  : Wed 10 Feb 2021 08:07:09 AM PST
Build Host  : buildvm-x86-11.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://sites.google.com/site/fullycapable/
Bug URL     : https://bugz.fedoraproject.org/libcap
Summary     : Library for getting and setting POSIX.1e capabilities
Description :
libcap is a library for getting and setting POSIX.1e (formerly POSIX 6)
draft 15 capabilities.
[root@gnu-tgl-2 hjl]# readelf -n /lib64/libcap.so.2 | head -10

Displaying notes found in: .note.gnu.build-id
  Owner                Data size Description
  GNU                  0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring)
    Build ID: 268cd3c845a4c87d2e7ee335a5c06e8793d53fad

Displaying notes found in: .gnu.build.attributes
  Owner                Data size Description
  GA$<version>3a1      0x00000010 OPEN
    Applies to region from 0x2000 to 0x52e5
[root@gnu-tgl-2 hjl]#

[hjl@gnu-mic-2 result]$ rpm -qfi /lib64/libcap.so.2
Name        : libcap
Version     : 2.26
Release     : 8.fc33
Architecture: x86_64
Install Date: Thu 29 Oct 2020 12:05:33 PM PDT
Group       : Unspecified
Size        : 146922
License     : GPLv2
Signature   : RSA/SHA256, Wed 29 Jul 2020 04:14:41 AM PDT, Key ID 49fd77499570ff31
Source RPM  : libcap-2.26-8.fc33.src.rpm
Build Date  : Tue 28 Jul 2020 03:35:32 PM PDT
Build Host  : buildhw-x86-16.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://sites.google.com/site/fullycapable/
Bug URL     : https://bugz.fedoraproject.org/libcap
Summary     : Library for getting and setting POSIX.1e capabilities
Description :
libcap is a library for getting and setting POSIX.1e (formerly POSIX 6)
draft 15 capabilities.
[hjl@gnu-mic-2 result]$ readelf -n /lib64/libcap.so.2 | head -10

Displaying notes found in: .note.gnu.property
  Owner                Data size 	Description
  GNU                  0x00000020	NT_GNU_PROPERTY_TYPE_0
      Properties: x86 ISA needed: SSE, SSE2
	x86 feature: IBT, SHSTK

Displaying notes found in: .note.gnu.build-id
  Owner                Data size 	Description
  GNU                  0x00000014	NT_GNU_BUILD_ID (unique build ID bitstring)
[hjl@gnu-mic-2 result]$

Comment 1 H.J. Lu 2021-02-14 21:54:40 UTC
<pbrobinson>
Date:   Sun Jan 17 10:17:39 2021 +0000

    Update to 0.2.46

 .gitignore                   |  2 ++
 libcap-2.44-buildflags.patch | 25 -------------------------
 libcap.spec                  | 11 +++++------
 sources                      |  2 +-
 4 files changed, 8 insertions(+), 32 deletions(-)
 delete mode 100644 libcap-2.44-buildflags.patch

removed CET support.

Comment 2 H.J. Lu 2021-02-14 21:55:43 UTC
The complete bad commit:

7408f6c23e9553236f0deebef3ed4f3ce8cce794 is the first bad commit
commit 7408f6c23e9553236f0deebef3ed4f3ce8cce794
Author: Peter Robinson <pbrobinson>
Date:   Sun Jan 17 10:17:39 2021 +0000

    Update to 0.2.46

 .gitignore                   |  2 ++
 libcap-2.44-buildflags.patch | 25 -------------------------
 libcap.spec                  | 11 +++++------
 sources                      |  2 +-
 4 files changed, 8 insertions(+), 32 deletions(-)
 delete mode 100644 libcap-2.44-buildflags.patch

Comment 3 Peter Robinson 2021-02-14 22:16:47 UTC
Why hasn't this patch gone upstream yet, is there a link to the upstream PR/mailing list post? There was no documentation and the patch was badly named. Is CET support a set of "build flags"?

Comment 4 H.J. Lu 2021-02-14 22:17:51 UTC
Created attachment 1757012 [details]
A patch

This works for me.

Comment 5 Peter Robinson 2021-02-14 22:22:04 UTC
(In reply to H.J. Lu from comment #4)
> Created attachment 1757012 [details]
> A patch
> 
> This works for me.

Please use the appropriate CFLAGS/LDFLAGS style notation for variables so this patch can go upstream. Please also provide a link to the upstream submission.

Comment 6 H.J. Lu 2021-02-14 22:31:29 UTC
I am not the author of the original patch.  I just need the fixed libcap rpm for my CET machine.

Comment 7 Fedora Update System 2021-02-14 23:29:47 UTC
FEDORA-2021-eeff266a64 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eeff266a64

Comment 8 Fedora Update System 2021-02-15 01:14:29 UTC
FEDORA-2021-eeff266a64 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-eeff266a64`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-eeff266a64

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-02-18 01:24:02 UTC
FEDORA-2021-eeff266a64 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.