Spec URL: https://download.copr.fedorainfracloud.org/results/moceap/FTBFS/fedora-33-x86_64/01966340-snoopy/snoopy.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/moceap/FTBFS/fedora-33-x86_64/01966340-snoopy/snoopy-2.4.12-2.fc33.src.rpm Description: A preload library to send shell commands to syslog Fedora Account System Username: moceap
This review just unretirement review. To pass FTBFS state.
Some hints to your spec file: o description line is too long, have to break down into multiple line o add BuildRequires: gcc o may additionally to BR add also Requires: procps-ng - is that a weak dependency, why Fedora only? o please consider to generate documentation and ship in a doc subpackage o execute provided tests in %check o use systemd macros in %post and %postun https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd Are you interested in a review swap?
- This is not necessary anymore: %post /sbin/ldconfig %postun /sbin/ldconfig Use %ldconfig_scriptlets for EPEL. - This should not go in %doc: %doc COPYING - Add a BR for make as it is not in the default buildroot anymore > o please consider to generate documentation and ship in a doc subpackage It doesn't seem to be needed to build the docs, the Makefile only copy the file in a directory, which can be done with %doc - make %{?_smp_mflags} → %make build > o use systemd macros in %post and %postun What Systemd files, I don't see any. - %{_includedir}/* → %{_includedir}/snoopy/ - The packaging of the so is wrong. First, the unversioned library should go into the devel subpackage: %files devel %{_includedir}/snoopy/ %{_libdir}/libsnoopy.so Second the major soname version should not be globed to avoid unintentional soname bump: %files %doc README.md ChangeLog doc/{FAQ.md,FILTER_exclude_spawns_of.md} %license COPYING %{_libdir}/libsnoopy.so.0* The script file snoopy-enable should be modified to load libsnoopy.so.0 instead of libsnoopy.so. - Please mark the %{_sysconfdir}/snoopy.ini as config: %config(noreplace) %{_sysconfdir}/snoopy.ini - Add gcc as a BR BuildRequires: gcc - Patch the m4 file to remove the obsolete macros, and send the patch upstream: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: snoopy-2.4.12/configure.ac:73 See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html , AC_PROG_LIBTOOL must be replaced with LT_INIT - Split the description to stay below 80 characters per line: snoopy.x86_64: E: description-line-too-long C Snoopy is designed to aid a sysadmin by providing a log of commands executed. Snoopy is completely transparent to the user and applications. It is linked into programs to provide a wrapper around calls to execve(). Logging is done via syslog. - Patch these files to use the new FSF address instead of the obsolete one, and send the patch upstream: snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configfile.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configuration.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/datasourceregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/error.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filtering.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filterregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/genericregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/inputdatastorage.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/libsnoopy-debug-addons.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/log.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/message.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/misc.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/outputregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/parser.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/snoopy.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/tsrm.h - Not sure about the tests, try to run them if possible Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - ldconfig not called in %post and %postun for Fedora 28 and later. Note: /sbin/ldconfig called in snoopy See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "Unknown or generated", "[generated file]", "*No copyright* GNU General Public License, Version 2", "FSF Unlimited License (with Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "Expat License [generated file]", "FSF Unlimited License (with Retention) GNU General Public License, Version 2", "FSF Unlimited License (with Retention)". 138 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/snoopy/review- snoopy/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in snoopy- devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: snoopy-2.4.12-2.fc35.x86_64.rpm snoopy-devel-2.4.12-2.fc35.x86_64.rpm snoopy-debuginfo-2.4.12-2.fc35.x86_64.rpm snoopy-debugsource-2.4.12-2.fc35.x86_64.rpm snoopy-2.4.12-2.fc35.src.rpm snoopy.x86_64: W: spelling-error Summary(en_US) preload -> reload, p reload, freeload snoopy.x86_64: W: spelling-error Summary(en_US) syslog -> slog snoopy.x86_64: W: spelling-error %description -l en_US execve -> exec snoopy.x86_64: W: spelling-error %description -l en_US syslog -> slog snoopy.x86_64: E: description-line-too-long C Snoopy is designed to aid a sysadmin by providing a log of commands executed. Snoopy is completely transparent to the user and applications. It is linked into programs to provide a wrapper around calls to execve(). Logging is done via syslog. snoopy.x86_64: W: non-conffile-in-etc /etc/snoopy.ini snoopy.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libsnoopy.so snoopy.x86_64: W: no-manual-page-for-binary snoopy-disable snoopy.x86_64: W: no-manual-page-for-binary snoopy-enable snoopy.x86_64: W: one-line-command-in-%post /sbin/ldconfig snoopy.x86_64: W: one-line-command-in-%postun /sbin/ldconfig snoopy-devel.x86_64: W: no-documentation snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configfile.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configuration.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/datasourceregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/error.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filtering.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filterregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/genericregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/inputdatastorage.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/libsnoopy-debug-addons.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/log.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/message.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/misc.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/outputregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/parser.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/snoopy.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/tsrm.h snoopy.src: W: spelling-error Summary(en_US) preload -> reload, p reload, freeload snoopy.src: W: spelling-error Summary(en_US) syslog -> slog snoopy.src: W: spelling-error %description -l en_US execve -> exec snoopy.src: W: spelling-error %description -l en_US syslog -> slog snoopy.src: E: description-line-too-long C Snoopy is designed to aid a sysadmin by providing a log of commands executed. Snoopy is completely transparent to the user and applications. It is linked into programs to provide a wrapper around calls to execve(). Logging is done via syslog. 5 packages and 0 specfiles checked; 18 errors, 15 warnings.
I made a few updates for the snoopy rpm spec file. Git PR for the spec file: https://src.fedoraproject.org/rpms/snoopy/pull-request/1 Latest spec also here: Spec URL: https://download.copr.fedorainfracloud.org/results/birkch/snoopy/fedora-33-x86_64/02142813-snoopy/snoopy.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/birkch/snoopy/fedora-33-x86_64/02142813-snoopy/snoopy-2.4.14-2.fc33.src.rpm Description: A preload library to send shell commands to syslog Fedora Account System Username: birkch
What about the patches? - Patch the m4 file to remove the obsolete macros, and send the patch upstream: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: snoopy-2.4.12/configure.ac:73 See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html , AC_PROG_LIBTOOL must be replaced with LT_INIT - Patch these files to use the new FSF address instead of the obsolete one, and send the patch upstream: snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configfile.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/configuration.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/datasourceregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/error.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filtering.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/filterregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/genericregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/inputdatastorage.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/libsnoopy-debug-addons.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/log.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/message.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/misc.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/outputregistry.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/parser.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/snoopy.h snoopy-devel.x86_64: E: incorrect-fsf-address /usr/include/snoopy/tsrm.h
As this review seems dead, I've opened a new one as bug 1986953. *** This bug has been marked as a duplicate of bug 1986953 ***