Bug 1928594 - gnome-tour shouldn't launch on Live boot
Summary: gnome-tour shouldn't launch on Live boot
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: spin-kickstarts
Version: 34
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Václav Pavlín
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-15 04:42 UTC by Chris Murphy
Modified: 2023-09-15 01:32 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-08 01:05:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot (808.03 KB, image/png)
2021-02-15 04:42 UTC, Chris Murphy
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-shell issues 3729 0 None None None 2021-02-15 13:02:13 UTC

Description Chris Murphy 2021-02-15 04:42:26 UTC
Created attachment 1757023 [details]
screenshot

Description of problem:

Looks like GNOME 40 tour is launching on Live boot.


Version-Release number of selected component (if applicable):
gnome-tour-3.38.0-3.fc34.x86_64


How reproducible:
Always


Steps to Reproduce:
1. Boot Fedora-Workstation-Live-x86_64-34-20210213.n.0.iso
2.
3.

Actual results:

Welcome to GNOME 40 covers the Welcome to Fedora window, see screenshot


Expected results:

Shouldn't run on Live bot


Additional info:

Comment 1 Kalev Lember 2021-02-15 07:56:34 UTC
Bastien, did you do the "Welcome to GNOME 40" dialogue? Can you look into how to disable this on live media, please?

Comment 2 Kalev Lember 2021-02-15 07:58:08 UTC
Moving to gnome-shell as this is where the dialog lives.

Comment 3 Bastien Nocera 2021-02-15 10:39:25 UTC
Can you please file an upstream bug about this?

Comment 4 Bastien Nocera 2021-02-15 13:10:38 UTC
Feel free to pick up the patch in https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1677 if you want to have this fixed ASAP.

Comment 5 Bastien Nocera 2021-02-15 13:40:06 UTC
Actually, this needs to happen in the kickstart file. This should work:

diff --git a/fedora-live-base.ks b/fedora-live-base.ks
index 3e4ce78..47641bc 100644
--- a/fedora-live-base.ks
+++ b/fedora-live-base.ks
@@ -184,6 +184,9 @@ systemctl stop mdmonitor-takeover.service 2> /dev/null || :
 # don't enable the gnome-settings-daemon packagekit plugin
 gsettings set org.gnome.software download-updates 'false' || :
 
+# disable welcome tour by passing a huge version number
+gsettings set org.gnome.shell welcome-dialog-last-shown-version '4294967295' || :
+
 # don't start cron/at as they tend to spawn things which are
 # disk intensive that are painful on a live image
 systemctl --no-reload disable crond.service 2> /dev/null || :

Comment 6 Geraldo Simião 2021-02-15 14:35:49 UTC
I didn't see this error on the 210211 iso image, but it is on the 210213 and on today's 210215 too.
Hope the fix pointed by @bnocera come in the next iso.

Comment 7 Kalev Lember 2021-02-15 16:18:39 UTC
(In reply to Bastien Nocera from comment #5)
> Actually, this needs to happen in the kickstart file. This should work:
> 
> diff --git a/fedora-live-base.ks b/fedora-live-base.ks
> index 3e4ce78..47641bc 100644
> --- a/fedora-live-base.ks
> +++ b/fedora-live-base.ks
> @@ -184,6 +184,9 @@ systemctl stop mdmonitor-takeover.service 2> /dev/null
> || :
>  # don't enable the gnome-settings-daemon packagekit plugin
>  gsettings set org.gnome.software download-updates 'false' || :
>  
> +# disable welcome tour by passing a huge version number
> +gsettings set org.gnome.shell welcome-dialog-last-shown-version
> '4294967295' || :
> +
>  # don't start cron/at as they tend to spawn things which are
>  # disk intensive that are painful on a live image
>  systemctl --no-reload disable crond.service 2> /dev/null || :

Nice, that sounds like it should work. Can you turn this into a PR against https://pagure.io/fedora-kickstarts.git please?

Comment 8 Bastien Nocera 2021-02-15 16:38:10 UTC
Sorry, I'm afraid that I don't have the bandwidth for turning it into a PR.

Comment 9 Bastien Nocera 2021-02-15 17:10:00 UTC
(To be clear, I have the bandwidth for making a PR, I don't have the bandwidth to actually test said change before submitting it)

Comment 10 Kalev Lember 2021-02-16 08:55:27 UTC
I think it would be perfectly fine to submit a PR for a simple change like this without testing it in a local compose first.

Comment 11 Bastien Nocera 2021-02-16 10:10:04 UTC
(In reply to Kalev Lember from comment #10)
> I think it would be perfectly fine to submit a PR for a simple change like
> this without testing it in a local compose first.

Done:
https://pagure.io/fedora-kickstarts/pull-request/763

Comment 12 Ben Cotton 2022-05-12 16:41:26 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 13 Ben Cotton 2022-06-08 01:05:38 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 14 Red Hat Bugzilla 2023-09-15 01:32:51 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days


Note You need to log in before you can comment on or make changes to this bug.