Bug 1928654 - Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java
Summary: Review Request: ongres-stringprep - RFC 3454 Preparation of Internationalized...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-15 09:51 UTC by Ondrej Dubaj
Modified: 2021-02-20 14:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-20 14:59:41 UTC
Type: ---
Embargoed:
mizdebsk: fedora-review+


Attachments (Terms of Use)

Description Ondrej Dubaj 2021-02-15 09:51:16 UTC
Spec URL: https://odubaj.fedorapeople.org/ongres-stringprep.spec
SRPM URL: https://odubaj.fedorapeople.org/ongres-stringprep-1.1-1.fc35.src.rpm
Description: This project implements the RFC 3454 Preparation of Internationalized Strings ("stringprep") in pure Java. The stringprep protocol does not stand on its own; it has to be used by other protocols at precisely-defined places in those other protocols.
Fedora Account System Username: odubaj

Comment 1 Ondrej Dubaj 2021-02-15 12:03:26 UTC
Context here:

https://github.com/pgjdbc/pgjdbc/pull/2052

Comment 2 Mikolaj Izdebski 2021-02-18 13:39:49 UTC
Spec file looks fine - tt follows packaging guidelines, including Java guidelines.
Source code it the SRPM matches upstream code.
Package builds fine in rawhide.
Buildrequires are correct, except that BR on maven-enforcer-plugin seems to be unnecessary and it can be removed.
Auto-requires are generated, manual requires are absent.

rpmlint output:
ongres-stringprep.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

The code is licensed under BSD license, which matches License tag in spec file.
License text is installed as %license.
License review reveals references to ASL 2.0 license, but it only applies to external dependency (Apache Velocity), which is not bundled in the package.

Package is APPROVED.

Comment 3 Ondrej Dubaj 2021-02-18 13:58:49 UTC
Thank you!

Comment 4 Ondrej Dubaj 2021-02-18 15:15:32 UTC
Issue for creating new repository:

https://pagure.io/releng/fedora-scm-requests/issue/32207

Comment 5 Mohan Boddu 2021-02-19 20:43:57 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ongres-stringprep

Comment 6 Ondrej Dubaj 2021-02-20 14:59:41 UTC
package stable in fedora-rawhide


Note You need to log in before you can comment on or make changes to this bug.