Bug 1929731 - Target namespace auto-complete only matches the beginning of the namespace string
Summary: Target namespace auto-complete only matches the beginning of the namespace st...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: User Experience
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 2.0.0
Assignee: Mike Turley
QA Contact: Maayan Hadasi
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-17 14:13 UTC by Md Nadeem
Modified: 2021-06-24 20:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-10 17:11:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
searchstring "mtv" (32.28 KB, image/png)
2021-02-17 14:13 UTC, Md Nadeem
no flags Details
searchstring "openshfit-rhmtv" (49.58 KB, image/png)
2021-02-17 14:14 UTC, Md Nadeem
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github konveyor forklift-ui pull 429 0 None open Bug 1929731: Allow partial string matches when filtering target namespace 2021-02-17 21:45:08 UTC
Red Hat Product Errata RHEA-2021:2381 0 None None None 2021-06-10 17:11:37 UTC

Description Md Nadeem 2021-02-17 14:13:18 UTC
Created attachment 1757570 [details]
searchstring "mtv"

Description of problem:

When you type a substring, It should checks for a match anywhere in the namespace name, Now it only searches at the beginning string of the namespace name.

For Example, to find "openshift-rhmtv", you have to either write the full name "openshift-rhmtv" or have to manually scroll down the full list to select the desired namespace.

In my expectation, when user type "mtv", It should match the "openshift-rhmtv" name space.

Please find attached snapshots for "mtv" and "openshift-rhmtv" search string.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Md Nadeem 2021-02-17 14:14:51 UTC
Created attachment 1757572 [details]
searchstring "openshfit-rhmtv"

Comment 2 Fabien Dupont 2021-02-17 15:47:32 UTC
I would add that when it's matching a substring, it should highlight it, so that the user knows why the namespace matches.

Comment 3 Mike Turley 2021-02-17 18:54:16 UTC
I will look into this, but we are limited by the restrictions of the PatternFly Typeahead Select component we're using. I think I can match on substrings but I'm not sure about highlighting.

Comment 4 Mike Turley 2021-02-17 21:54:17 UTC
I was able to add both the substring match and the highlighting in https://github.com/konveyor/forklift-ui/pull/429 :)

Comment 5 Mike Turley 2021-02-18 17:03:20 UTC
Reverting the highlighting for now (see https://github.com/konveyor/forklift-ui/pull/429#issuecomment-781490957). The PR is ready.

Comment 6 Fabien Dupont 2021-03-31 06:44:46 UTC
This should be part of build 2.0.0-8 / iib:62459.

Comment 7 Maayan Hadasi 2021-04-19 12:36:09 UTC
Verified as fixed 

MTV version: 2.0.0-17 / iib:66911


I opened a new BZ in order to follow the highlighting RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1951023

Comment 10 errata-xmlrpc 2021-06-10 17:11:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381


Note You need to log in before you can comment on or make changes to this bug.