Spec URL: https://kalev.fedorapeople.org/gdk-pixbuf2-xlib.spec SRPM URL: https://kalev.fedorapeople.org/gdk-pixbuf2-xlib-2.40.2-1.fc33.src.rpm Description: This is a package split off from gdk-pixbuf in upstream. In Fedora, this code used to be (or rather, still is) part of gdk-pixbuf2 source srpm, and packaged in gdk-pixbuf2-xlib subpackage. Now that it's split off upstream, we need to split it off downstream as well. I've kept the same package name as it had when it was part of gdk-pixbuf2 source rpm to make it easier to handle the upgrade path. In upstream it's called just 'gdk-pixbuf-xlib' without 2 in the name. The version in the split off package is higher than what's in the gdk-pixbuf2-xlib subpackage that's currently in Fedora, so upgrades should work just fine after the split. There are only a few packages remaining in Fedora that use gdk-pixbuf2-xlib and I intend to orphan the package soon after getting it in Fedora and leave it up to the dependent package maintainers to continue maintaining it: ``` $ dnf repoquery --whatrequires gdk-pixbuf2-xlib --disablerepo='*' --enablerepo=f35-build --refresh deepin-api-0:5.3.0.12-2.fc34.x86_64 deepin-daemon-0:5.11.0.36-3.fc34.x86_64 gdk-pixbuf2-xlib-devel-0:2.40.0-4.fc34.x86_64 sawfish-0:1.12.90-11.fc34.x86_64 sawfish-pager-0:0.90.4-15.fc34.x86_64 superkb-0:0.23-2.fc34.x86_64 w3m-img-0:0.5.3-49.git20200502.fc34.x86_64 xscreensaver-extras-1:5.45-4.fc34.x86_64 xscreensaver-extras-base-1:5.45-4.fc34.x86_64 xscreensaver-gl-extras-1:5.45-4.fc34.x86_64 ``` We need this package to be able to update gdk-pixbuf2 to a newer version (which has CVE fixes) as the -xlib code has been dropped from gdk-pixbuf2. Fedora Account System Username: kalev
Looks generally fine to me. License is correct. Minor quibble: the description doesn't refer to the package by its name, but by the CamelCase version. Upgrade path: not sure. Does the package need a higher R to avoid interference with the subpackage thats out there now ?
Thanks! I think the upgrade path should be fine. The current package that's in rawhide is: https://koji.fedoraproject.org/koji/buildinfo?buildID=1677224 ... which has gdk-pixbuf2-xlib 2.40.0-4.fc34 and gdk-pixbuf2-xlib-devel 2.40.0-4.fc34 subpackages. The new, split off package has higher version than that, 2.40.2, which is higher than in the current packages. Spec URL: https://kalev.fedorapeople.org/gdk-pixbuf2-xlib.spec SRPM URL: https://kalev.fedorapeople.org/gdk-pixbuf2-xlib-2.40.2-1.fc33.src.rpm * Wed Feb 17 2021 Kalev Lember <klember> - 2.40.2-2 - Use actual gdk-pixbuf2 package names in package description and summary
ah ok. Review+ from me then
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gdk-pixbuf2-xlib
FEDORA-2021-2e59756cbe has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2e59756cbe
FEDORA-2021-2e59756cbe has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-2e59756cbe` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2e59756cbe See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-2e59756cbe has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.