Bug 1930403 - btrfs-convert of /usr partition dumps core
Summary: btrfs-convert of /usr partition dumps core
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: btrfs-progs
Version: 35
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Josef Bacik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-18 19:53 UTC by George R. Goffe
Modified: 2022-12-13 15:18 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-12-13 15:18:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kdave btrfs-progs issues 312 0 None open btrfs-convert aborted 2021-02-19 02:16:38 UTC

Description George R. Goffe 2021-02-18 19:53:56 UTC
Description of problem: Booted "latest" Live image for Fedora Core (35?). Ran btrfs-convert on /var, /export/home, and /usr (ext4 - btrfs). Convert dumped core. It's not clear to me what files are needed to trouble shoot this "bug". Please let me know which and I'll try to provide them


Version-Release number of selected component (if applicable):
see below

How reproducible:
tried twice

Steps to Reproduce:
1.see below
2.
3.

Actual results:
corefile(?)

Expected results:
successful conversion

Additional info:


localhost-live--bash 5.1 ~# btrfs-convert /dev/sda7
create btrfs filesystem:
        blocksize: 4096
        nodesize:  16384
        features:  extref, skinny-metadata (default)
        checksum:  crc32c
free space report:
        total:     68719476736
        free:      556998656 (0.81%)
creating ext2 image file
creating btrfs metadata
kernel-shared/ctree.c:2375: split_leaf: BUG_ON `1` triggered, value 1
btrfs-convert(+0x33032)[0x55dbf7cdc032]
btrfs-convert(btrfs_search_slot+0xf3b)[0x55dbf7cce77b]
btrfs-convert(btrfs_insert_empty_items+0x91)[0x55dbf7cd38c1]
btrfs-convert(btrfs_insert_inline_extent+0x86)[0x55dbf7cee726]
btrfs-convert(+0x156d1)[0x55dbf7cbe6d1]
btrfs-convert(+0x1681c)[0x55dbf7cbf81c]
btrfs-convert(main+0x1fbb)[0x55dbf7cb842b]
/usr/lib64/libc.so.6(__libc_start_main+0xd5)[0x7f1da146cb75]
btrfs-convert(_start+0x2e)[0x55dbf7cb8b9e]
Aborted (core dumped)

Comment 1 Chris Murphy 2021-02-19 02:16:38 UTC
free space report:
        total:     68719476736
        free:      556998656 (0.81%)

This is a 64 G file system, with ~530M free? The problem is there's not enough space for the conversion to complete. But it should fail more gracefully in such a case.

Comment 2 George R. Goffe 2021-02-19 22:18:22 UTC
Chris,

Thanks for your response to this bug report. 

This situation is even more complicated... maybe. I'm REALLY tight on space on this system and have run "tune2fs -m2" on the /usr filesystem. Maybe convert doesn't like this? I have converted two other filesystems without this problem though.

While I have you on the phone, I have a question I'd like to ask you if you don't mind.

I found doc about converting to btrfs that I maye be reading incorrectly. The situation is, on one of the of the other filesystems I converted, I deleted the wrong directory. Crap! No backup. In this doc I was reading I see a discussion about "btrfs-convert -r /dev/xxx" to reverse the conversion. These words seem to be implying that I could run this command and recover the deleted directory since the save_ext2 subvolume still exists. Is this correct?

I'll have to search for the docs again since the directory I deleted was the home directory for a test user... that has the link I was reading. I think it was on one of the fedoraproject sites.

Best regards and STAY SAFE,

George...

Comment 3 George R. Goffe 2021-02-19 22:23:27 UTC
Chris,

This looks like the link I was reading. Not a fedoraproject site though. Sigh.

https://fedoramagazine.org/convert-your-filesystem-to-btrfs/

Regards,

George...

Comment 4 Chris Murphy 2021-02-19 23:33:42 UTC
> This situation is even more complicated... maybe. I'm REALLY tight on space
> on this system and have run "tune2fs -m2" on the /usr filesystem. 

Btrfs doesn't support reserved space, so it's going to make that space generally available whether 2% or 5%. 0.81% is probably within the no go zone where it should just refuse to convert, or at least warn. Typical is 1-2% with some cases involving many small files requiring up to 5% space due Btrfs ability to pack leaves with inline extents.

>I
> deleted the wrong directory. Crap! No backup. In this doc I was reading I
> see a discussion about "btrfs-convert -r /dev/xxx" to reverse the
> conversion. These words seem to be implying that I could run this command
> and recover the deleted directory since the save_ext2 subvolume still
> exists. Is this correct?

If you deleted the file after the conversion, then it's still in the save_ext2 snapshot, you don't even need to do a rollback, you can just copy it out of the snapshot as if it were a file in a directory. Best to talk about that on test@ list or on IRC.

Comment 5 Ben Cotton 2021-08-10 13:39:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 6 Ben Cotton 2022-11-29 16:52:28 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 7 Ben Cotton 2022-12-13 15:18:17 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.