Bug 1930869 - creation of zram
Summary: creation of zram
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: rust-zram-generator
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rust SIG
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-19 16:40 UTC by udo
Modified: 2021-09-29 08:14 UTC (History)
15 users (show)

Fixed In Version: rust-zram-generator-0.3.2-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-29 08:14:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description udo 2021-02-19 16:40:05 UTC
Description of problem:
/dev/zram0 is created over and over again


Version-Release number of selected component (if applicable):
systemd-246.10-1.fc33.x86_64

How reproducible:
Use Fedora; do update sometimes

Actual results:
See below.

Expected results:
Creation of /dev/zram0 _once_.

Additional info:
# dmesg|grep zram
[   18.148777] zram_generator::generator[1335]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[   18.153455] zram: Added device: zram0
[   19.661542] zram0: detected capacity change from 0 to 4294967296
[   19.717483] Adding 4194300k swap on /dev/zram0.  Priority:100 extents:1 across:4194300k SS
[ 1279.396923] zram_generator::generator[28684]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[ 1405.915735] zram_generator::generator[149881]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[ 1419.015022] zram_generator::generator[171847]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[71685.919988] zram_generator::generator[563563]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[103193.137783] zram_generator::generator[599401]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[192501.975785] zram_generator::generator[789283]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[455133.603650] zram_generator::generator[1299539]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[531130.777465] zram_generator::generator[1460403]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[531146.905910] zram_generator::generator[1462979]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[674728.631998] zram_generator::generator[1872003]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[867047.426889] zram_generator::generator[2287380]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1108380.237015] zram_generator::generator[2826529]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1207161.266621] zram_generator::generator[3011071]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1214598.527556] zram_generator::generator[3045595]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1315709.589100] zram_generator::generator[3226054]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1485661.578596] zram_generator::generator[3578069]: Creating dev-zram0.swap for /dev/zram0 (4096MB)
[1643141.768620] zram_generator::generator[3910285]: Creating dev-zram0.swap for /dev/zram0 (4096MB)

Comment 1 Zbigniew Jędrzejewski-Szmek 2021-02-19 17:14:50 UTC
I tried to make it clear in the message that it's just the unit file that is being created by
the generator. Anyway, what is happening here is that daemon-reload is being called over and
over and the generator recreates the file each time. There is no error, except that something
is angrily calling daemon-reload.

Comment 2 udo 2021-02-19 17:24:34 UTC
Why does dev-zram0.swap have to be created so many times?
If it exists, leave it be.
If it is a normal function to recreate these files on reload, then why bother mentioning it when the operation succeeds?
I guess the core of the thing is:
Please bother the user only with relevant stuff.
An operation that succeeds is not relevant. It is normal to succeed.
Only when operations fail or have issues attention is required.
Also adjusting logging to these ideas makes the software look less like it came right out of a lab where it was tested.

I run the systems with systemd.log_level=warning but that setting does not appear to have any effect.
If dev-zram0.swap creation is a warning or worse, why?

Comment 3 Zbigniew Jędrzejewski-Szmek 2021-02-23 19:51:13 UTC
https://github.com/systemd/zram-generator/pull/70

Comment 4 udo 2021-02-26 06:02:23 UTC
Thanks

Comment 5 Fedora Update System 2021-02-26 08:13:40 UTC
FEDORA-2021-08c87dbaa9 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-08c87dbaa9

Comment 6 Fedora Update System 2021-02-26 16:33:53 UTC
FEDORA-2021-08c87dbaa9 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-08c87dbaa9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-08c87dbaa9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-03-19 17:39:02 UTC
FEDORA-2021-08c87dbaa9 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2021-03-19 19:56:13 UTC
FEDORA-2021-08c87dbaa9 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 udo 2021-03-20 14:25:35 UTC
We use fedora 33...

Comment 10 Zbigniew Jędrzejewski-Szmek 2021-03-21 11:42:25 UTC
Fabio, Igor, what process should be used to build a new version of the package for F33?
I want to update the package to the latest version, but not exactly to the same *spec* file as in F34+,
because the defaults which are embedded in the spec file were changed for F34.
I prepped the right spec file locally, and it builds fine in rawhide mock, but not in f33, because the
rust devel packages are missing.

Comment 11 Fabio Valentini 2021-03-21 12:48:59 UTC
If the .spec file must be different for f33 than it is for f34/rawhide, then you need to commit them on the f33 branch, as usual.

This only changes one step in the Rust package build instructions for f32 + f33, e.g. you *do* have a f33 dist-git branch to use for the f33 build, and don't build from the rawhide branch.

E.g. if you use the rustbuild.sh bash script by Dusty:
https://dustymabe.fedorapeople.org/rustbuild.sh
Or the original fish script by Igor:
 https://gist.github.com/ignatenkobrain/f2529a3f9e34848fa63587db94089a0f

The only change in both cases is that you actually *have* a f33 branch in git, not only in PDC, and must switch to it (or already be on it after having pushed your f33-specific changes) before running "fedpkg build --target f33-build-side-foo", and you don't need "--skip-nvr-check" then.

Feel free to ping me in #fedora-rust if you have any questions or problems.

Comment 12 Zbigniew Jędrzejewski-Szmek 2021-09-29 08:14:40 UTC
I completely dropped the ball on this one, sorry. But now F33 is almost EOL. I don't want to learn
a new procedure, so I'll close this. (If somebody knows how and want to build the package and do an update,
I certainly don't mind.)


Note You need to log in before you can comment on or make changes to this bug.