RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1930873 - backport "json: init parser state for every new buffer/file"
Summary: backport "json: init parser state for every new buffer/file"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: nftables
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Phil Sutter
QA Contact: Tomas Dolezal
URL:
Whiteboard:
Depends On:
Blocks: 1935129
TreeView+ depends on / blocked
 
Reported: 2021-02-19 16:50 UTC by Eric Garver
Modified: 2021-06-18 10:41 UTC (History)
4 users (show)

Fixed In Version: nftables-0.9.3-18.el8
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 1935129 1973630 (view as bug list)
Environment:
Last Closed: 2021-05-18 15:10:15 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
python reproducer (1.40 KB, text/x-python)
2021-02-19 19:17 UTC, Eric Garver 		no flags Details
View All

Description Eric Garver 2021-02-19 16:50:05 UTC 
Upstream commit 267338ec3923 ("json: init parser state for every new buffer/file") fixes an issue in the json parser which causes subsequent valid commands to fail if the previous batch/buffer failed.

This causes lots of problems for firewalld as a correctly failing command (e.g. invalid set add entry) causes following commands to fails.
Comment 2 Eric Garver 2021-02-19 19:17:11 UTC 
Created attachment 1758250 [details]
python reproducer

[root@rhel8 nftables]# python3 /tmp/reproducer.py
{'nftables': [{'flush': {'ruleset': None}}]}
{'nftables': [{'add': {'table': {'family': 'inet', 'name': 'firewalld'}}}]}
{'nftables': [{'add': {'chain': {'family': 'inet', 'table': 'firewalld', 'name': 'input'}}}]}
{'nftables': [{'add': {'rule': {'family': 'inet', 'table': 'firewalld', 'chain': 'input', 'expr': [{'accept': None}]}}}]}
{'nftables': [{'add': {'set': {'family': 'inet', 'table': 'firewalld', 'name': 'foobar', 'type': 'ipv4_addr'}}}]}
{'nftables': [{'add': {'element': {'family': 'inet', 'table': 'firewalld', 'name': 'foobar', 'elem': [{'prefix': {'addr': '1.2.3.0', 'len': 24}}]}}}]}
{'nftables': [{'delete': {'rule': {'family': 'inet', 'table': 'firewalld', 'chain': 'input', 'handle': 2}}}]}
FAIL: expected rc = 0, actual rc = -1

[root@rhel8 nftables]# make install # with upstream fix
[..]

[root@rhel8 nftables]# python3 /tmp/reproducer.py
{'nftables': [{'flush': {'ruleset': None}}]}
{'nftables': [{'add': {'table': {'family': 'inet', 'name': 'firewalld'}}}]}
{'nftables': [{'add': {'chain': {'family': 'inet', 'table': 'firewalld', 'name': 'input'}}}]}
{'nftables': [{'add': {'rule': {'family': 'inet', 'table': 'firewalld', 'chain': 'input', 'expr': [{'accept': None}]}}}]}
{'nftables': [{'add': {'set': {'family': 'inet', 'table': 'firewalld', 'name': 'foobar', 'type': 'ipv4_addr'}}}]}
{'nftables': [{'add': {'element': {'family': 'inet', 'table': 'firewalld', 'name': 'foobar', 'elem': [{'prefix': {'addr': '1.2.3.0', 'len': 24}}]}}}]}
{'nftables': [{'delete': {'rule': {'family': 'inet', 'table': 'firewalld', 'chain': 'input', 'handle': 2}}}]}
{'nftables': [{'flush': {'ruleset': None}}]}
PASS
Comment 16 errata-xmlrpc 2021-05-18 15:10:15 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nftables bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1722
Note You need to log in before you can comment on or make changes to this bug.