Bug 1930941 - Review Request: golang-github-nathanaelle-syslog5424-2 - Log.Logger-friendly RFC-5424 syslog library
Summary: Review Request: golang-github-nathanaelle-syslog5424-2 - Log.Logger-friendly ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-02-19 20:20 UTC by Brandon Perkins
Modified: 2021-03-25 01:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-20 00:16:50 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Brandon Perkins 2021-02-19 20:20:47 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-nathanaelle-syslog5424.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9368/62309368/golang-github-nathanaelle-syslog5424-2-2.0.5-1.fc35.src.rpm
Description: Log.Logger-friendly RFC-5424 syslog library.
Fedora Account System Username: bdperkin

Comment 1 Robert-André Mauchin 🐧 2021-03-10 11:35:05 UTC
 - Also specify forgeurl for import path containing a version vX, otherwise the URL: link would be incorrect.

# https://github.com/nathanaelle/syslog5424
%global goipath         github.com/nathanaelle/syslog5424/v2
%global forgeurl        https://github.com/nathanaelle/syslog5424
Version:                2.0.5

See rpmlint:

golang-github-nathanaelle-syslog5424-2-devel.noarch: W: invalid-url URL: https://github.com/nathanaelle/syslog5424/v2 HTTP Error 404: Not Found

- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: golang-github-nathanaelle-syslog5424.spec should be golang-github-
  nathanaelle-syslog5424-2.spec
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_spec_file_naming


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issues before import.

Comment 2 Brandon Perkins 2021-03-10 16:17:50 UTC
Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-nathanaelle-syslog5424-2.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3269/63503269/golang-github-nathanaelle-syslog5424-2-2.0.5-1.fc35.src.rpm

Fixes for Comment 1 commit: https://github.com/bdperkin/haproxytech/commit/b29c02d6ecef14b45bb75569016162a510fb459d

=====
From b29c02d6ecef14b45bb75569016162a510fb459d Mon Sep 17 00:00:00 2001
From: Brandon Perkins <bperkins>
Date: Wed, 10 Mar 2021 11:03:09 -0500
Subject: [PATCH] Fixes for BZ#1930941, comment 1.

---
 ...og5424.spec => golang-github-nathanaelle-syslog5424-2.spec} | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 rename SPECS/{golang-github-nathanaelle-syslog5424.spec => golang-github-nathanaelle-syslog5424-2.spec} (87%)

diff --git a/SPECS/golang-github-nathanaelle-syslog5424.spec b/SPECS/golang-github-nathanaelle-syslog5424-2.spec
similarity index 87%
rename from SPECS/golang-github-nathanaelle-syslog5424.spec
rename to SPECS/golang-github-nathanaelle-syslog5424-2.spec
index 96b673a..8fb2850 100644
--- a/SPECS/golang-github-nathanaelle-syslog5424.spec
+++ b/SPECS/golang-github-nathanaelle-syslog5424-2.spec
@@ -1,7 +1,8 @@
 %bcond_without check
 
-# https://github.com/nathanaelle/syslog5424/v2
+# https://github.com/nathanaelle/syslog5424
 %global goipath         github.com/nathanaelle/syslog5424/v2
+%global forgeurl        https://github.com/nathanaelle/syslog5424
 Version:                2.0.5
 
 %gometa
=====

$ rpmlint golang-github-nathanaelle-syslog5424-2-devel-2.0.5-1.fc35.noarch.rpm
golang-github-nathanaelle-syslog5424-2-devel.noarch: W: spelling-error Summary(en_US) syslog -> slog
golang-github-nathanaelle-syslog5424-2-devel.noarch: W: spelling-error %description -l en_US syslog -> slog
golang-github-nathanaelle-syslog5424-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/nathanaelle/syslog5424/v2/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 3 Tomas Hrcka 2021-03-10 22:53:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-nathanaelle-syslog5424-2

Comment 4 Fedora Update System 2021-03-16 16:24:00 UTC
FEDORA-2021-8f81734447 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f81734447

Comment 5 Fedora Update System 2021-03-16 16:53:53 UTC
FEDORA-2021-d178ae9083 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d178ae9083

Comment 6 Fedora Update System 2021-03-16 17:06:51 UTC
FEDORA-2021-826bbccbe6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-826bbccbe6

Comment 7 Fedora Update System 2021-03-16 23:30:22 UTC
FEDORA-2021-8f81734447 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8f81734447 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f81734447

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-03-17 01:41:44 UTC
FEDORA-2021-d178ae9083 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d178ae9083 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d178ae9083

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-03-17 01:49:49 UTC
FEDORA-2021-826bbccbe6 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-826bbccbe6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-826bbccbe6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-03-20 00:16:50 UTC
FEDORA-2021-8f81734447 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-03-24 02:39:47 UTC
FEDORA-2021-d178ae9083 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2021-03-25 01:14:56 UTC
FEDORA-2021-826bbccbe6 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.