Spec URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02003527-python-avocado/python-avocado.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02003527-python-avocado/python-avocado-82.0-2.fc35.src.rpm Description: Avocado is a set of tools and libraries (what people call these days a framework) to perform automated testing. Fedora Account System Username: merlinm Note: The python-avocado package already exists in Fedora, but has been modular-only (as part of the avocado module) for quite some time. Thus, as noted in https://pagure.io/releng/issue/10025, a package review is required to bring it back as a regular package. The content of the package in this review request is identical to the current "82lts" stream branch except for a few BuildRequires adjustments to make COPR and rpmlint happier.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= The license tag is "License: GPLv2 and MIT", I believe it should be "License: GPLv2+ and GPLv2 and MIT". Licensecheck reports: *No copyright* Expat License ---------------------------- avocado-82.0/avocado/core/tapparser.py *No copyright* GNU General Public License ----------------------------------------- avocado-82.0/avocado/core/settings.py avocado-82.0/avocado/core/sysinfo.py avocado-82.0/avocado/core/test.py avocado-82.0/avocado/utils/diff_validator.py avocado-82.0/avocado/utils/download.py avocado-82.0/avocado/utils/file_utils.py avocado-82.0/avocado/utils/genio.py *No copyright* GNU General Public License v2.0 or later ------------------------------------------------------- avocado-82.0/avocado/core/exit_codes.py avocado-82.0/avocado/core/teststatus.py avocado-82.0/avocado/utils/cpu.py avocado-82.0/optional_plugins/varianter_cit/avocado_varianter_cit/__init__.py avocado-82.0/optional_plugins/varianter_cit/setup.py Expat License ------------- avocado-82.0/avocado/utils/external/gdbmi_parser.py avocado-82.0/avocado/utils/external/spark.py avocado-82.0/optional_plugins/html/avocado_result_html/templates/bootstrap.min.css avocado-82.0/optional_plugins/html/avocado_result_html/templates/bootstrap.min.js avocado-82.0/selftests/.data/jenkins-junit.xsd Expat License GNU General Public License v2.0 or later ------------------------------------------------------ avocado-82.0/selftests/unit/test_tap.py GNU General Public License -------------------------- avocado-82.0/avocado/core/main.py avocado-82.0/avocado/libexec/avocado-bash-utils avocado-82.0/contrib/scripts/avocado-bisect.sh avocado-82.0/contrib/scripts/avocado-check-pr.sh avocado-82.0/contrib/scripts/avocado-find-unittests avocado-82.0/contrib/scripts/avocado-get-job-results-dir.py avocado-82.0/contrib/testsuites/run-kvm-unit-test.sh avocado-82.0/scripts/avocado-run-testplan GNU General Public License v2.0 only ------------------------------------ avocado-82.0/contrib/packages/debian/copyright GNU General Public License v2.0 or later ---------------------------------------- avocado-82.0/avocado/__init__.py avocado-82.0/avocado/core/__init__.py ... avocado-82.0/selftests/unit/test_utils_stacktrace.py avocado-82.0/setup.py GNU General Public License, Version 2 ------------------------------------- avocado-82.0/LICENSE avocado-82.0/avocado/utils/lv_utils.py avocado-82.0/avocado/utils/service.py avocado-82.0/docs/source/guides/contributor/chapters/how.rst avocado-82.0/docs/source/quickstart/index.rst avocado-82.0/selftests/unit/test_utils_service.py Unknown or generated -------------------- ... --- It appears that some packages can be installed without the %license file installed. Notably python-%{pkgname}-common, python-%{pkgname}-bash and python-%{pkgname}-examples. --- Real rpmlint issues: python3-avocado.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/avocado/core/nrunner.py 644 /usr/bin/env python3 python3-avocado.noarch: W: dangling-relative-symlink /usr/share/doc/python3-avocado/README.rst docs/source/quickstart/index.rst See yourself: $ file /usr/share/doc/python3-avocado/README.rst /usr/share/doc/python3-avocado/README.rst: broken symbolic link to docs/source/quickstart/index.rst python-avocado.src: E: specfile-error warning: bogus date in %changelog: Thu Feb 19 2021 Merlin Mathesius <mmathesi> - 82.0-2 --- Group tag is not supposed to be used: Group: Development/Tools --- %{python_provide} SHOULD not be used. Remove it or replace with %py_provides if appropriate. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro --- The %check sections repeatedly runs `%{__python3} setup.py develop --user`. This can backfire for builds outside of mock. Is does not appear to be necessary. This: PATH=$USER_BASE/bin:$HOME/bin:$PATH LANG=en_US.UTF-8 AVOCADO_CHECK_LEVEL=0 %{__python3} selftests/run Can be replaced with: PATH=%{buildroot}%{_bindir}:%{buildroot}%{_libexecdir}/avocado:$PATH PYTHONPATH=%{buildroot}%{python3_sitelib}:. LANG=en_US.UTF-8 AVOCADO_CHECK_LEVEL=0 %{python3} selftests/run I also suggest to "hide" the section in the conditional, so it is not present in build.log when built without tests. Instead of installing to and testing stuff from $HOME. The entire %check section after the changes: %check %if 0%{?with_tests} # LANG: to make the results predictable, we pin the language # that is used during test execution. # AVOCADO_CHECK_LEVEL: package build environments have the least # amount of resources we have observed so far. Let's avoid tests that # require too much resources or are time sensitive PATH=%{buildroot}%{_bindir}:%{buildroot}%{_libexecdir}/avocado:$PATH PYTHONPATH=%{buildroot}%{python3_sitelib}:. LANG=en_US.UTF-8 AVOCADO_CHECK_LEVEL=0 %{python3} selftests/run %endif --- Some packages have duplicated and/or suspicious requires: python3-avocado: ... python(abi) = 3.9 python3 -> this is duplicate of the above python3-pycdlib -> this is missing in upstream metadata, why is it required? python3-setuptools -> this is duplicate of python3.9dist(setuptools) python3-six -> this is missing in upstream metadata, why is it required? python3.9dist(setuptools) python3-avocado-plugins-output-html: ... python3-jinja2 -> this is duplicate of python3.9dist(jinja2) python3.9dist(avocado-framework) python3.9dist(jinja2) python3.9dist(markupsafe) python3-avocado-plugins-resultsdb: ... python3-resultsdb_api -> this is duplicate of python3.9dist(resultsdb-api) python3.9dist(avocado-framework) python3.9dist(resultsdb-api) python3-avocado-plugins-varianter-yaml-to-mux: ... python3-yaml -> this is duplicate of python3.9dist(pyyaml) python3.9dist(avocado-framework) python3.9dist(pyyaml) Suggestions: ============ Switch to HTTPS URL: URL: http://avocado-framework.github.io/ --- Update/remove old conditionals like: %if 0%{?fedora} >= 30 || 0%{?rhel} %if (0%{?fedora} && 0%{?fedora} < 29) || 0%{?rhel} --- Replace %{__make} with %make_build: %{__make} man -> %make_build man Replace %{__python3} with %{python3}. Replace %{__rm}, %{__mv}, %{__ln_s}, %{__mkdir}, %{__cp} etc. with rm, mv, ln -s, mkdir, cp etc. --- Opinionated suggestion: The spec file somewhat arbitrarily(?) uses "avacado", "%{srcname}" and "%{pkgname}". I'd stick to "avocado" for better readability, I don't expect the name of the project to be updated so often to justify this complexity. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "GNU General Public License", "*No copyright* GNU General Public License v2.0 or later", "*No copyright* GNU General Public License", "*No copyright* Expat License", "Expat License", "Expat License GNU General Public License v2.0 or later", "GNU General Public License v2.0 only". 581 files have unknown license. Detailed output of licensecheck in /home/churchyard/rpmbuild/FedoraReview/1930948-python- avocado/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 194560 bytes in 102 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-avocado-82.0-2.fc35.noarch.rpm python-avocado-common-82.0-2.fc35.noarch.rpm python3-avocado-plugins-output-html-82.0-2.fc35.noarch.rpm python3-avocado-plugins-resultsdb-82.0-2.fc35.noarch.rpm python3-avocado-plugins-varianter-yaml-to-mux-82.0-2.fc35.noarch.rpm python3-avocado-plugins-loader-yaml-82.0-2.fc35.noarch.rpm python3-avocado-plugins-golang-82.0-2.fc35.noarch.rpm python3-avocado-plugins-varianter-pict-82.0-2.fc35.noarch.rpm python3-avocado-plugins-varianter-cit-82.0-2.fc35.noarch.rpm python3-avocado-plugins-result-upload-82.0-2.fc35.noarch.rpm python3-avocado-plugins-glib-82.0-2.fc35.noarch.rpm python-avocado-examples-82.0-2.fc35.noarch.rpm python-avocado-bash-82.0-2.fc35.noarch.rpm python-avocado-82.0-2.fc35.src.rpm python3-avocado.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/avocado/core/nrunner.py 644 /usr/bin/env python3 python3-avocado.noarch: W: dangling-relative-symlink /usr/share/doc/python3-avocado/README.rst docs/source/quickstart/index.rst python3-avocado.noarch: W: no-manual-page-for-binary avocado python3-avocado.noarch: W: no-manual-page-for-binary avocado-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager-3.9 python-avocado-common.noarch: W: non-conffile-in-etc /etc/avocado/scripts/job/post.d/README python-avocado-common.noarch: W: non-conffile-in-etc /etc/avocado/scripts/job/pre.d/README python3-avocado-plugins-output-html.noarch: W: no-documentation python3-avocado-plugins-resultsdb.noarch: W: no-documentation python3-avocado-plugins-varianter-yaml-to-mux.noarch: W: no-documentation python3-avocado-plugins-loader-yaml.noarch: W: spelling-error %description -l en_US mux -> mix, mu, mus python3-avocado-plugins-loader-yaml.noarch: W: spelling-error %description -l en_US varianter -> variant er, variant-er, variant python3-avocado-plugins-loader-yaml.noarch: W: no-documentation python3-avocado-plugins-golang.noarch: W: no-documentation python3-avocado-plugins-varianter-pict.noarch: W: spelling-error Summary(en_US) combinatorial -> combination python3-avocado-plugins-varianter-pict.noarch: W: no-documentation python3-avocado-plugins-varianter-cit.noarch: W: no-documentation python3-avocado-plugins-result-upload.noarch: W: no-documentation python3-avocado-plugins-glib.noarch: W: no-documentation python-avocado-examples.noarch: E: zero-length /usr/share/doc/avocado/tests/output_check.sh.data/stderr.expected python-avocado-examples.noarch: E: zero-length /usr/share/doc/avocado/tests/synctest.py.data/stderr.expected python-avocado-bash.noarch: W: no-documentation python-avocado.src: E: specfile-error warning: bogus date in %changelog: Thu Feb 19 2021 Merlin Mathesius <mmathesi> - 82.0-2 14 packages and 0 specfiles checked; 4 errors, 43 warnings. Rpmlint (installed packages) ---------------------------- python-avocado-bash.noarch: W: no-documentation python3-avocado-plugins-varianter-pict.noarch: W: spelling-error Summary(en_US) combinatorial -> combination python3-avocado-plugins-varianter-pict.noarch: W: no-documentation python3-avocado-plugins-golang.noarch: W: no-documentation python-avocado-examples.noarch: E: zero-length /usr/share/doc/avocado/tests/output_check.sh.data/stderr.expected python-avocado-examples.noarch: E: zero-length /usr/share/doc/avocado/tests/synctest.py.data/stderr.expected python3-avocado-plugins-output-html.noarch: W: no-documentation python3-avocado-plugins-result-upload.noarch: W: no-documentation python3-avocado-plugins-resultsdb.noarch: W: no-documentation python3-avocado-plugins-loader-yaml.noarch: W: spelling-error %description -l en_US mux -> mix, mu, mus python3-avocado-plugins-loader-yaml.noarch: W: spelling-error %description -l en_US varianter -> variant er, variant-er, variant python3-avocado-plugins-loader-yaml.noarch: W: no-documentation python3-avocado-plugins-varianter-cit.noarch: W: no-documentation python3-avocado-plugins-varianter-yaml-to-mux.noarch: W: no-documentation python3-avocado-plugins-glib.noarch: W: no-documentation python-avocado-common.noarch: W: non-conffile-in-etc /etc/avocado/scripts/job/post.d/README python-avocado-common.noarch: W: non-conffile-in-etc /etc/avocado/scripts/job/pre.d/README python3-avocado.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/avocado/core/nrunner.py 644 /usr/bin/env python3 python3-avocado.noarch: W: dangling-relative-symlink /usr/share/doc/python3-avocado/README.rst docs/source/quickstart/index.rst python3-avocado.noarch: W: no-manual-page-for-binary avocado python3-avocado.noarch: W: no-manual-page-for-binary avocado-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-avocado-instrumented-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-exec-test-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-noop-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-python-unittest-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-runner-tap-3.9 python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager-3 python3-avocado.noarch: W: no-manual-page-for-binary avocado-software-manager-3.9 13 packages and 0 specfiles checked; 3 errors, 43 warnings. Source checksums ---------------- https://github.com/avocado-framework/avocado/archive/82.0.tar.gz#/avocado-82.0.tar.gz : CHECKSUM(SHA256) this package : 2c102186dd6ad017f767e1ee6faf0ed1dcfc78ebef9a580e795f122778551f0e CHECKSUM(SHA256) upstream package : 2c102186dd6ad017f767e1ee6faf0ed1dcfc78ebef9a580e795f122778551f0e Requires -------- python3-avocado (rpmlib, GLIBC filtered): /usr/bin/python3 gdb gdb-gdbserver procps-ng python(abi) python-avocado-common python3 python3-pycdlib python3-setuptools python3-six python3.9dist(setuptools) python-avocado-common (rpmlib, GLIBC filtered): config(python-avocado-common) python3-avocado-plugins-output-html (rpmlib, GLIBC filtered): python(abi) python3-avocado python3-jinja2 python3.9dist(avocado-framework) python3.9dist(jinja2) python3.9dist(markupsafe) python3-avocado-plugins-resultsdb (rpmlib, GLIBC filtered): python(abi) python3-avocado python3-resultsdb_api python3.9dist(avocado-framework) python3.9dist(resultsdb-api) python3-avocado-plugins-varianter-yaml-to-mux (rpmlib, GLIBC filtered): python(abi) python3-avocado python3-yaml python3.9dist(avocado-framework) python3.9dist(pyyaml) python3-avocado-plugins-loader-yaml (rpmlib, GLIBC filtered): python(abi) python3-avocado-plugins-varianter-yaml-to-mux python3.9dist(avocado-framework-plugin-varianter-yaml-to-mux) python3-avocado-plugins-golang (rpmlib, GLIBC filtered): golang python(abi) python3-avocado python3.9dist(avocado-framework) python3-avocado-plugins-varianter-pict (rpmlib, GLIBC filtered): python(abi) python3-avocado python3.9dist(avocado-framework) python3-avocado-plugins-varianter-cit (rpmlib, GLIBC filtered): python(abi) python3-avocado python3.9dist(avocado-framework) python3-avocado-plugins-result-upload (rpmlib, GLIBC filtered): python(abi) python3-avocado python3.9dist(avocado-framework) python3-avocado-plugins-glib (rpmlib, GLIBC filtered): python(abi) python3-avocado python3.9dist(avocado-framework) python-avocado-examples (rpmlib, GLIBC filtered): python-avocado-bash (rpmlib, GLIBC filtered): /usr/bin/sh python-avocado-common Provides -------- python3-avocado: python-avocado python3-avocado python3.9-avocado python3.9dist(avocado-framework) python3dist(avocado-framework) python-avocado-common: config(python-avocado-common) python-avocado-common python3-avocado-plugins-output-html: python-avocado-plugins-output-html python3-avocado-plugins-output-html python3.9-avocado-plugins-output-html python3.9dist(avocado-framework-plugin-result-html) python3dist(avocado-framework-plugin-result-html) python3-avocado-plugins-resultsdb: python-avocado-plugins-resultsdb python3-avocado-plugins-resultsdb python3.9-avocado-plugins-resultsdb python3.9dist(avocado-framework-plugin-resultsdb) python3dist(avocado-framework-plugin-resultsdb) python3-avocado-plugins-varianter-yaml-to-mux: python-avocado-plugins-varianter-yaml-to-mux python3-avocado-plugins-varianter-yaml-to-mux python3.9-avocado-plugins-varianter-yaml-to-mux python3.9dist(avocado-framework-plugin-varianter-yaml-to-mux) python3dist(avocado-framework-plugin-varianter-yaml-to-mux) python3-avocado-plugins-loader-yaml: python-avocado-plugins-loader-yaml python3-avocado-plugins-loader-yaml python3.9-avocado-plugins-loader-yaml python3.9dist(avocado-framework-plugin-loader-yaml) python3dist(avocado-framework-plugin-loader-yaml) python3-avocado-plugins-golang: python-avocado-plugins-golang python3-avocado-plugins-golang python3.9-avocado-plugins-golang python3.9dist(avocado-framework-plugin-golang) python3dist(avocado-framework-plugin-golang) python3-avocado-plugins-varianter-pict: python-avocado-plugins-varianter-pict python3-avocado-plugins-varianter-pict python3.9-avocado-plugins-varianter-pict python3.9dist(avocado-framework-plugin-varianter-pict) python3dist(avocado-framework-plugin-varianter-pict) python3-avocado-plugins-varianter-cit: python-avocado-plugins-varianter-cit python3-avocado-plugins-varianter-cit python3.9-avocado-plugins-varianter-cit python3.9dist(avocado-framework-plugin-varianter-cit) python3dist(avocado-framework-plugin-varianter-cit) python3-avocado-plugins-result-upload: python-avocado-plugins-result-upload python3-avocado-plugins-result-upload python3.9-avocado-plugins-result-upload python3.9dist(avocado-framework-plugin-result-upload) python3dist(avocado-framework-plugin-result-upload) python3-avocado-plugins-glib: python-avocado-plugins-glib python3-avocado-plugins-glib python3.9-avocado-plugins-glib python3.9dist(avocado-framework-plugin-glib) python3dist(avocado-framework-plugin-glib) python-avocado-examples: python-avocado-examples python-avocado-bash: python-avocado-bash Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 1930948 -m fedora-rawhide-x86_64 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: PHP, SugarActivity, Haskell, fonts, Java, R, Perl, Ruby, Ocaml, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Apologies for the long delay. This slipped off my radar. Thank you for the comprehensive review, I think I have addressed the issues that were pointed out. New Spec URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02200570-python-avocado/python-avocado.spec New SRPM URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02200570-python-avocado/python-avocado-82.0-2.fc35.src.rpm
Since I no longer remeber anything from thsi review :D I've decided to check my previous concerns one by one. Inlined: (In reply to Miro Hrončok from comment #1) > The license tag is "License: GPLv2 and MIT", I believe it should be > "License: GPLv2+ and GPLv2 and MIT". OK. > It appears that some packages can be installed without the %license file > installed. Notably python-%{pkgname}-common, python-%{pkgname}-bash and > python-%{pkgname}-examples. OK. > Real rpmlint issues: > > python3-avocado.noarch: E: non-executable-script > /usr/lib/python3.9/site-packages/avocado/core/nrunner.py 644 /usr/bin/env > python3 > > python3-avocado.noarch: W: dangling-relative-symlink > /usr/share/doc/python3-avocado/README.rst docs/source/quickstart/index.rst > See yourself: > $ file /usr/share/doc/python3-avocado/README.rst > /usr/share/doc/python3-avocado/README.rst: broken symbolic link to > docs/source/quickstart/index.rst > > python-avocado.src: E: specfile-error warning: bogus date in %changelog: > Thu Feb 19 2021 Merlin Mathesius <mmathesi> - 82.0-2 OK. > Group tag is not supposed to be used: > Group: Development/Tools OK. > %{python_provide} SHOULD not be used. Remove it or replace with %py_provides > if appropriate. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_the_py_provides_macro OK. > The %check sections repeatedly runs `%{__python3} setup.py develop --user`. > This can backfire for builds outside of mock. Is does not appear to be > necessary. OK. > I also suggest to "hide" the section in the conditional, so it is not > present in build.log when built without tests. OK. > Some packages have duplicated and/or suspicious requires: > > python3-avocado: > ... > python3-pycdlib -> this is missing in upstream metadata, why is it > required? This one is still present. All the other manual requires on Python packages seem to be dropped. My question stands: Why is this required and not part of upstream metadata? > Suggestions: > ============ > > Switch to HTTPS URL: > URL: http://avocado-framework.github.io/ OK. > Update/remove old conditionals like: > %if 0%{?fedora} >= 30 || 0%{?rhel} > %if (0%{?fedora} && 0%{?fedora} < 29) || 0%{?rhel} OK. > Replace %{__make} with %make_build: > %{__make} man -> %make_build man OK. > Replace %{__python3} with %{python3}. OK. > Replace %{__rm}, %{__mv}, %{__ln_s}, %{__mkdir}, %{__cp} etc. with rm, mv, > ln -s, mkdir, cp etc. OK. > Opinionated suggestion: The spec file somewhat arbitrarily(?) uses > "avacado", "%{srcname}" and "%{pkgname}". I'd stick to "avocado" for better > readability, I don't expect the name of the project to be updated so often > to justify this complexity. OK. Generally, all concerns except python3-pycdlib were fixed (and that is not a blocker). I'm going to assume that no new problems were introduced. All the packages built in your copr are installable. Hence, APPROVED.
Thank you for circling back to this after your memory cache had long been flushed! :) > > Some packages have duplicated and/or suspicious requires: > > > > python3-avocado: > > ... > > python3-pycdlib -> this is missing in upstream metadata, why is it > > required? > > This one is still present. All the other manual requires on Python packages > seem to be dropped. > My question stands: Why is this required and not part of upstream metadata? Based on what I can tell from the upstream code, pycdlib is technically an optional requirement of avocado at runtime. (When avocado detects the presence of pycdlib, it enables extra capabilities that give it the ability to read and write ISO9660 images.) So, the spec file lists pycdlib as required in those environments where it is available. Thank you for the approval as well.
python-avocado-82.0-2.fc35 is now available in Fedora Rawhide. F34 and F33 releases have been created in Bodhi.