Bug 1932395 - Review Request: perl-CPAN-02Packages-Search - Search Perl modules in 02packages.details.txt
Summary: Review Request: perl-CPAN-02Packages-Search - Search Perl modules in 02packag...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1931967
TreeView+ depends on / blocked
 
Reported: 2021-02-24 14:55 UTC by Petr Pisar
Modified: 2021-03-03 15:12 UTC (History)
2 users (show)

Fixed In Version: perl-CPAN-02Packages-Search-0.001-1.fc35
Clone Of:
Environment:
Last Closed: 2021-03-03 15:12:36 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2021-02-24 14:55:55 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-CPAN-02Packages-Search/perl-CPAN-02Packages-Search.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-CPAN-02Packages-Search/perl-CPAN-02Packages-Search-0.001-1.fc35.src.rpm
Description:
CPAN::02Packages::Search allows you to search Perl modules in the de facto
standard CPAN index file 02packages.details.txt.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2021-03-03 11:05:15 UTC
+ perl Build.PL --installdirs=vendor
Can't locate Module/Build/Tiny.pm in @INC (you may need to install the Module::Build::Tiny module) (@INC contains: /usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at Build.PL line 6.


Module::Build::Tiny should be used instead of Module::Build

Comment 2 Petr Pisar 2021-03-03 11:21:19 UTC
Good catch. Now fixed and an updated package is on the same address.

Comment 3 Jitka Plesnikova 2021-03-03 11:43:46 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-CPAN-02Packages-Search-0.001-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(IO::Handle)
      1 perl(:MODULE_COMPAT_5.32.1) 
      1 perl(Search::Dict) >= 1.07
      1 perl(strict)
      1 perl(Tie::Handle::SkipHeader) >= 0.004
      1 perl(warnings)
$ rpm -qp --requires perl-CPAN-02Packages-Search-tests-0.001-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(CPAN::02Packages::Search)
      1 perl-CPAN-02Packages-Search = 0.001-1.fc35
      1 perl(strict)
      1 perl-Test-Harness
      1 perl(Test::More)
      1 perl(warnings)
      1 /usr/bin/perl
      1 /usr/bin/sh
Binary requires are Ok.

$ rpm -qp --provides perl-CPAN-02Packages-Search-0.001-1.fc35.noarch.rpm | sort | uniq -c
      1 perl(CPAN::02Packages::Search) = 0.001
      1 perl-CPAN-02Packages-Search = 0.001-1.fc35
$ rpm -qp --provides perl-CPAN-02Packages-Search-tests-0.001-1.fc35.noarch.rpm | sort | uniq -c
      1 perl-CPAN-02Packages-Search-tests = 0.001-1.fc35
Binary provides are Ok.

$ rpmlint ./perl-CPAN-02Packages-Search*
perl-CPAN-02Packages-Search.noarch: W: spelling-error Summary(en_US) txt -> text, ext, tit
perl-CPAN-02Packages-Search.noarch: W: spelling-error %description -l en_US de -> DE, ed, d
perl-CPAN-02Packages-Search.noarch: W: spelling-error %description -l en_US facto -> fact, factor, facts
perl-CPAN-02Packages-Search.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit
perl-CPAN-02Packages-Search.src: W: spelling-error Summary(en_US) txt -> text, ext, tit
perl-CPAN-02Packages-Search.src: W: spelling-error %description -l en_US de -> DE, ed, d
perl-CPAN-02Packages-Search.src: W: spelling-error %description -l en_US facto -> fact, factor, facts
perl-CPAN-02Packages-Search.src: W: spelling-error %description -l en_US txt -> text, ext, tit
perl-CPAN-02Packages-Search-tests.noarch: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 9 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 5 Tomas Hrcka 2021-03-03 13:52:20 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CPAN-02Packages-Search

Comment 6 Petr Pisar 2021-03-03 15:12:36 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.