Bug 1932619 - Alerts during a test run should fail the test job, but were not
Summary: Alerts during a test run should fail the test job, but were not
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Bare Metal Hardware Provisioning
Version: 4.8
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.7.z
Assignee: sdasu
QA Contact: Amit Ugol
Depends On: 1932618
Blocks: 1932620
TreeView+ depends on / blocked
Reported: 2021-02-24 19:12 UTC by Clayton Coleman
Modified: 2022-06-13 15:22 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1932618
: 1932620 (view as bug list)
Last Closed: 2022-06-13 15:22:17 UTC
Target Upstream Version:

Attachments (Terms of Use)

Description Clayton Coleman 2021-02-24 19:12:32 UTC
+++ This bug was initially created as a clone of Bug #1932618 +++

https://github.com/openshift/cluster-baremetal-operator/pull/110 merged containing a failing alert ClusterOperatorBaremetalDown and TargetDown.

This was the passing run https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-baremetal-operator/110/pull-ci-openshift-cluster-baremetal-operator-master-e2e-agnostic/1364398641615212544

The query in the alert test "shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured" is subtly wrong.

For 4.6, 4.7, and 4.8, we can remove the broken filter clause because both KubeAPILatencyHigh and KubePodCrashLooping on kcm namespace were fixed. In the future we must use "unless X" instead of joining with a "-" because of the way the series match.

After this fix we will be correctly enforcing "no alerts may fire during a CI test run".

Comment 1 W. Trevor King 2021-04-06 17:38:56 UTC
ClusterBaremetalOperatorDown was removed in [1].  Is that enough to close this bug WORKSFORME?

[1]: https://github.com/openshift/cluster-baremetal-operator/pull/111

Comment 7 Tomas Sedovic 2022-06-13 15:22:17 UTC
This has been fixed in OpenShift 4.8. I'm closing this BZ, if a backport to 4.7 is requested please reopen.

Note You need to log in before you can comment on or make changes to this bug.