Bug 1932736 - Review Request: bdftopcf - Font compiler for the X server and font server
Summary: Review Request: bdftopcf - Font compiler for the X server and font server
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1932731
TreeView+ depends on / blocked
 
Reported: 2021-02-25 05:24 UTC by Peter Hutterer
Modified: 2021-03-31 01:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-31 01:26:30 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Peter Hutterer 2021-02-25 05:24:01 UTC
Spec URL: https://people.freedesktop.org/~whot/bdftopcf/bdftopcf.spec
SRPM URL: https://people.freedesktop.org/~whot/bdftopcf/bdftopcf-1.1-1.fc35.src.rpm
Description: bdftopcf is a font compiler for the X server and font server.  Fonts in Portable Compiled Format can be read by any architecture, although
the file is structured to allow one particular architecture to read
them directly without reformatting.  This allows fast reading on the
appropriate machine, but the files are still portable (but read more
slowly) on other machines.

Fedora Account System Username: whot


Note that this is a package split as part of #1932731. This package used to be part of xorg-x11-font-utils and now becomes its own package.

It "Conflicts:  xorg-x11-font-utils < 7.5-51" which is to be committed once we're through with all this. xorg-x11-font-utils has had Provides: bdftopcf for years.

Comment 1 Parag AN(पराग) 2021-03-02 08:55:31 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Suggestions:
1) Add BuildRequirs: gcc

Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "FSF All Permissive License", "NTP
     License (legal disclaimer)", "NTP License (legal disclaimer)
     [generated file]", "FSF Unlimited License (with Retention) GNU General
     Public License v2.0 or later [generated file]", "GNU General Public
     License v2.0 or later [generated file]", "GNU General Public License
     v3.0 or later", "FSF Unlimited License [generated file]", "Expat
     License [generated file]", "[generated file]". 35 files have unknown
     license. Detailed output of licensecheck in
     /home/test/1932736-bdftopcf/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[-]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: bdftopcf-1.1-1.fc35.x86_64.rpm
          bdftopcf-debuginfo-1.1-1.fc35.x86_64.rpm
          bdftopcf-debugsource-1.1-1.fc35.x86_64.rpm
          bdftopcf-1.1-1.fc35.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (debuginfo)
-------------------
Checking: bdftopcf-debuginfo-1.1-1.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
3 packages and 0 specfiles checked; 0 errors, 0 warnings.



Source checksums
----------------
https://www.x.org/pub/individual/app/bdftopcf-1.1.tar.bz2 :
  CHECKSUM(SHA256) this package     : 4b4df05fc53f1e98993638d6f7e178d95b31745c4568cee407e167491fd311a2
  CHECKSUM(SHA256) upstream package : 4b4df05fc53f1e98993638d6f7e178d95b31745c4568cee407e167491fd311a2


Requires
--------
bdftopcf (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    rtld(GNU_HASH)

bdftopcf-debuginfo (rpmlib, GLIBC filtered):

bdftopcf-debugsource (rpmlib, GLIBC filtered):



Provides
--------
bdftopcf:
    bdftopcf
    bdftopcf(x86-64)

bdftopcf-debuginfo:
    bdftopcf-debuginfo
    bdftopcf-debuginfo(x86-64)
    debuginfo(build-id)

bdftopcf-debugsource:
    bdftopcf-debugsource
    bdftopcf-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1932736 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: fonts, Python, SugarActivity, Java, Perl, Haskell, PHP, Ocaml, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Tomas Hrcka 2021-03-03 13:27:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/bdftopcf

Comment 3 Fedora Update System 2021-03-05 00:08:07 UTC
FEDORA-2021-8cfc91c13a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

Comment 4 Fedora Update System 2021-03-05 17:20:05 UTC
FEDORA-2021-8cfc91c13a has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8cfc91c13a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2021-03-09 22:46:08 UTC
FEDORA-2021-8cfc91c13a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

Comment 6 Fedora Update System 2021-03-10 18:51:11 UTC
FEDORA-2021-8cfc91c13a has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8cfc91c13a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-03-12 06:21:54 UTC
FEDORA-2021-8cfc91c13a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

Comment 8 Fedora Update System 2021-03-12 18:54:46 UTC
FEDORA-2021-8cfc91c13a has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8cfc91c13a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8cfc91c13a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-03-19 20:03:46 UTC
FEDORA-2021-8cfc91c13a has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Parag AN(पराग) 2021-03-31 01:26:30 UTC
I think this bug should have been closed automatically.


Note You need to log in before you can comment on or make changes to this bug.