1933160 – When importing multiple ansible role variables in satellite that have the same variable name, they are silently overwritten.

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1933160 - When importing multiple ansible role variables in satellite that have the same variable name, they are silently overwritten.

Summary: When importing multiple ansible role variables in satellite that have the sam...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Satellite
Classification:	Red Hat
Component:	Ansible - Configuration Management
Sub Component:
Version:	6.6.0
Hardware:	x86_64
OS:	Linux
Priority:	high
Severity:	high
Target Milestone:	6.8.5
Assignee:	Ondřej Ezr
QA Contact:	Lukas Pramuk
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2021-02-25 20:29 UTC by James Jeffers
Modified:	2024-03-25 18:13 UTC (History)
CC List:	7 users (show)
Fixed In Version:	foreman_ansible-5.1.0
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:	1777293
Environment:
Last Closed:	2021-03-31 19:48:19 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Foreman Issue Tracker	28859	0	High	Closed	When importing multiple ansible role variables in satellite that have the same variable name, they are silently overwrit...	2021-02-25 20:30:12 UTC
Red Hat Product Errata	RHBA-2021:1057	0	None	None	None	2021-03-31 19:48:26 UTC

Comment 2 Lukas Pramuk 2021-03-11 12:28:29 UTC

VERIFIED.

@Satellite 6.8.5 Snap1
tfm-rubygem-foreman_ansible-5.1.3.2-1.el7sat.noarch

by the following reproducer:

1) Install any role from galaxy
# ansible-galaxy install -p /etc/ansible/roles adriagalin.motd

2) Import the role and its variables
# hammer ansible roles import --proxy-id 1
# hammer ansible variables import --proxy-id 1

3) Craft a role with duplicate variable names to be imported
# cp -r /etc/ansible/roles/adriagalin.motd /etc/ansible/roles/lpramuk.motd

4) Import the crafted role and its variables
# hammer ansible roles import --proxy-id 1
# hammer ansible variables import --proxy-id 1

5) Check the imported variables
# hammer ansible variables list --search ag_motd
----|-----------------------------|----------------------------------------------------------------------------------|---------|----------------
ID  | VARIABLE                    | DEFAULT VALUE                                                                    | TYPE    | ROLE           
----|-----------------------------|----------------------------------------------------------------------------------|---------|----------------
117 | ag_motd_add_footer          | false                                                                            | boolean | adriagalin.motd
163 | ag_motd_add_footer          | false                                                                            | boolean | lpramuk.motd   
167 | ag_motd_content             |                                                                                  | string  | lpramuk.motd   
121 | ag_motd_content             |                                                                                  | string  | adriagalin.motd
166 | ag_motd_info                | [{" FQDN:    "=>"{{ ansible_fqdn }}"}, {" Distro:  "=>"{{ ansible_distributio... | array   | lpramuk.motd   
120 | ag_motd_info                | [{"FQDN: "=>"{{ ansible_fqdn }}"}, {"  OS: "=>"{{ ansible_distribution }}"}]     | array   | adriagalin.motd
119 | ag_motd_sysadmins_email     | random                                                                | string  | adriagalin.motd
165 | ag_motd_sysadmins_email     | random                                                                | string  | lpramuk.motd   
118 | ag_motd_sysadmins_signature | Random system administrators                                                     | string  | adriagalin.motd
164 | ag_motd_sysadmins_signature | Random system administrators                                                     | string  | lpramuk.motd   
----|-----------------------------|----------------------------------------------------------------------------------|---------|----------------

>>> every variable is listed twice, one variable per each role -> duplicate variables in different roles are no longer overwritten

Comment 7 errata-xmlrpc 2021-03-31 19:48:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.8.5 Async Bug Fix Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1057

Note You need to log in before you can comment on or make changes to this bug.