Bug 1933533 - Require mkfontdir directly, not xorg-x11-font-utils
Summary: Require mkfontdir directly, not xorg-x11-font-utils
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: nethack
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ron Olson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1932731
TreeView+ depends on / blocked
 
Reported: 2021-03-01 01:20 UTC by Peter Hutterer
Modified: 2021-03-08 07:15 UTC (History)
3 users (show)

Fixed In Version: nethack-3.6.6-4.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-04 23:06:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Hutterer 2021-03-01 01:20:24 UTC
nethack currently Requires(post): xorg-x11-font-utils

xorg-x11-font-utils is to be split up into multiple packages, see Bug 1932731. 

nethack only requires mkfontdir during %post, so let's Require this directly. xorg-x11-font-utils has had Provides mkfontdir for ages now anyway, so this is largely a noop from nethack's POV.

Suggested diff:


diff --git a/nethack.spec b/nethack.spec
index a470636..4562b41 100644
--- a/nethack.spec
+++ b/nethack.spec
@@ -58,7 +58,7 @@ Summary:         X11 core fonts configuration for %{fontname}
 BuildArch:      noarch
 Requires:        %{fontname}-fonts
 Requires(post):  %{fontname}-fonts
-Requires(post):  xorg-x11-font-utils
+Requires(post):  mkfontdir
 Requires(post):         coreutils
 Requires(preun): coreutils

Comment 1 Peter Hutterer 2021-03-04 23:06:30 UTC
nethack-3.6.6-4.fc35 has the fix, except that it's FTBFS in rawhide right now for unrelated reasons, the same build succeeds on F34 though.

https://koji.fedoraproject.org/koji/taskinfo?taskID=63100570

In file included from /usr/include/features.h:484,
                 from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/stdio.h:27,
                 from ../include/global.h:9,
                 from ../include/config.h:581,
                 from monst.c:6:
/usr/include/sys/cdefs.h:335:73: error: macro "__has_attribute" requires an identifier
  335 | #if __GNUC_PREREQ (3,4) || __glibc_has_attribute (__warn_unused_result__)
      |                                                                         ^

Comment 2 Ron Olson 2021-03-05 01:52:37 UTC
Yes I'm aware of the Rawhide issue; it's related to glibc and I'm working on it and will merge in the xorg changes

Comment 3 Peter Hutterer 2021-03-08 07:15:10 UTC
thanks, much appreciated


Note You need to log in before you can comment on or make changes to this bug.