Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-1.fc35.src.rpm Description: LibCST parses Python source code as a CST tree that keeps all formatting details (comments, whitespaces, parentheses, etc). It's useful for building automated refactoring (codemod) applications and linters. LibCST creates a compromise between an Abstract Syntax Tree (AST) and a traditional Concrete Syntax Tree (CST). By carefully reorganizing and naming node types and fields, it creates a lossless CST that looks and feels like an AST. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=62947378
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - License is not just MIT. See LICENSE file. The overall license should be MIT and (MIT and Python) and ASL 2.0. You must then add a comment above the License field explaining the multiple licensing breakdown. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios. Since the upstream LICENSE file actually does this (first time I’ve ever seen that!) you could just reference it, or copy the relevant section. - It would be nice (but not mandatory) to build the docs in a -doc subpackage. The PyPI tarball is missing some of the documentation build files, but I think you could do it if you switched to the GitHub tarball. - For the tests you remove due to missing dependencies, I think you should note which tests are removed for which dependencies, so there is a chance of adding them back if the dependencies become available in the future. In some cases, like test_codemod_cli.py, it is not obvious that there really is a dependency problem. - In general, when you remove or disable a test, it would be nice to have a rationale. Something like “See upstream bug https://example.com/issues/1000000” or “This test requires Internet access” or at least “I tried foo and bar but I can’t report this upstream unless I figure out baz”. This makes it much more likely that tests will be added back in when they are no longer broken. For example, the failure in test_codegen_clean.py is https://github.com/Instagram/LibCST/issues/304. Some of the others are discussed in https://github.com/Instagram/LibCST/issues/331. Another is https://github.com/Instagram/LibCST/issues/305. - Testing by “setup.py test” is deprecated, and a message is printed to that effect. Consider %{__python3} -m unittest -v instead. Or add a BR on pytest, and use the %pytest macro. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Expat License", "Expat License Apache License 2.0", "Expat License", "Expat License [generated file]". 31 files have unknown license. Detailed output of licensecheck in /home/reviewer/1934194-python-libcst/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-libcst-0.3.17-1.fc35.noarch.rpm python-libcst-0.3.17-1.fc35.src.rpm python3-libcst.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python3-libcst.noarch: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python3-libcst.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters python-libcst.src: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python-libcst.src: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python-libcst.src: W: spelling-error %description -l en_US codemod -> code mod, code-mod, commode python-libcst.src: W: spelling-error %description -l en_US linters -> liners, liters, inters 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- python3-libcst.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python3-libcst.noarch: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python3-libcst.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/l/libcst/libcst-0.3.17.tar.gz : CHECKSUM(SHA256) this package : 2766671c107263daa3fc34e39d55134a6fe253701564d7670586f30eee2c201c CHECKSUM(SHA256) upstream package : 2766671c107263daa3fc34e39d55134a6fe253701564d7670586f30eee2c201c Requires -------- python3-libcst (rpmlib, GLIBC filtered): python(abi) python3.9dist(pyyaml) python3.9dist(typing-extensions) python3.9dist(typing-inspect) Provides -------- python3-libcst: python-libcst python3-libcst python3.9-libcst python3.9dist(libcst) python3dist(libcst) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1934194 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Ruby, Perl, PHP, SugarActivity, fonts, C/C++, Haskell, R, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-2.fc35.src.rpm Changelog: - Fix license - Switch to GitHub tarball - Add docs build (disabled by default) - Switch to pytest and document ignored tests
Thanks. I’m getting a 404 error on the SRPM URL, though. You can fix intersphinx trying to go to the Internet by the following, in %prep: # Use local intersphinx inventory sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \ docs/source/conf.py while adding BuildRequires: python3-docs and, to the -doc subpackage: Requires: python3-docs
Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-3.fc35.src.rpm Changelog: - Fix docs build and enable it by default
The SRPM should be fixed, sorry about that. Note that even with the intersphinx fix you suggested I still get: loading intersphinx inventory from file://usr/share/doc/python3-docs/html/objects.inv... WARNING: failed to reach any of the inventories with the following issues: intersphinx inventory 'file://usr/share/doc/python3-docs/html/objects.inv' not fetchable due to <class 'requests.exceptions.InvalidSchema'>: No connection adapters were found for 'file://usr/share/doc/python3-docs/html/objects.inv' I also tried adding changing this to file:// but that doesn't seem to make a difference. However, this doesn't break the build and I do get what looks like a valid -doc package in the end.
> Note that even with the intersphinx fix you suggested I still get: … Hmm, you’re right. It looks like intersphinx does not like file:// URIs, but it does accept plain old paths (https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping). That should have been: # Use local intersphinx inventory sed -r -i 's|https://docs.python.org/3|file:/%{_docdir}/python3-docs/html|' \ docs/source/conf.py I had to fix this on my own package too: https://bugzilla.redhat.com/show_bug.cgi?id=1934257 ---- %if 0%{?fedora} < 33 || 0%{?rhel} < 9 is not correct; either %fedora or %rhel is undefined, so either 0%{?fedora} is 0, which is less than 33, or 0%{?rhel} is 0, which is less than 9. So it always evaluates true. If this came from pyp2rpm, then it is a bug in pyp2rpm. If you are not building for EPEL, you can just check if 0%{?fedora} == 32. ---- I’m getting - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies which I though was a false positive, triggered by the documentation package %package -n python-%{pypi_name}-doc It would be much more conventional to write that as %package doc which, with python-%{pypi_name} as the base name, would still give you the same subpackage name. I tested it with that change and still had the complaint, though. I’m getting Requires -------- python3-libcst (rpmlib, GLIBC filtered): python(abi) python3.9dist(pyyaml) python3.9dist(typing-extensions) python3.9dist(typing-inspect) Provides -------- python3-libcst: python-libcst python3-libcst python3.9-libcst python3.9dist(libcst) python3dist(libcst) so something is going on that has nothing to do with the documentation. I’ll post a full review after I figure out what the problem is.
Spec URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-libcst/python-libcst-0.3.17-4.fc35.src.rpm Changelog: - Fix intersphinx inventory path - Fix %%py_provides gating
Thanks, looks good. Approved. Re-review below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies The spec file looks fine, and the Requires and Provides look similar to other Python packages. I am going to consider this a false positive. I think it might be due to the indirect dependency, via python3-metakernel-python, on python-jupyter-filesystem, which sounds like an unversioned Python package even though it is not. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Expat License", "Expat License Apache License 2.0", "Expat License", "Expat License [generated file]". 68 files have unknown license. Detailed output of licensecheck in /home/reviewer/1934194-python- libcst/20210304/1934194-python-libcst/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-libcst [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-libcst-0.3.17-4.fc35.noarch.rpm python-libcst-doc-0.3.17-4.fc35.noarch.rpm python-libcst-0.3.17-4.fc35.src.rpm python3-libcst.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python3-libcst.noarch: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python3-libcst.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters python-libcst-doc.noarch: W: summary-not-capitalized C python-libcst documentation python-libcst.src: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python-libcst.src: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python-libcst.src: W: spelling-error %description -l en_US codemod -> code mod, code-mod, commode python-libcst.src: W: spelling-error %description -l en_US linters -> liners, liters, inters 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- python-libcst-doc.noarch: W: summary-not-capitalized C python-libcst documentation python3-libcst.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces python3-libcst.noarch: W: spelling-error %description -l en_US refactoring -> re factoring, re-factoring, factorizing python3-libcst.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Source checksums ---------------- https://github.com/Instagram/LibCST/archive/v0.3.17.tar.gz#/LibCST-0.3.17.tar.gz : CHECKSUM(SHA256) this package : 830d6f8a9db4401ebb31e82a8f253c4d36d27f2ca0784ad21d19f5d6fe07eb8f CHECKSUM(SHA256) upstream package : 830d6f8a9db4401ebb31e82a8f253c4d36d27f2ca0784ad21d19f5d6fe07eb8f Requires -------- python3-libcst (rpmlib, GLIBC filtered): python(abi) python3.9dist(pyyaml) python3.9dist(typing-extensions) python3.9dist(typing-inspect) python-libcst-doc (rpmlib, GLIBC filtered): python3-docs Provides -------- python3-libcst: python-libcst python3-libcst python3.9-libcst python3.9dist(libcst) python3dist(libcst) python-libcst-doc: python-libcst-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1934194 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: C/C++, Perl, Ruby, Ocaml, R, Haskell, SugarActivity, fonts, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks! $ fedpkg request-repo python-libcst 1934194 https://pagure.io/releng/fedora-scm-requests/issue/32536
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-libcst
FEDORA-2021-23c3fbaa92 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-23c3fbaa92
FEDORA-2021-5c110d37ae has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5c110d37ae
FEDORA-2021-8f3008f667 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f3008f667
FEDORA-2021-8f3008f667 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8f3008f667 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f3008f667 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-5c110d37ae has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-5c110d37ae \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5c110d37ae See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-23c3fbaa92 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-23c3fbaa92 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-23c3fbaa92 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-8f3008f667 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-5c110d37ae has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-23c3fbaa92 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.