Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1934617

Summary: [RFE] better MPTCP dissection support
Product: Red Hat Enterprise Linux 8 Reporter: Paolo Abeni <pabeni>
Component: wiresharkAssignee: Michal Ruprich <mruprich>
Status: CLOSED ERRATA QA Contact: FrantiĊĦek Hrdina <fhrdina>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.4CC: psklenar
Target Milestone: rcKeywords: AutoVerified, FutureFeature, Patch, Reproducer, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: wireshark-2.6.2-13.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 17:57:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sample capture for MPC, MPJ, ADD_ADDR v1
none
Patch none

Description Paolo Abeni 2021-03-03 15:10:50 UTC 
the MPTCP dissector inside wireshark a bit outdated. Notably does not parse correctly MPTCP v1, including MPC, ADD_ADDR and MPJ sub-options.

The relevant functionalities are implemented by the following upstream commits:

7844e267ec mptcp: fix relative DSN/ACK for additional v1 subflows.
1455b6e82d MPTCP: Fix false Duplicate ACKs
e38e412239 MPTCP: Correct Apply as column for the subflows field
22e617d862 mptcp: correctly parse v1 ADD_ADDR suboption
1b11115ca7 mptcp: add support for sha256 hashing.
59ab98a894 mptcp: correctly parse v1 MP_CAPABLE handshake
dac91db65e mptcp: Correctly find mappings and reinjections

which in turn could have additionally dependency on tcp/core dissection features (unverified).
Comment 2 Paolo Abeni 2021-03-08 11:31:04 UTC 
Created attachment 1761570 [details]
sample capture for MPC, MPJ, ADD_ADDR v1

this sample comprises hopefully all the v1-related MPTCP packets:

- MPC handshake v1, pkts 1-4
- ADD_ADDR pkt 5
- ADD_ADDR echo pkt 7
- MPJ handshake, pkts 6,8,9,10
Comment 3 Michal Ruprich 2021-03-22 12:55:19 UTC 
Created attachment 1765239 [details]
Patch
Comment 4 Michal Ruprich 2021-03-22 12:59:21 UTC 
I created a combined patch including all suggested commits from description. The changes look good to me, 99% are only relevant to mptcp functions. The output looks good as well.

Example packate before the change:
Multipath Transmission Control Protocol: Multipath Capable
            Kind: Multipath TCP (30)
            Length: 22
            0000 .... = Multipath TCP subtype: Multipath Capable (0)
            .... 0001 = Multipath TCP version: 1
            Multipath TCP flags: 0x01
                0... .... = Checksum required: 0
                .0.. .... = Extensibility: 0
                .... ...1 = Use HMAC-SHA1: 1
                ..00 000. = Reserved: 0x00

The same packet after the change: 
Multipath Transmission Control Protocol: Multipath Capable
            Kind: Multipath TCP (30)
            Length: 22
            0000 .... = Multipath TCP subtype: Multipath Capable (0)
            .... 0001 = Multipath TCP version: 1
            Multipath TCP flags: 0x01
                0... .... = Checksum required: 0
                .0.. .... = Extensibility: 0
                .... ...1 = Use HMAC-SHA256: 1
                ..00 000. = Reserved: 0x00
            Sender's Key: 11510643367401483219
            [Subflow token generated from key: 695886422]
            [Subflow expected IDSN: 18143676336154259040 (64bits version)]
            Receiver's Key: 144115188075855872
            Data-level Length: 2
Comment 14 errata-xmlrpc 2021-11-09 17:57:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (wireshark bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4190