Red Hat Bugzilla – Bug 193470
Review Request: renrot - A program to rename and rotate files according to EXIF tags
Last modified: 2007-11-30 17:11:34 EST
Spec URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/renrot.spec SRPM URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/renrot-0.19.3-1.src.rpm Description: Renrot renames files according the DateTimeOriginal and FileModifyDate EXIF tags, if they exist. Otherwise, the name will be set according to the current timestamp. Additionally, it rotates files and their thumbnails, accordingly Orientation EXIF tag. The script can also put commentary into the Commentary and UserComment tags. Personal details can be specified via XMP tags defined in a configuration file.
It will be good it you specify what changes you made from version to version release in SPEC file'c Chnagelog
Why? The spec's changelog is related to spec changes and so on. I think, if you should like to get changes list of project you should read the project's inside documentation such ChangeLog or NEWS files, isn't it? (Look to wine package for example) Updated version here: SRPM URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/renrot-0.20-1.src. rpm
rpmlint complains: E: renrot non-standard-executable-perm /usr/bin/renrot 0555 Should be 755. The only other issue is minor; BuildRequires: perl is not required. This is not a blocker. Since the only real issue is fixed up by a quick chmod, I'll go ahead and approve this and you can fix it when you check in. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: b3261caa8ed7a6c87add693310feb9b9 renrot-0.20.tar.gz b3261caa8ed7a6c87add693310feb9b9 renrot-0.20.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper (BR: perl is redundant) * package builds in mock (development, x86_64). X rpmlint complains about mode 555 file. * final provides and requires are sane: config(renrot) = 0.20-1.fc6 renrot = 0.20-1.fc6 - /usr/bin/perl config(renrot) = 0.20-1.fc6 libjpeg >= 6b perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Getopt::Long) perl(Image::ExifTool) perl(Time::Local) perl(Time::localtime) perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, provided you fix the permissions on /usr/bin/renrot.
Updated version here: SRPM URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/renrot-0.20-2.src. rpm
Everything looks good; check in whenever you like.
Thank you for review.