This is my first package and I am seeking a sponsor. * Spec URL: https://raw.githubusercontent.com/msoodb/fdesc/master/fdesc.spec * SRPM URL: https://raw.githubusercontent.com/msoodb/fdesc/master/SRPM/fdesc-0-1.fc32.src.rpm * Description: CLI tools to generate fake description (https://github.com/msoodb/fdesc). * Fedora Account System Username: msoodb This package is also hosted in COPR with successful build on F32, F33, F34, Rawhide. * https://copr.fedorainfracloud.org/coprs/msoodb/fdesc * https://koji.fedoraproject.org/koji/taskinfo?taskID=63274895
- You can use %set_build_flags instead of: export CFLAGS="%{optflags}" export LDFLAGS="%{__global_ldflags}" - You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged: %global commit 57bc98c139d13f1f79404c72445193e8fcdfcc60 %global snapshotdate 20210316 %global shortcommit %(c=%{commit}; echo ${c:0:7}) […] Release: 0.1%{snapshotdate}git%{shortcommit}%{?dist} […] Source0: %url/archive/%{commit}/%{name}-%{shortcommit}.tar.gz […] %autosetup -n %{name}-%{commit} […] * Wed Mar 3 2021 msoodb <masoud.bolhassani> - 0-0.1.20210316git57bc98c - Release should start at 0.1 for a prerelease - Remove trailing spaces
>> You can use %set_build_flags instead of: DONE. >> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged: I don't get the point. I should dread more about packaging. The document I followed doesn't mention it.
(In reply to masoud bolhassani from comment #2) > > >> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged: > I don't get the point. I should dread more about packaging. The document I > followed doesn't mention it. The Master tip of the Github repo is not stable, every new commit will change it and with it the archive you point to, you need to package a specific commit that won't change.
(In reply to Robert-André Mauchin 🐧 from comment #3) > (In reply to masoud bolhassani from comment #2) > > > > >> You can't use master for the archive as it will change with new commit. You should instead define the commit you want packaged: > > I don't get the point. I should dread more about packaging. The document I > > followed doesn't mention it. > > The Master tip of the Github repo is not stable, every new commit will > change it and with it the archive you point to, you need to package a > specific commit that won't change. Disregard, I've noticed that you point to an archive in your Git repo. You should probably not do that and instead use Git to tag new releases instead of uploading archive. You shouldn't upload the SRPM here either, binary content do not play well with GIT.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.