Spec URL: https://atim.fedorapeople.org/labwc.spec SRPM URL: https://atim.fedorapeople.org/labwc-0.1.0-1.fc33.src.rpm Description: Labwc is a wlroots-based stacking compositor for Wayland. It has the following aims: - Be light-weight, small and fast - Have the look and feel of openbox albeit with a smaller feature set - Where practicable, use clients to show wall-paper, take screenshots, and so on - Stay in keeping with wlroots and sway in terms of approach and coding style Fedora Account System Username: atim
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=63255215
I will review this package.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: labwc-0.1.0-1.fc35.x86_64.rpm labwc-debuginfo-0.1.0-1.fc35.x86_64.rpm labwc-debugsource-0.1.0-1.fc35.x86_64.rpm labwc-0.1.0-1.fc35.src.rpm labwc.x86_64: W: spelling-error Summary(en_US) Openbox -> Open box, Open-box, Opened labwc.x86_64: W: spelling-error %description -l en_US wlroots -> roots labwc.x86_64: W: spelling-error %description -l en_US openbox -> open box, open-box, opened labwc.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/labwc labwc.src: W: spelling-error Summary(en_US) Openbox -> Open box, Open-box, Opened labwc.src: W: spelling-error %description -l en_US wlroots -> roots labwc.src: W: spelling-error %description -l en_US openbox -> open box, open-box, opened 4 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: labwc-debuginfo-0.1.0-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- labwc.x86_64: W: spelling-error Summary(en_US) Openbox -> Open box, Open-box, Opened labwc.x86_64: W: spelling-error %description -l en_US wlroots -> roots labwc.x86_64: W: spelling-error %description -l en_US openbox -> open box, open-box, opened labwc.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/labwc 3 packages and 0 specfiles checked; 1 errors, 3 warnings. Source checksums ---------------- https://github.com/johanmalm/labwc/archive/0.1.0/labwc-0.1.0.tar.gz : CHECKSUM(SHA256) this package : c3087c0dc846c18499a335fe04c9bc46f014f7421739573636f6f8f746fd3c84 CHECKSUM(SHA256) upstream package : c3087c0dc846c18499a335fe04c9bc46f014f7421739573636f6f8f746fd3c84 Requires -------- labwc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libinput.so.10()(64bit) libinput.so.10(LIBINPUT_0.12.0)(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpixman-1.so.0()(64bit) libwayland-server.so.0()(64bit) libwlroots.so.7()(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) labwc-debuginfo (rpmlib, GLIBC filtered): labwc-debugsource (rpmlib, GLIBC filtered): Provides -------- labwc: labwc labwc(x86-64) labwc-debuginfo: debuginfo(build-id) labwc-debuginfo labwc-debuginfo(x86-64) labwc-debugsource: labwc-debugsource labwc-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1936172 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, fonts, Python, Haskell, SugarActivity, Perl, Java, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> E: missing-call-to-setgroups-before-setuid /usr/bin/labwc https://github.com/johanmalm/labwc/issues/22
> E: missing-call-to-setgroups-before-setuid /usr/bin/labwc sway.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/sway 1. Swap package has such issue too. 2. Please ask upstream to include desktop- and appdata- files. > License: GPLv2 License: GPLv2 and BSD. All other LGTM. These minor issues can be fixed during import. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/labwc
FEDORA-2021-e0d7b1a198 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e0d7b1a198
FEDORA-2021-e0d7b1a198 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.