Spec URL: https://rmattes.fedorapeople.org/RPMS/ignition-fuel-tools/ignition-fuel-tools.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/ignition-fuel-tools/ignition-fuel-tools-4.3.0-1.fc33.src.rpm Description: Ignition Fuel Tools is composed by a client library and command line tools for interacting with Ignition Fuel servers. Fedora Account System Username: rmattes rpmlint: $ rpmlint ignition-fuel-tools.spec ../SRPMS/ignition-fuel-tools-4.3.0-1.fc33.src.rpm ignition-fuel-tools.spec:70: E: hardcoded-library-path in %{_prefix}/lib/ruby ignition-fuel-tools.src:70: E: hardcoded-library-path in %{_prefix}/lib/ruby 1 packages and 1 specfiles checked; 2 errors, 0 warnings. Hard-coded path needed to remove un-needed installed ruby artifacts Builds can be found on copr - dependencies are too old in rawhide: https://copr.fedorainfracloud.org/coprs/g/robotics-sig/gazebo-latest/package/ignition-fuel-tools/
Could you bump to version 7 and needinfo me for a review?
Thanks for the ping. I left it at version 4 because gazebo 11 has a hard version dep on this package: https://github.com/osrf/gazebo/blob/gazebo11/cmake/SearchForStuff.cmake#L802 There has beena 4.4 release though, I'll update the spec/srpm.
Thank you
OK, I got the the updates built in copr: Spec URL: https://rmattes.fedorapeople.org/RPMS/ignition-fuel-tools/ignition-fuel-tools.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/ignition-fuel-tools/ignition-fuel-tools-4.4.0-1.fc35.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/g/robotics-sig/gazebo-latest/build/3253694/ rpmlint: $ rpmlint ignition-fuel-tools.spec ../SRPMS/ignition-fuel-tools-4.4.0-1.fc35.src.rpm /var/lib/mock/fedora-rawhide-gazebo-latest/result/ignition-fuel-tools{,-devel}-4.4.0-1.fc36.x86_64.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 ignition-fuel-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ignition-fuel-tools/README.md ignition-fuel-tools-devel.x86_64: W: no-documentation ignition-fuel-tools-devel.x86_64: W: files-duplicate /usr/lib64/cmake/ignition-fuel_tools4/ignition-fuel_tools4-config-version.cmake /usr/lib64/cmake/ignition-fuel_tools4-all/ignition-fuel_tools4-all-config-version.cmake ==================================================== 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 1.6 s ====================================================
- Fix the line encoding ignition-fuel-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ignition-fuel-tools/README.md Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 3-Clause License", "BSD 3-Clause License [generated file]". 50 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ignition-fuel-tools/review- ignition-fuel-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/ignition(ignition-math-devel, ignition-msgs-devel, ignition-transport-devel), /usr/share/ignition(ignition-validate- redistributable, ignition-cmake-devel, ignition-transport, ignition- msgs) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ignition-fuel-tools-4.4.0-1.fc37.x86_64.rpm ignition-fuel-tools-devel-4.4.0-1.fc37.x86_64.rpm ignition-fuel-tools-doc-4.4.0-1.fc37.noarch.rpm ignition-fuel-tools-debuginfo-4.4.0-1.fc37.x86_64.rpm ignition-fuel-tools-debugsource-4.4.0-1.fc37.x86_64.rpm ignition-fuel-tools-4.4.0-1.fc37.src.rpm ================================================================ rpmlint session starts =============================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 7 ignition-fuel-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ignition-fuel-tools/README.md ignition-fuel-tools.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ignition-fuel-tools/README.md ignition-fuel-tools-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libignition-fuel_tools4.so.4.4.0-4.4.0-1.fc37.x86_64.debug ignition-fuel-tools-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libignition-fuel_tools4.so.4.4.0-4.4.0-1.fc37.x86_64.debug ignition-fuel-tools-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/libignition-fuel_tools4.so.4.4.0-4.4.0-1.fc37.x86_64.debug ignition-fuel-tools-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/libignition-fuel_tools4.so.4.4.0-4.4.0-1.fc37.x86_64.debug ignition-fuel-tools-debuginfo.x86_64: W: no-documentation ignition-fuel-tools-debugsource.x86_64: W: no-documentation ignition-fuel-tools-devel.x86_64: W: no-documentation ignition-fuel-tools-debuginfo.x86_64: W: no-documentation ignition-fuel-tools-debugsource.x86_64: W: no-documentation ignition-fuel-tools-devel.x86_64: W: no-documentation ignition-fuel-tools.src: E: multiple-specfiles ignition-fuel-tools.spec ignition-fuel-tools.spec ignition-fuel-tools-devel.x86_64: W: files-duplicate /usr/lib64/cmake/ignition-fuel_tools4/ignition-fuel_tools4-config-version.cmake /usr/lib64/cmake/ignition-fuel_tools4-all/ignition-fuel_tools4-all-config-version.cmake ignition-fuel-tools-doc.noarch: W: files-duplicate /usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_vars.html /usr/share/doc/ignition-fuel-tools-doc/html/functions_enum.html:/usr/share/doc/ignition-fuel-tools-doc/html/functions_eval.html:/usr/share/doc/ignition-fuel-tools-doc/html/functions_type.html:/usr/share/doc/ignition-fuel-tools-doc/html/hierarchy.html:/usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_eval.html:/usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_type.html ignition-fuel-tools-devel.x86_64: W: files-duplicate /usr/lib64/cmake/ignition-fuel_tools4/ignition-fuel_tools4-config-version.cmake /usr/lib64/cmake/ignition-fuel_tools4-all/ignition-fuel_tools4-all-config-version.cmake ignition-fuel-tools-doc.noarch: W: files-duplicate /usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_vars.html /usr/share/doc/ignition-fuel-tools-doc/html/functions_enum.html:/usr/share/doc/ignition-fuel-tools-doc/html/functions_eval.html:/usr/share/doc/ignition-fuel-tools-doc/html/functions_type.html:/usr/share/doc/ignition-fuel-tools-doc/html/hierarchy.html:/usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_eval.html:/usr/share/doc/ignition-fuel-tools-doc/html/namespacemembers_type.html ignition-fuel-tools-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c3/94c69092e880c982273b056ce7dce6dad5a220 ../../../.build-id/c3/94c69092e880c982273b056ce7dce6dad5a220 ignition-fuel-tools-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/c3/94c69092e880c982273b056ce7dce6dad5a220 ../../../.build-id/c3/94c69092e880c982273b056ce7dce6dad5a220 ================================ 12 packages and 1 specfiles checked; 3 errors, 16 warnings, 3 badness; has taken 6.1 s ===============================
Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ignition-fuel-tools
This package was never imported despite being approved and the repository created. Are you willing to finalize the process?
I am, but I can't import and build this package without updating some other packages, and that's blocked by the ignition-common review request at #1936727. I'll try to get that review moving.