Bug 1936872
| Summary: | satellite-maintain upgrade check does not compare enabled repos for satellite or capsule with installed packages | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Stefan Nemeth <snemeth> |
| Component: | Satellite Maintain | Assignee: | satellite6-bugs <satellite6-bugs> |
| Status: | CLOSED WONTFIX | QA Contact: | Griffin Sullivan <gsulliva> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.8.0 | CC: | apatel, aupadhye, ehelms, ekohlvan, jangerrit.kootstra, jpathan, kgaikwad |
| Target Milestone: | Unspecified | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-03-28 19:36:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1957813 | ||
|
Description
Stefan Nemeth
2021-03-09 11:45:58 UTC
Encounter this bug when trying to upgrade a capsule from 6.8.6 to 6.9.2 Hello, The satellite-maintain enables the repository as per the name of the package(satellite/capsule) before doing the upgrade, and repository-validate checks if required repositories are available on system or not, https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/concerns/downstream.rb#L95 To avoid the situation where installed system as per scenario does not match with package(satellite/capsule) there is 'validate_downstream_packages' https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/concerns/primary_checks.rb and its being called already prior to doing any pre_upgrade_checks, https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/cli/upgrade_command.rb#L71 https://github.com/theforeman/foreman_maintain/blob/master/lib/foreman_maintain/cli/upgrade_command.rb#L91 Considering satellite-maintain won't fall in situation where it will let the upgrade complete with invalid repository, I think this bugzilla should be closed? _ Amit Upadhye. Hi Amit, Please explain how this early stage check works, for it has failed in our situation once for a capsule where by accident some former colleague had activated a satellite repo on a capsule and the pre check did not give a warning or error message to fix this issue. So we got a mix of capsule and satellite server packages on the machine. This broke the capsule. I ask you not to close the bugzilla, until it is clear the issue described in this bugzilla is fixed. Regards, Jan Gerrit Kootstra This was reported on an older version where we have since put in more control over the repositories being enabled. Additionally, this check doesn't help for disconnected, given this I am opting to close. Hi Eric, This was reported for a connected Satellite 6.9 on RHEL 7, with Capsules 6.9 on RHEL 7 registered to the Satellite. Still like you mention, it is a very old case that we have not encountered since Satellite 6.9 and we are running Satellite 6.14 on RHEL 8. I am ok with a closure. Regards, Jan Gerrit The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days |