Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1937027

Summary: Support version 1.1 of the OCF Resource Agent API standard
Product: Red Hat Enterprise Linux 8 Reporter: Ken Gaillot <kgaillot>
Component: resource-agents-sap-hanaAssignee: Janine Fuchs <jfuchs>
Status: CLOSED DUPLICATE QA Contact: Amir Memon <amemon>
Severity: high Docs Contact:
Priority: unspecified    
Version: 8.5CC: cfeist, fdanapfe, mmoster, oalbrigt
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.5   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-25 07:39:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ken Gaillot 2021-03-09 17:26:43 UTC 
This bug was initially created as a copy of Bug #1936696

I am copying this bug because: All resource agents will need to support OCF 1.1 in RHEL 9.0; supporting a subset is optional in RHEL 8



The upstream ClusterLabs community is preparing to release version 1.1 of the OCF Resource Agent API standard, which will include a number of new features and clarifications compared to the previous version.

The RHEL High-Availability components will need to support this for RHEL 9.0, and a subset of support could be added as of 8.5 (any of the things mentioned as optional below).

Some key aspects that might require changes (agents refers to all OCF agents whether supplied by resource-agents, pacemaker, or some other package) are listed below. Some of these might warrant (or already have) their own BZs.

* The version number changes to 1.1
** In RHEL 9, agent meta-data should advertise 1.1 support. In RHEL 8, agents that use the old role names should continue to advertise 1.0 support, while agents that don't use role names could (but don't have to) advertise 1.1 support.
** pacemaker should set the OCF_RA_VERSION_MINOR environment variable to 1 instead of 0 in RHEL 9 and optionally 8

* The role names are now "promoted" and "unpromoted" instead of "Master" and "Slave".
** pacemaker should use the new names in help, logs, and output in 9 but not 8. In 9 and optionally 8, all names should be supported in user configurations; the crm_resource --master option should be renamed to --promoted, with the old option accepted for backward compatibility; the crm_master command should be renamed to pcmk_promotion, with the old name symlinked for backward compatibility; and relevant clone notification environment variables (OCF_RESKEY_CRM_meta_notify_master_resource etc.) should be provided with both the old and new names.
** Agents should use the new names in meta-data, help, etc., in 9 but not 8. Agents should use the new crm_resource --promoted option, crm_promotion command, and clone notification variables names in 9 and optionally 8 if supported by pacemaker. If agents parse pacemaker output for role names, they should look for either set of names in 9 and optionally 8.
** pcs should support all names in user input in 9 and optionally 8. The new names should be used in help and output in 9 but not 8. Any commands, options, etc., named after the old names should be renamed to the new ones with the old ones accepted for backward compatibility, in 9 and optionally 8.
** Note: promotion score node attribute names (master-*) are not part of the standard and are not changing at this time. However, anything outside pacemaker should use the crm_master or crm_promotion command instead of dealing with these attributes directly.

* The "unique" agent meta-data field has been deprecated in favor of two new fields, "unique-group" and "reloadable". Agents that support "reloadable" should support the new "reload-params" action.
** Pacemaker should support reloadable if present, otherwise unique if present, and support the reload-params action if present, otherwise reload if present, in 9 and optionally 8.
** Agents should provide both the old and new meta-data names, and the reload-params action if appropriate, in 9 and optionally 8.

* A number of new agent meta-data fields ("required", "deprecated", etc.) give additional hints for user interfaces.
** Agents should provide these in 9 and optionally 8.
** pcs can support these as desired.

* The new OCF_OUTPUT_FORMAT environment variable may be supported to indicate that the agent should output text or XML.
** Pacemaker's crm_resource and stonith_admin commands could set this appropriate to user-specified options before calling agents (at least for validate-all, which is the target use case).
** Agents may support this as desired.

* The OCF_CHECK_LEVEL environment variable may be supported for the validate-all action, to select host-independent or host-specific validation.
** Agents may support this as desired.
** Pacemaker could add an option to crm_resource and stonith_admin for check level when performing validation or monitoring.
** pcs could use the new pacemaker tool options if supported.

* Agent exit statuses have been clarified and expanded.
** Agents may support the new usage as desired. (Pacemaker already does.)

I may have missed some other places changes are needed, but those should be the most important.

Once adopted, the standard will be available at https://github.com/ClusterLabs/OCF-spec/tree/master/ra/1.1

This has been filed against 8.5 in case a subset will be implemented there, but may be cloned for or reassigned to 9.0, and some items could get their own bzs if separate tracking is desired
Comment 2 Ken Gaillot 2021-04-08 23:21:11 UTC 
Follow Bug 1937025 for how the resource-agents package will approach this. Once that is finalized, the same approach can be used here. This package should depend on the appropriate version of resource-agents to ensure the shell includes support OCF 1.1.
Comment 3 Daniel Yeisley 2022-02-02 16:48:19 UTC 
It looks like I'm running into this problem on RHEL 8.6.0. 

[root@isvqe-01 Certification]# pcs resource create SAPHanaTopology_RH2_02 SAPHanaTopology SID=BEN InstanceNumber=00 op start \
>                             timeout=600 op stop timeout=300 op monitor interval=10 timeout=600 clone clone-max=2 clone-node-max=1 interleave=true

Assumed agent name 'ocf:heartbeat:SAPHanaTopology' (deduced from 'SAPHanaTopology')
Error: Unable to process agent 'ocf:heartbeat:SAPHanaTopology' as it implements unsupported OCF version '0.155.0', supported versions are: '1.0', '1.1', use --force to override
Error: Errors have occurred, therefore pcs is unable to continue

[root@isvqe-01 Certification]# rpm -qa | grep hana
resource-agents-sap-hana-0.154.0-5.el8.noarch
Comment 4 Ken Gaillot 2022-02-02 17:25:19 UTC 
(In reply to Daniel Yeisley from comment #3)
> It looks like I'm running into this problem on RHEL 8.6.0. 
> 
> [root@isvqe-01 Certification]# pcs resource create SAPHanaTopology_RH2_02
> SAPHanaTopology SID=BEN InstanceNumber=00 op start \
> >                             timeout=600 op stop timeout=300 op monitor interval=10 timeout=600 clone clone-max=2 clone-node-max=1 interleave=true
> 
> Assumed agent name 'ocf:heartbeat:SAPHanaTopology' (deduced from
> 'SAPHanaTopology')
> Error: Unable to process agent 'ocf:heartbeat:SAPHanaTopology' as it
> implements unsupported OCF version '0.155.0', supported versions are: '1.0',
> '1.1', use --force to override
> Error: Errors have occurred, therefore pcs is unable to continue
> 
> [root@isvqe-01 Certification]# rpm -qa | grep hana
> resource-agents-sap-hana-0.154.0-5.el8.noarch

That sounds like the resource agent mistakenly has its version in the <version> tag rather than the <resource-agent ... version="..."> attribute (which is an easy mistake -- I would love to change <version> to <ocf-version> but that would be a backward compatibility headache).

As an aside, the OCF 1.1 standard has been formally adopted, and there is an upstream wiki page on updating resource agents: https://wiki.clusterlabs.org/wiki/Update_Resource_Agent_for_OCF_1.1
Comment 5 Frank Danapfel 2022-02-02 18:10:08 UTC 
(In reply to Daniel Yeisley from comment #3)
> It looks like I'm running into this problem on RHEL 8.6.0. 
> 
> [root@isvqe-01 Certification]# pcs resource create SAPHanaTopology_RH2_02
> SAPHanaTopology SID=BEN InstanceNumber=00 op start \
> >                             timeout=600 op stop timeout=300 op monitor interval=10 timeout=600 clone clone-max=2 clone-node-max=1 interleave=true
> 
> Assumed agent name 'ocf:heartbeat:SAPHanaTopology' (deduced from
> 'SAPHanaTopology')
> Error: Unable to process agent 'ocf:heartbeat:SAPHanaTopology' as it
> implements unsupported OCF version '0.155.0', supported versions are: '1.0',
> '1.1', use --force to override
> Error: Errors have occurred, therefore pcs is unable to continue
> 
> [root@isvqe-01 Certification]# rpm -qa | grep hana
> resource-agents-sap-hana-0.154.0-5.el8.noarch

This issue was already discovered on another Bugzilla, and Oyvind created a patch for it:
https://bugzilla.redhat.com/show_bug.cgi?id=2027423#c10

Looks like we need to get this patch backported in the resource-agents-sap-hana packages we ship for RHEL8.
Comment 6 Daniel Yeisley 2022-02-02 19:09:54 UTC 
(In reply to Frank Danapfel from comment #5)
> (In reply to Daniel Yeisley from comment #3)
> > It looks like I'm running into this problem on RHEL 8.6.0. 
> > 
> > [root@isvqe-01 Certification]# pcs resource create SAPHanaTopology_RH2_02
> > SAPHanaTopology SID=BEN InstanceNumber=00 op start \
> > >                             timeout=600 op stop timeout=300 op monitor interval=10 timeout=600 clone clone-max=2 clone-node-max=1 interleave=true
> > 
> > Assumed agent name 'ocf:heartbeat:SAPHanaTopology' (deduced from
> > 'SAPHanaTopology')
> > Error: Unable to process agent 'ocf:heartbeat:SAPHanaTopology' as it
> > implements unsupported OCF version '0.155.0', supported versions are: '1.0',
> > '1.1', use --force to override
> > Error: Errors have occurred, therefore pcs is unable to continue
> > 
> > [root@isvqe-01 Certification]# rpm -qa | grep hana
> > resource-agents-sap-hana-0.154.0-5.el8.noarch
> 
> This issue was already discovered on another Bugzilla, and Oyvind created a
> patch for it:
> https://bugzilla.redhat.com/show_bug.cgi?id=2027423#c10
> 
> Looks like we need to get this patch backported in the
> resource-agents-sap-hana packages we ship for RHEL8.

I didn't have a problem with RHEL 8.5.0, only on RHEL 8.6.0. I can open a bz.
Comment 7 Oyvind Albrigtsen 2022-02-03 12:47:49 UTC 
(In reply to Daniel Yeisley from comment #6)
...
> > Looks like we need to get this patch backported in the
> > resource-agents-sap-hana packages we ship for RHEL8.
> 
> I didn't have a problem with RHEL 8.5.0, only on RHEL 8.6.0. I can open a bz.

I'll clone the RHEL9 bz's, to get this fixed.
Comment 8 Oyvind Albrigtsen 2022-02-03 13:09:23 UTC 
bz's where this is getting fixed for 8.6 -hana/-scaleout packages (agents in the main resource-agents package is already working correctly):
https://bugzilla.redhat.com/show_bug.cgi?id=2050205
https://bugzilla.redhat.com/show_bug.cgi?id=2050196
Comment 10 Oyvind Albrigtsen 2022-07-25 07:39:30 UTC 

*** This bug has been marked as a duplicate of bug 2050205 ***