Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1937244

Summary: [Local Storage] The model name of aws EBS doesn't be extracted well
Product: OpenShift Container Platform Reporter: Wei Duan <wduan>
Component: StorageAssignee: Santosh Pillai <sapillai>
Storage sub component: Local Storage Operator QA Contact: Wei Duan <wduan>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: unspecified CC: aos-bugs, jsafrane
Version: 4.7   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:52:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Wei Duan 2021-03-10 09:02:01 UTC
Description of problem:
When checking the localvolumediscoveryresult and diskmaker-discovery log, the model of aws EBS has the extra space like 'Amazon Elastic Block Store              '.
$ oc get localvolumediscoveryresult discovery-result-ip-10-0-152-95.us-east-2.compute.internal -o yaml
  - deviceID: /dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol0aae98a99ce01086e
    fstype: ""
    model: 'Amazon Elastic Block Store              '
    path: /dev/nvme1n1
    property: NonRotational
    serial: vol0aae98a99ce01086e
    size: 2147483648
    status:
      state: Available
    type: disk
    vendor: ""
  discoveredTimeStamp: "2021-03-10T01:39:50Z"

$ oc logs diskmaker-discovery-h99d6
I0310 02:59:51.583237   64169 discovery.go:122] discovered devices: [{DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol056804b4a8520e3e8-part1 Path:/dev/nvme0n1p1 Model: Type:part Vendor: Serial: Size:1048576 Property:NonRotational FSType: Status:{State:NotAvailable}} {DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol056804b4a8520e3e8-part2 Path:/dev/nvme0n1p2 Model: Type:part Vendor: Serial: Size:133169152 Property:NonRotational FSType:vfat Status:{State:NotAvailable}} {DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol056804b4a8520e3e8-part3 Path:/dev/nvme0n1p3 Model: Type:part Vendor: Serial: Size:402653184 Property:NonRotational FSType:ext4 Status:{State:NotAvailable}} {DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol056804b4a8520e3e8-part4 Path:/dev/nvme0n1p4 Model: Type:part Vendor: Serial: Size:128311082496 Property:NonRotational FSType:xfs Status:{State:NotAvailable}} {DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol0aae98a99ce01086e Path:/dev/nvme1n1 Model:Amazon Elastic Block Store               Type:disk Vendor: Serial:vol0aae98a99ce01086e Size:2147483648 Property:NonRotational FSType: Status:{State:Available}}]

Version-Release number of selected component (if applicable):
Cluster version: 4.8.0-0.nightly-2021-03-08-184701
local-storage-operator: 4.7.0-202102110027.p0

How reproducible:
Always

Steps to Reproduce:
1. Create aws cluster
2. Install local storage operator and localvolumediscovery instance 
3. Check the localvolumediscoveryresult and diskmaker-discovery log

Actual results:
The model of aws EBS has the extra space like 'Amazon Elastic Block Store              '

Expected results:
The model of aws EBS should be 'Amazon Elastic Block Store'

Master Log:

Node Log (of failed PODs):

PV Dump:
  
PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 1 Jan Safranek 2021-03-12 16:25:55 UTC
Santosh, can you please look at it or assign it to someone else?  This could be simple TrimSpace() around everything LSO gets from udev.

Comment 2 Santosh Pillai 2021-03-16 04:56:24 UTC
(In reply to Jan Safranek from comment #1)
> Santosh, can you please look at it or assign it to someone else?  This could
> be simple TrimSpace() around everything LSO gets from udev.

I'll take a look at this.

Comment 4 Wei Duan 2021-03-22 02:46:22 UTC
Verified pass on local-storage-operator.4.8.0-202103202130.p0

localvolumediscoveryresult:
  - deviceID: /dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol03ed2461bc8ff4c4c
    fstype: ""
    model: Amazon Elastic Block Store
    path: /dev/nvme1n1
    property: NonRotational
    serial: vol03ed2461bc8ff4c4c
    size: 2147483648
    status:
      state: Available
    type: disk
    vendor: ""
  discoveredTimeStamp: "2021-03-22T02:40:44Z"

diskmaker-discovery log:
{DeviceID:/dev/disk/by-id/nvme-Amazon_Elastic_Block_Store_vol03ed2461bc8ff4c4c Path:/dev/nvme1n1 Model:Amazon Elastic Block Store Type:disk Vendor: Serial:vol03ed2461bc8ff4c4c Size:2147483648 Property:NonRotational FSType: Status:{State:Available}}

Comment 7 errata-xmlrpc 2021-07-27 22:52:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438