RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1937383 - A missing LF in /etc/default/grub caused a fail IPU upon reboot
Summary: A missing LF in /etc/default/grub caused a fail IPU upon reboot
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: leapp-repository
Version: 7.9
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Leapp team
QA Contact: Upgrades and Supportability
URL:
Whiteboard:
Depends On:
Blocks: 1818088
TreeView+ depends on / blocked
 
Reported: 2021-03-10 14:26 UTC by Christophe Besson
Modified: 2024-06-14 00:45 UTC (History)
7 users (show)

Fixed In Version: leapp-repository-0.17.0-1.el7_9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-09 12:33:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 6100621 0 None None None 2021-06-07 07:34:10 UTC

Description Christophe Besson 2021-03-10 14:26:33 UTC
Description of problem:
For an unknown reason, customer had a missing line feed at the end of /etc/default/grub:
~~~
[root@localhost ~]# cat /etc/default/grub 
GRUB_TIMEOUT=5
GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
GRUB_DEFAULT=saved
GRUB_DISABLE_SUBMENU=true
GRUB_TERMINAL_OUTPUT="console"
GRUB_CMDLINE_LINUX="rd.lvm.lv=vg_system/root rd.lvm.lv=vg_system/swap rhgb quiet transparent_hugepage=never processor.max_cstate=1 intel_idle.max_cstate=1 elevator=noop"
GRUB_DISABLE_RECOVERY="true"[root@localhost ~]# 
~~~

After running `leapp upgrade` and rebooted twice, the grub entry corresponding to the new RHEL 8 kernel was not present.
The userspace was fully updated, but some final leapp routines were not executed.

Additionally, the run of grubby was not stored in leapp-upgrade.log, but another related issue is visible in the journal upon reboot (done by the leapp.service, it's an obvious side effect):
~~~
Mar 10 12:33:57 localhost.localdomain leapp3[1413]: ============================================================
Mar 10 12:33:57 localhost.localdomain leapp3[1413]:                            ERRORS
Mar 10 12:33:57 localhost.localdomain leapp3[1413]: ============================================================
Mar 10 12:33:57 localhost.localdomain leapp3[1413]: 2021-03-10 12:30:27.027232 [ERROR] Actor: kernelcmdlineconfig
Mar 10 12:33:57 localhost.localdomain leapp3[1413]: Message: Failed to append extra arguments to kernel command line.
Mar 10 12:33:57 localhost.localdomain leapp3[1413]: Summary:
Mar 10 12:33:57 localhost.localdomain leapp3[1413]:     Details: Command ['grubby', '--update-kernel=/boot/vmlinuz-4.18.0-193.28.1.el8_2.x86_64', '--args=net.ifnames=0'] failed with exit code 1.
~~~

The resulting /etc/default/grub is wrong:
~~~
# cat /etc/default/grub 
GRUB_TIMEOUT=5
GRUB_DISTRIBUTOR="$(sed 's, release .*$,,g' /etc/system-release)"
GRUB_DEFAULT=saved
GRUB_DISABLE_SUBMENU=true
GRUB_TERMINAL_OUTPUT="console"
GRUB_CMDLINE_LINUX="crashkernel=auto spectre_v2=retpoline rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap rhgb quiet"
GRUB_DISABLE_RECOVERY="true"GRUB_ENABLE_BLSCFG=true
~~~

And the BLS entries in /boot/loader/entries only contain the RHEL 7 kernels.


Version-Release number of selected component (if applicable):
leapp-repository-0.13.0-2.el7_9.noarch

How reproducible:
100%

Steps to Reproduce:
1. truncate -s -1 /etc/default/grub
2. leapp upgrade
3. reboot twice

Expected result:
A small check and/or fix to prevent this issue (even if ultimately the issue resides in grub postinst rpm, I didn't check).

Comment 11 Petr Stodulka 2022-08-17 16:33:07 UTC
This is going to be fixed by:
  * https://github.com/oamg/leapp-repository/pull/945

Comment 12 Petr Stodulka 2022-08-23 16:37:04 UTC
The PR has been merged in the upstream.

Comment 17 errata-xmlrpc 2022-11-09 12:33:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (leapp and leapp-repository bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7895


Note You need to log in before you can comment on or make changes to this bug.