Bug 1937578 - Package very out of date
Summary: Package very out of date
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: android-tools
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ivan Afonichev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-11 03:02 UTC by timotheel-f
Modified: 2021-04-02 01:21 UTC (History)
3 users (show)

Fixed In Version: android-tools-30.0.5p1-1.fc33
Clone Of:
Environment:
Last Closed: 2021-04-02 01:21:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description timotheel-f 2021-03-11 03:02:36 UTC
The Android-tools package is extremely out of date.

Instead of a super complicated build system, Fedora could do what Alpine is doing:
https://git.alpinelinux.org/aports/tree/testing/android-tools/APKBUILD


Which is using https://github.com/nmeum/android-tools. It gives a simple cmake build system for the latest release and would faciliate a lot the maintenance.

Comment 1 Ivan Afonichev 2021-03-11 05:33:47 UTC
Hm, that looks very promising thanks!
I succeeded in porting Mageia8 build to fedora but nmeum looks like better way, thanks!

Comment 2 timotheel-f 2021-03-14 02:16:12 UTC
https://src.fedoraproject.org/rpms/android-tools/pull-request/4

First time making RPM, so it is probably very inadequate, but please consider suggesting modifications so that it can be merged as soon as possible. 

Thanks!

Comment 3 Ivan Afonichev 2021-03-14 16:49:03 UTC
```
[van@iafonichev-nb vendor]$ ldd adb
	linux-vdso.so.1 (0x00007ffdd09ef000)
	libssl.so => /home/van/rpmbuild/BUILD/android-tools-30.0.5p1/x86_64-redhat-linux-gnu/vendor/boringssl/ssl/libssl.so (0x00007efcedc15000)
	libprotobuf.so.23 => /lib64/libprotobuf.so.23 (0x00007efced901000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007efced8df000)
	libbrotlidec.so.1 => /lib64/libbrotlidec.so.1 (0x00007efced8d1000)
	libbrotlienc.so.1 => /lib64/libbrotlienc.so.1 (0x00007efced840000)
	liblz4.so.1 => /lib64/liblz4.so.1 (0x00007efced822000)
	libusb-1.0.so.0 => /lib64/libusb-1.0.so.0 (0x00007efced803000)
	libz.so.1 => /lib64/libz.so.1 (0x00007efced7e9000)
	libzstd.so.1 => /lib64/libzstd.so.1 (0x00007efced725000)
	libcrypto.so => /home/van/rpmbuild/BUILD/android-tools-30.0.5p1/x86_64-redhat-linux-gnu/vendor/boringssl/crypto/libcrypto.so (0x00007efced58c000)
	libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007efced3a4000)
	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007efced389000)
	libc.so.6 => /lib64/libc.so.6 (0x00007efced1bc000)
	libm.so.6 => /lib64/libm.so.6 (0x00007efced076000)
	/lib64/ld-linux-x86-64.so.2 (0x00007efcedd78000)
	libbrotlicommon.so.1 => /lib64/libbrotlicommon.so.1 (0x00007efced053000)
	libudev.so.1 => /lib64/libudev.so.1 (0x00007efced028000)
```
boringssl seems to be used as dynamic library which is not included in rpm so it will not work.

Comment 4 timotheel-f 2021-03-14 19:06:35 UTC
Yours (823ac9f1415293dad5e15bc75b0ae41d24a90e29) looks a lot better, thanks!

DBUILD_SHARED_LIBS:BOOL=OFF
CMake Error at /usr/share/cmake/Modules/CMakeDetermineCCompiler.cmake:49 (message):
  Could not find compiler set in environment variable CC:
  gcc.

Odd... does it need BuildRequires:  gcc ?

Comment 5 timotheel-f 2021-03-14 22:19:47 UTC
https://src.fedoraproject.org/rpms/android-tools/pull-request/5

With a couple of other deps I think you forgot. When I tried the first time, the build complained about them missing.

They are also specified by the github repo.

Comment 6 Fedora Update System 2021-03-24 20:06:42 UTC
FEDORA-2021-0dda64cc5d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0dda64cc5d

Comment 7 Fedora Update System 2021-03-25 01:32:26 UTC
FEDORA-2021-0dda64cc5d has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0dda64cc5d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0dda64cc5d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-04-02 01:21:11 UTC
FEDORA-2021-0dda64cc5d has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.