Bug 1937868 - Review Request: golang-github-msprev-fzf-bibtex - A BibTeX source for fzf
Summary: Review Request: golang-github-msprev-fzf-bibtex - A BibTeX source for fzf
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-11 16:38 UTC by Daniel Moerner
Modified: 2021-03-17 15:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-03-17 15:16:30 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Daniel Moerner 2021-03-11 16:38:55 UTC
Spec URL: https://moerner.com/fedora/golang-github-msprev-fzf-bibtex.spec
SRPM URL: https://moerner.com/fedora/golang-github-msprev-fzf-bibtex-1.1-0.1.20210311git53c49fa.fc35.src.rpm
Description: A BibTeX source for fzf. fzf-bibtex uses BibTool parse BibTeX files, caches the results, and supports vim integration for users of the fzf.vim plugin. It includes support for Markdown and LaTeX citation formats.
Fedora Account System Username: dmoerner

Comments:

- I do not need sponsoring, but this is my first solo-maintained package and my first golang package, so any comments will be helpful.
- Since this is really just a set of binaries, not a library, I decided it would be appropriate to not ship the code with %gopkginstall and %gopkgfiles. I'm happy to add these back in if I should.
- Upstream's github includes release notes for a 1.1 release from Feb 2020. However, I cannot find this release packaged in a tarball, and all development seems to just use git.
- rpmlint reports "E: shared-lib-without-dependency-information". I believe this is a false positive: https://github.com/rpm-software-management/rpmlint/issues/598.

Comment 1 Robert-André Mauchin 🐧 2021-03-16 17:36:28 UTC
 - Should be 1 since it's after the release:

Release:        0.1%{?dist}

 - Remove %gopkg as well if you don't need the library

 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Daniel Moerner 2021-03-16 18:59:47 UTC
Thank you for the quick review and fixes! I have incorporated your changes.

Comment 3 Tomas Hrcka 2021-03-17 10:08:01 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-msprev-fzf-bibtex


Note You need to log in before you can comment on or make changes to this bug.