Red Hat Bugzilla – Bug 193806
Review Request: libsvg
Last modified: 2007-11-30 17:11:34 EST
Spec URL: http://www.ece.ucdavis.edu/~ewwork/repo/5/SPECS/libsvg.spec
SRPM URL: http://www.ece.ucdavis.edu/~ewwork/repo/5/SRPMS/libsvg-0.1.4-1.src.rpm
libsvg renders SVG documents but cannot render SVG alone. It requires an
external rendering engine to be provided via a callback-based interface.
Your GPG key 0x6ee49286 cannot be found on pgp.mit.edu and
keyserver.net (home pages: http://pgp.mit.edu/ and
Thanks for letting me know, I will look into that. For the time being it can be
found at http://www.ece.ucdavis.edu/~ewwork/repo/RPM-GPG-KEY-ework.
I have put my key onto those two sites. Let me know if you have any changes
that should be done to the SPEC file.
> checking for pkg-config... no
Missing 'BuildRequires: pkgconfig'
> BuildRequires: libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel
> %package devel
> Requires: libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel
Oh, it uses libjpeg and libpng headers, but doesn't link to the libs.
I suggest you mention that as a comment in the .spec file, as libsvg
users must link to these libs then (cf. pkg-config file dependencies!).
In this case, "Requires: pkgconfig" is a MUST for the -devel package.
File 'INSTALL' in %doc is of no interest to package users.
Don't include it.
$ cat libsvg-0.1.4.tar.gz.md5
With those minor changes: APPROVED