Spec URL: https://yanqiyu.fedorapeople.org/fcitx5-mozc/fcitx5-mozc.spec SRPM URL: https://yanqiyu.fedorapeople.org/fcitx5-mozc/fcitx5-mozc-2.17.2102.102.1-1.gitdf9f395.fc34.src.rpm Description: A wrapper of mozc for fcitx5. Fedora Account System Username: yanqiyu
- Seems the URL is wrong: URL: https://github.com/fcitx/fcitx5 Shouldn't that be: URL: https://github.com/fcitx/mozc - Should be 1 past the release: # upstream don't tag release # build git snapshot Release: 0.0%{?dist} → Release: 1%{?dist} […] * Fri Mar 12 2021 Qiyu Yan <yanqiyu> - 2.17.2102.102.1-1.20210317gitdf9f395 - Remove various trailing spaces - Should be python3-devel BuildRequires: python → BuildRequires: python3-devel - Should run python3 not 'python' PYTHONPATH="${PYTHONPATH}:../../" python3 ../../dictionary/gen_zip_code_seed.py --zip_code=../../../KEN_ALL.CSV --jigyosyo=../../../JIGYOSYO.CSV >> dictionary09.txt; […] python3 build_mozc.py gyp --gypdir=%{_bindir} --server_dir=%{server_dir} --target_platform=Linux python3 build_mozc.py build -c Release server/server.gyp:mozc_server gui/gui.gyp:mozc_tool unix/fcitx5/fcitx5.gyp:fcitx5-mozc - Use install -p to keep timestamps: install -D -pm 755 "out_linux/${_bldtype}/mozc_server" "%{buildroot}%{server_dir}/mozc_server" install -D -pm 755 "out_linux/${_bldtype}/mozc_tool" "%{buildroot}%{server_dir}/mozc_tool" - Add Requires: hicolor-icon-theme to own the icons directories - Please document why these patches are necessary: Patch0: mozc-build-verbosely.patch Patch1: fix-build-gcc11.patch - Try to unbundle the third party s much as you can: abseil-cpp, gtest, gyp, jsoncpp, protobuf are already packaged in Fedora. - See https://src.fedoraproject.org/rpms/mozc/ if you need to lift some patches, notably you should try to build with gcc instead of clang
- document the licenses as much as possiblelike in google-mozc: # data/unicode/: UCD # Copyright (c) 1991-2008 Unicode, Inc. # data/test/stress_test/sentences.txt: Public Domain # data/dictionary_oss/: mecab-ipadic and BSD # See http://code.google.com/p/mozc/issues/detail?id=20 # also data/installer/credits_en.html - /usr → %{_prefix} and /usr/share → %{_datadir} Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated", "[generated file]", "Apache License 2.0", "*No copyright* Apache License 2.0", "FSF All Permissive License", "Unicode strict BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License [generated file]", "FSF Unlimited License (with Retention) [generated file]", "FSF Unlimited License [generated file]", "BSD 2-clause "Simplified" License", "Expat License", "*No copyright* Expat License", "GNU Library General Public License v2 or later", "*No copyright* [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "Expat License [generated file]", "GNU General Public License v2.0 or later", "FSF Unlimited License (with Retention) GNU General Public License v2.0 or later", "FSF Unlimited License (with Retention)", "*No copyright* BSD 3-clause "New" or "Revised" License", "GNU General Public License", "Microsoft Public License", "*No copyright* Public domain", "curl License", "*No copyright* Apache License", "BSD 4-clause "Original" or "Old" License Apple Public Source License 2.0", "BSD 2-clause "Simplified" License Apache License 2.0", "Apple Public Source License 2.0". 4284 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/fcitx5-mozc/review- fcitx5-mozc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fcitx5-mozc-2.17.2102.102.1-0.0.gitdf9f395.fc35.x86_64.rpm fcitx5-mozc-debuginfo-2.17.2102.102.1-0.0.gitdf9f395.fc35.x86_64.rpm fcitx5-mozc-debugsource-2.17.2102.102.1-0.0.gitdf9f395.fc35.x86_64.rpm fcitx5-mozc-2.17.2102.102.1-0.0.gitdf9f395.fc35.src.rpm fcitx5-mozc.x86_64: W: incoherent-version-in-changelog 2.17.2102.102.1-0.0 ['2.17.2102.102.1-0.0.gitdf9f395.fc35', '2.17.2102.102.1-0.0.gitdf9f395'] fcitx5-mozc.src: W: invalid-url Source0: fcitx5-mozc-df9f395b5c2ea022a6ab18e8aa7dbe69bc7eea29.tar.gz 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
- URL fixed - Release number changed to 1 - trailing spaces at the end of file? Only one empty line left now - changed to python3/python3-devel - added -p to install - Requires: hicolor-icon-theme, done - added some comment on each PatchX: ... line - all exclude abseil-cpp, unbundle done, upstream code hard coded to use internal abseil-cpp, a lot patch work may be needed to unbundle abseil-cpp - already building with GCC+libc++, and tested not having problems - added comments to license field - due to https://src.fedoraproject.org/rpms/mozc/blob/rawhide/f/mozc.spec#_7, I think my package will also get affected, adding excludearch. - changed to using macros more consistently, including all scripts used.
Package approved.
Thank you for the review, Robert-André https://pagure.io/releng/fedora-scm-requests/issue/33053
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fcitx5-mozc
Built in rawhide, closing.