This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
Bug 1938263 - [CDI] Pod placement configuration - dry run is not performed for all the configuration stanza
Summary: [CDI] Pod placement configuration - dry run is not performed for all the conf...
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Storage
Version: 4.8.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 4.15.0
Assignee: Arnon Gilboa
QA Contact: dalia
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-12 15:58 UTC by Satyajit Bulage
Modified: 2024-04-13 04:25 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-14 16:03:59 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Incorrect infra configuration. (457 bytes, text/plain)
2021-03-12 15:58 UTC, Satyajit Bulage 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   CNV-10963 0 None None None 2023-12-14 16:03:58 UTC
Red Hat Issue Tracker CNV-32017 0 None None None 2023-08-14 07:44:20 UTC

Description Satyajit Bulage 2021-03-12 15:58:58 UTC 
Created attachment 1763038 [details]
Incorrect infra configuration.

Description of problem:
Incorrect information related to infra configuration provided to CDI CR through the HCO spec is being accepted.


Version-Release number of selected component (if applicable):4.8


How reproducible:100%


Steps to Reproduce:
1.Add attached yaml contents in the HCO CR spec
2.Observe the HCO CR status in the UI as well as CLI


Actual results: Changes to HCO CR are propagated to CDI CR which is accepted which leads to HCO CR keeping itself in Progressing state and never completes.


Expected results: Changes made to the Infra under HCO CR spec should be refused by CDI CR as they are incorrect.


Additional info:In the attached example the wrong part of the configuration is the "Equal" operand which doesn't exists.

HCO CR refuse to update incorrect changes which is fixed in the BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1893646).
Comment 1 Inbar Rose 2021-04-19 06:26:19 UTC 
Can we get an update on the status please? This is blocking automation.
Comment 2 Arnon Gilboa 2021-04-19 10:18:50 UTC 
Inbar, we moved it to next Sprint, but in case it's AutomationBlocker we'll do it this sprint. I'll update once there is a PR.
Comment 3 Adam Litke 2021-05-18 17:50:31 UTC 
This is going to take a little more time to get right.  Therefore I am pushing out to 4.9.  The workaround is to simply pass correct data.
Comment 4 Inbar Rose 2021-05-19 09:55:33 UTC 
@adam litke can we maybe target it to a 4.8.Z stream?
Comment 5 Adam Litke 2021-05-19 18:45:52 UTC 
@Inbar, The fix is going to be too complex and risky to be a z-stream candidate.  Plus, since this bug isn't too severe and has a simple workaround it would be hard for me to justify the risk.
Comment 6 Adam Litke 2021-08-16 13:38:52 UTC 
This depends on some refactoring of the CDI operator which did not land in time for 4.9.  Therefore we need to push this out to 4.10.
Comment 8 Yan Du 2021-11-24 13:39:32 UTC 
Hi, Arnon, Do we have any update for this bug?
Comment 9 Natalie Gavrielov 2021-11-24 14:08:01 UTC 
Removing keyword 'automation blocker', since it's not an automation blocker.
Satyajit, was this issue found using automation? if so, please add a keyword 'automation'
Comment 10 Arnon Gilboa 2021-11-25 15:10:12 UTC 
Yan, no update. As Adam commented, it depends on some refactoring of the CDI operator.
Michael, I guess it will wait for 4.11?
Comment 11 Satyajit Bulage 2021-12-02 09:19:32 UTC 
Hello Natalie,
It is blocking me to write automation as it is not honoring the dry run.
Thanks,
Satyajit.
Comment 12 Yan Du 2022-06-22 12:04:42 UTC 
Arnon, has the refactoring that you are waiting on been completed? please provide the update on this bug
Comment 13 Arnon Gilboa 2022-06-22 13:05:22 UTC 
Yan, refactoring was not done yet. afair @mhenriks was supposed to work on it. Removing it from 4.11.
Comment 15 Adam Litke 2023-08-09 17:59:58 UTC 
Arnon, please advise when will be a good time to complete this.  If it is blocked by something, please ensure that the required work is documented in a Jira issue and linked to this bugzilla.
Comment 16 Arnon Gilboa 2023-08-14 07:44:21 UTC 
Adam, as Michael mentioned in the Jira, the issue is that the CDI CR needs to be validated at creation time. In order to do that, cdi-operator must implement a validating webhook for CDI resources. It is not a minor change but a significant refactoring work. It can be targeted to 4.15 if prioritized. wdyt?
Comment 17 Red Hat Bugzilla 2024-04-13 04:25:02 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days
Note You need to log in before you can comment on or make changes to this bug.