Description of problem: Some times, it was observed that some of the important fields are left blank e.g. Product Page URL. While submitting a new Hardware Certification request through hardware.redhat.com, e.g. if "Product Page URL" field is left blank, then it should alert with the "help" message like "Please enter Product Page URL OR mention N.A. You may need to specify product specifications or attach product specification sheet in the request". If Product Page URL or product specifications are not mentioned, then review process could not be initiated. This will avoid delays causing due to lack of information about product specifications Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.Login to hardware.redhat.com 2.Click on "Create" 3.Then go to Product Page URL. Presently, even if you keep this field blank and just attach the test rpm and click "Continue", the request will be submitted. In this case, if "Product Page URL" field is left blank, it should alert with the help message like "Please enter Product Page URL OR mention N.A. You may need to specify product specifications or attach product specification sheet in the request". Actual results: Expected results: If "Product Page URL" field is left blank, it should alert with the help message like "Please enter Product Page URL OR mention N.A. You may need to specify product specifications or attach product specification sheet in the request". Additional info:
Created attachment 311676 [details] Patch Fix: Add a piece of javascript to check the create cert form's "Product Page URL" whether or not is NULL(leave blank). if "NULL",then pop up a alert dialog box whose warning message is "Please enter "Product Page URL" or mention "N/A". You may need to specify product specifications or attach product specification sheet in the request". Above patch's solution is just an option for fixing this bug. AFAIK,our catalog won't love the "pop-up" alert dialog box by javascript. if so, I have another thought for fixing this bug: throw the user error which means when vendor left the "Product Page URL" blank and summit, then throw a user's error by the function "ThrowUserError("Miss Product Page URL")". Rob, please give me some suggestion. Best Regards! Nicho
Created attachment 312013 [details] Patch Improve: Follow Rob 's suggestion: show the warning message in the "Verify Certification" page. Pls review. Nicho
Created attachment 312014 [details] Screenshot for the warnning message.
Created attachment 312029 [details] Another patch for this bug. This patch use another warning style for notice. its style is like the NOTICE for "retiring the rhr package" in our catalog's index page.
Suggestion; instead of the top clearBoxWide, how about simply highlighting in the summary section that no URL has been provided? This could also feature creep to go ahead and also highlight (again in the summary section where the fields are) that make and model haven't been provided if they are the default values. So this bug could resolve a more generic missind data issue.
Created attachment 312311 [details] Patch Improve: Fllow Rob's suggestion. 1.highlighting message "no URL has been provided" in the URL field when missing URL. 2.highlighting message "Make hasn't been provided" in the Make field when missing Make. 3.highlighting message "Model hasn't been provided" in the Model field when missing Model. pls review Best Regards! Nicho
Comment on attachment 312311 [details] Patch Improve:
Created attachment 312312 [details] The correct patch for review. pls ignore the patch which attach_id is "312311"
Created attachment 312313 [details] The screen snap shot for the warnning messages. also can visit the http://bugdev.devel.redhat.com/hwcert-xisun2 to see the new change for high lighting the missing data. Nicho
The screen shot helps thanks, I think the language can be simplified to "(Not Provided)" instead of the unique error messages; but otherwise looks good.
Created attachment 312364 [details] Patch Improve: Simplified to "(Not Provided)" instead of the unique error messages
Created attachment 312382 [details] Patch Improve: 1.add js for when data source is changed to provide manually,change the default to "Not Provided". pls review Nicho
Testing on -xisun5 shows the change, but the (Not Provided) does not appear in red and "model" ends up with no value on the verify page?
Actually we're going the wrong way, make and model should user error and tell the vendor to do it again. The URL can just display in red (Not Provided) on the confirmation screen because on the 1st page it's prepopulated with http:// so (Not Provided) ends up meaning the same thing as a blank http:// marker.
Created attachment 312412 [details] Patch Improve: 1.Use ThrowUserError for Make and Model. 2.Add two UserError type.(missing_make & missing_model) 3.keep URL's part no changes. The test link is http://bugdev.devel.redhat.com/hwcert-xisun2/enter.cgi Pls review. Thanks a lot Nicho
Looks good; please commit.
tested and run good