Description of problem: customer is removing vlan from host interface, lldpad and fccoe services are restarted as result of /usr/libexec/vdsm/hooks/before_network_setup/50_fcoe hook Version-Release number of selected component (if applicable): rhv 4.4.4 How reproducible: everytime Steps to Reproduce: 1. remove vlan from host wihile host is Up Actual results: storage domains become invalid dor shot time because fcoe service is restarted Expected results: no storage outage Additional info: hw used on the host side: 37:00.0 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 25GbE Controller [1077:1656] (rev 10) 37:00.1 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 25GbE Controller [1077:1656] (rev 10) 37:00.2 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 10/25/40/50GbE Controller (FCoE) [1077:165c] (rev 10) 37:00.3 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 10/25/40/50GbE Controller (FCoE) [1077:165c] (rev 10) 37:00.4 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 25GbE Controller [1077:1656] (rev 10) 37:00.5 Ethernet controller [0200]: QLogic Corp. FastLinQ QL45000 Series 25GbE Controller [1077:1656] (rev 10) there is no setup for the interfaces, it looks like the interfaces are full offloading
why does it happen on vlan removal? this hook is run on setup networks, that shouldn't be such a common operation?
(In reply to Michal Skrivanek from comment #1) > why does it happen on vlan removal? this hook is run on setup networks, that > shouldn't be such a common operation? Almost every network operation goes through setup networks and because this hook is in before setup it will run before every setup no matter what is in that setup. Looking at this hook we could probably restart those services only if something has changed with the fcoe and not every time.
No regression seen with this fix. This can be closed as current release. Customer has approved the fix.
Regression tested on vdsm-4.40.60.4-1.el8ev.x86_64 and rhvm-4.4.6.5-447.gd80dda7.9.el8ev.noarch
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days